From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 20101427F0 for ; Sun, 1 May 2022 04:51:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2B22568B30A; Sun, 1 May 2022 07:51:56 +0300 (EEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 65D4D68AE7E for ; Sun, 1 May 2022 07:51:49 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1651380714; x=1682916714; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=KRM0eK6Lj0sDarXKR5o6uskSU9Fo/E2Y5nsSSLHfykA=; b=MW+BTm78qo7AOpFv/fxqrwr2Sz2cJ5a/URC2+a/qFy0XvoAFX9H3Mx/H wIsRfuUkxeEWwTJCbZGR1+EC1gZqkmtvA5p9vJZQcTfv8vTyAGBssgIyY uSZDrTV6qvT9MBBkErPfa74Vd3OyHpHrWo2HBqG/VN+NkSBWiy+HN79ai r6Yu1Jx0OCt3v4R+EXRTTrg4W2cZxLkpOEfwFlE6oEHpvDwWzsaAVIcB0 YZyqvm8CPp4mT8WDWIVH85PSrZnCYJDQlkqhxMNdOGxO7pf22oq7Z2I4r MwU+x/+jXmuqQ7ukaAq6b6bHSkX2kselvnn9A1kiJptFXH8lG8Ij8YJZe Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10333"; a="254384931" X-IronPort-AV: E=Sophos;i="5.91,189,1647327600"; d="scan'208";a="254384931" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2022 21:51:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,189,1647327600"; d="scan'208";a="544741705" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga002.jf.intel.com with ESMTP; 30 Apr 2022 21:51:45 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 30 Apr 2022 21:51:45 -0700 Received: from orsmsx604.amr.corp.intel.com (10.22.229.17) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Sat, 30 Apr 2022 21:51:45 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Sat, 30 Apr 2022 21:51:45 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Sat, 30 Apr 2022 21:51:44 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nnvljQ5cIjDc6O/vPeKtdO93c0HQjuPlBpKZVwa0TqSzRoD7bIzG1wPWyojbI5MFAGA58VlUPt/IgHiZjtVHlfmg2ImezQtNr9GqNlbI1nJHnHjnXqPVcO/5eVkX3PDk76ZgzZEhLvXVLV1L7Gpr75zIi/XgxKeC7pLmKnz3H6cFOwwMfHPnM2L7sG9/AaX0u4wzPEd9ekx3ukFt6Spr9ufS5cxCnVLwvl0KVGWS//OWKh8afJeoHf9TLUCos0mYUVxN6c9PBCFMsHve0A4US3X4N5bOenwDWHuCGDQrf5Ajt40YlweNc5L4xcq+Dav1IJlpk2hR5i3b+pARGUMJKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KRM0eK6Lj0sDarXKR5o6uskSU9Fo/E2Y5nsSSLHfykA=; b=OgIQYlxjKohCwOJNyKXOGeTy7JSFyQCmbVLr5UfhAgwOg/aHNgx4yauS52EHaURbgqHkK0gKiuEkQMous4c0z/Ubm3gRWnAjEriKBzoGZaNQknQJJg9AyQ5S9BOeC5NbWFt/vZg0nTRzO1WHUkLT192/RxVpplFk3TpBGkMMtUNzqLHsf7fx3SM2zRGQpdSa2C1QbCDvvaxX/MyLhF2idd4q3+r94UH4NyvZfu0yeWNxHDo8MORgAzBqGYqqzA3kExto4vDrw6j6DXKy3QYFM91qWxp0swrjYgQfw0XqhWVfQyUiAC9PuGprnIAYuAHadcfge/prRUn/NVmAt2LqkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from BN9PR11MB5515.namprd11.prod.outlook.com (2603:10b6:408:104::8) by CH0PR11MB5524.namprd11.prod.outlook.com (2603:10b6:610:d7::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5186.14; Sun, 1 May 2022 04:51:43 +0000 Received: from BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::6534:444c:a75d:4bf2]) by BN9PR11MB5515.namprd11.prod.outlook.com ([fe80::6534:444c:a75d:4bf2%9]) with mapi id 15.20.5186.028; Sun, 1 May 2022 04:51:42 +0000 From: "Xiang, Haihao" To: "anton@khirnov.net" , "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 Thread-Index: AQHYNSBkBvoiSbR4nEyekphDyYl7/6zhXE4AgAEI5wCAJpWKgIAAnd8AgAAPGICAABwZgA== Date: Sun, 1 May 2022 04:51:42 +0000 Message-ID: <99d97f51de78fdbe99a309272be81cce2efafd16.camel@intel.com> References: <20220311081630.21927-1-haihao.xiang@intel.com> <20220311081630.21927-6-haihao.xiang@intel.com> <164915940053.21047.6940981970361137655@lain.red.khirnov.net> <1d8c77d974f4efc794b02362bc21d557025abad8.camel@intel.com> In-Reply-To: Accept-Language: en-AS, zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Evolution 3.28.5-0ubuntu0.18.04.2 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f2b17db2-5843-4788-64f8-08da2b2e4933 x-ms-traffictypediagnostic: CH0PR11MB5524:EE_ x-microsoft-antispam-prvs: x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AMgHNXu8K6usVlPGgELWkA+bkXoVpIPaXPsxsX3bRdkOD7X+uH2o5jQct8CPVPYiJrRczEgc3UgmpFwq+u83QtT/CfxD3WXUr806JQcGTkYStIGnid42i5IMw4c5xD3ERCr6M1AHg22jUKsLycRZjiZ+HS5qjCAsxvW2LMAFr7cgpPKgic8O81YjaswOsv56V5w/frEWhs1/bO0hal0UNd/+vpUwjlEoFpW/dY0BnIFZZajyL0Y9F586dJu7usn9vszCXmpDQpVMT6JuVOqiOafZtXp5Fa2zqujRhuekN1FTRsQx6Q/JsFGwcvOHpe643NltiuciS6NNM70PoKE4Ajx+Oaf7lq0nujLk6Vs4xwohmv1BGRK48YYOgNopadd8aJ1gvl72KUaqgp7lSk87bqf6Mp7oTA5ykocP63BIPdMTr2lRaq01PXjzqytCcNbMBBU3r8AN71gzTJQtkdoq3HOHpu0LhxwBrcyGvF4sfKh8VtWv0SKCyWyIJI3C8JEWRYqh037WkhU9O0DgBcr5tzDBKyHElbfWFiGY8rcN/6SAG+3HfBcyDdlolDAorKDD9LSEtx2TT0PA0/3nq9SegHGpn6UNLRjMcGQqnQN7V+ql7D7mDzbN8JRrRKF7Cd4z8SwPbrfqohq6ScS4zzh7YxDeEJ/LivuphYLCtUIWIvzvYn6PooITkUpDMfL6LduP5aHI7twzsp8AAzqAYQYys04pBFYyZpvHgE10xJXocDR5kDmEUqQ21NEAVUA3mPx5xLgSyR9+WbsYYWd79WzFNABso2CB9leE2jjSyFkgRnekfchucODNvqyia7bS2fkyp8tB099v8HWdytHCVrTXHUDz/ceEr4/j9nMh8igA5d8= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN9PR11MB5515.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(6512007)(508600001)(86362001)(91956017)(8936002)(966005)(76116006)(36756003)(6506007)(186003)(6486002)(5660300002)(316002)(83380400001)(38070700005)(38100700002)(53546011)(2616005)(26005)(122000001)(2906002)(110136005)(66946007)(66446008)(8676002)(66476007)(71200400001)(64756008)(66556008)(82960400001)(99106002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?L1h0V2w2dXBKbTdqcVVNQjlCQzQvLzRDelhDSCtQZE9YNW5LN1VxaGwwS3c2?= =?utf-8?B?SVQxQzVhaUNyTDZlUS9Kc3BpR0s2RWg1VFNJdlRtNEpRQkxVMEQ1RHhYUXc0?= =?utf-8?B?WEc5WjRjQ21tNEsvY2ZOR1A0amxsb2c0QkorNXpHNjVwTHJySWJwRUVoVmZz?= =?utf-8?B?eTZ6d1RuWm4wMXprUFdDVnhicHdkSDdIY2Q4OVlNOXFKb2tmdEI5bDAyOVls?= =?utf-8?B?UGtKVWN3Qjhya0hMSHFaaUFTbWt3RjVkUU5HcUVRS0dKbU1Gb21sYkZXZ2U0?= =?utf-8?B?VjM5VWsvRXFBcHRnRDlKOVJLNkpiWE1OeHFkdlB1UTM3RjljeFVqSDRpQ0Nl?= =?utf-8?B?WGwwUXFLWllmUURGZldya3NCTGV3Vml2cnhrRzN3bStGNUJ5aUxhdEl1ZnYz?= =?utf-8?B?MGNuWmU3SFQwM1JtWEpjTWYza08yd0VvMDVkT3hFQkFVcWdsOVJxVUEwekY5?= =?utf-8?B?aHBEcWlYVTdTM0hSMmxqQktEYkU3N2ZuUi8wMWk2VkEzMTZBMnMxYTc1akhi?= =?utf-8?B?dHhGa25mc2MyRWhDODRWb0pGcmhDWTZyRi9IekhjcGI2eXBPQjJVdkE5b1Yx?= =?utf-8?B?cWhoSXJEYnN0V09FSzdqUFFnR1JiZGdmRjVRc0tXT09hTU5TUWVGVkQ5czV4?= =?utf-8?B?eDJFa3lKdTA2R0dSeFpaVG5MaysxQjkrSVVEajcvUHFFYzNtSjlCYTYwdnNB?= =?utf-8?B?RFFuMXhPYncydlN6VjY2VWYvL0pFSDVpaTV4Um5udTRyd3ZwMzhtVTJGdHpi?= =?utf-8?B?QlFBNy9TLzBZdnhDOFlhK296UmRJVHRRZFFURjJjaGdsd2hWQTB1MnBOVVBH?= =?utf-8?B?QTUwSHRDZlg2endOTmRtVCszd0JpZVZ5dnJNWVRtV0hOaThYVENkM2FSaW0x?= =?utf-8?B?bVZEN3pnRnMyQS93V2kzK1ZnWjZkZGhLeUN2SlV0OVBYb0xuUXd1NnRjV2ZE?= =?utf-8?B?SmtaT0pkZGgyYVMybmNseVVBSWZpTXVRN1FTSVlUbHAxVGdCclhTS3lCMUJH?= =?utf-8?B?QzRrUEQzTGx0K2s2Y2RjN3BRcjYzRDdYMi9nVGVKSEdiWC9wTXZYM3YrQ3RW?= =?utf-8?B?Y2dMdzYrbDN2K3dsMTJRQnFiYkllR2UvVlV6djlZZFA1L1ZDdmYwMlFmTmRI?= =?utf-8?B?QzBtU0FIRDBmRjF0OHdqaWNDU25XeGZuNTFFN3RxRksxNUdFb2ZtbGFkZ0M5?= =?utf-8?B?d3FjdzN3Z0V1QUhNU2VvRzFaQzVZUDB0cXM2TXpmWlhiUWNXL3ZHcXhZcDRX?= =?utf-8?B?dmtJSEtFUUpmS0lwS1l2VHA4cHZRbmtjbmJYVmg0VW1zODhZbVliZDZLTXFC?= =?utf-8?B?SDVwQlAyN0VUTXdlRC9RNnBncDB1SXByYjU4M0hXMlBVN3duVE14SjQ5RmNI?= =?utf-8?B?U1BxQnFLdjdXS0prV3VWVFpNc3h1NXluNHdRaHM5dnVSU2duWVdVRzF4UFpW?= =?utf-8?B?aGtIcjBVQUhJamJUaWdoZytsNm04Q3VOa0tjNlBPNFd4VVd4L0R1TjBBK0Jx?= =?utf-8?B?ZUVKYnZTdUpaMGhmQkRrM1ZkeW02Z21YYXQwL0Y1SDJ3NGJLQ0tLMUNzRzdW?= =?utf-8?B?ZkJrTnhldXZhbCtvOGVtQ21XZkg5R2RJQlV6dTZXUEJGeHBnOEVQL25YWEk1?= =?utf-8?B?S21KSjZENkRzZk1tWTJOZ0hpN1cwUXp3V0tPS0l1UkpGRnJkRWxjVEgxUXRL?= =?utf-8?B?eEZRdzRhSkpHa0VEdkNTUUVpbkdkZ1RmbFZtZGptNWd0ZmNyVjdrdWd5WFdY?= =?utf-8?B?eXZ3cFRhQUxiL0JCL3EzRm4xbVk5UitPUkRGby9HaDJ1SEttdE1hRXdIQkM5?= =?utf-8?B?LzJGU3c3RTlYam9QRDNRREJkQkpOL2ZkZXc1MWJlNS9tbjlkTXF1SjlZbmJF?= =?utf-8?B?d1lVdnlaVE5JOFVrVCtWQlkyRGxsanY5Zm9yWHFTcER6eXRDazdnQ3pOWGZE?= =?utf-8?B?Wkl3UFpzMUNJWWU2Z3hLb2lHbUp6STFQMTVmd0doMlE2UndYNExrc1JKVmhQ?= =?utf-8?B?OWQwd21tWDFKT0M2NCtrMmsvc0piY3NDUnRQSXpzSHdPcGRGMzRlQWIwbkpy?= =?utf-8?B?a1l4OE5NNmRTWUg1WTM2d0hYci9xYzhxN0ZaTm1HY09EeEZkZEUvS2t1VTFY?= =?utf-8?B?bTlCdGFYZ2d4Z0NydytxSGZQSUR3aTFmWHg0dWNRUVNKaE1kc0o2aVM0SVRQ?= =?utf-8?B?R3dJaWcrVnBDVU94VmdBVElheWdhYW91UDJqNjhuM2FmdzA4RFdJNFZnWXE0?= =?utf-8?B?WUJ2UktwUVdhVGJobWU5akdTZVIvR2x6d25US00wNjE2aXQyemxFckhNV2hM?= =?utf-8?B?N25UUjNPSkNMc3c3YmhRY3Q0dm55T01lUTFWcDc0cG9lM1NTemxnMEpNOWJw?= =?utf-8?Q?PIOIr5/FCWxwckik=3D?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: BN9PR11MB5515.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f2b17db2-5843-4788-64f8-08da2b2e4933 X-MS-Exchange-CrossTenant-originalarrivaltime: 01 May 2022 04:51:42.2473 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kOkIfxlaiGtniZBWCpMZmGq79Z7gAox5iHGzFsGWsfl383I9rBeCNZV17xsXsTQEJDrryuKcFGSwk881dX+qKQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5524 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related code when MFX_VERSION < 2.0 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 2022-05-01 at 03:10 +0000, Soft Works wrote: > > -----Original Message----- > > From: ffmpeg-devel On Behalf Of > > Xiang, Haihao > > Sent: Sunday, May 1, 2022 4:16 AM > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio related > > code when MFX_VERSION < 2.0 > > > > On Sat, 2022-04-30 at 16:51 +0000, Soft Works wrote: > > > > -----Original Message----- > > > > From: ffmpeg-devel On Behalf Of > > > > Xiang, Haihao > > > > Sent: Wednesday, April 6, 2022 5:38 AM > > > > To: anton@khirnov.net; ffmpeg-devel@ffmpeg.org > > > > Subject: Re: [FFmpeg-devel] [PATCH v7 05/10] qsv: build audio > > > > related > > > > code when MFX_VERSION < 2.0 > > > > > > > > On Tue, 2022-04-05 at 13:50 +0200, Anton Khirnov wrote: > > > > > Quoting Xiang, Haihao (2022-03-11 09:16:25) > > > > > > From: Haihao Xiang > > > > > > > > > > > > Audio isn't supported for MFX_VERSION >= 2.0[1][2]. This is in > > > > > > preparation for oneVPL support > > > > > > > > > > > > [1]: > > > > > > > > > > > > > > > > > > https://spec.oneapi.io/versions/latest/elements/oneVPL/source/VPL_inte > > > > l_media_sdk.html#msdk-full-name-feature-removals > > > > > > [2]: https://github.com/oneapi-src/oneVPL > > > > > > --- > > > > > > libavcodec/qsv.c | 5 +++++ > > > > > > libavfilter/qsvvpp.c | 6 ++++++ > > > > > > libavfilter/qsvvpp.h | 2 ++ > > > > > > 3 files changed, 13 insertions(+) > > > > > > > > > > Why not just remove this completely? > > > > > None of our QSV code does anything with audio. > > > > > > > > It was removed in an older version, however someone objected the > > > > removal of > > > > this. See > > > > > > > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.44330 > > > > 4-2-haihao.xiang@intel.com/ > > > > > > I think this was a misunderstanding. I see not objection. One was > > > just asking "why" and the other one had missed the point that audio > > > has never been functional. > > > > Please find the comment below in the original thread > > > > "This seems like a generic translation from the library errors to FF > > error > > codes. So even if we'll never touch the audio functionality of it, I'd > > prefer > > to have that struct complete already" > > > > So my understanding was that the reviewer preferred to keep the audio > > stuff > > unchanged for libmfx. > > Hm, I hadn't see that here: > > https://patchwork.ffmpeg.org/project/ffmpeg/patch/20200819061023.443304-2-haihao.xiang@intel.com/ > > Considering the text again: > > > "This seems like a generic translation from the library errors to FF > > error > > codes. So even if we'll never touch the audio functionality of it, I'd > > prefer > > to have that struct complete already" > > I understand the idea. Normally those lines wouldn't hurt. But now, that > we're facing some kind of "#ifdef hell" anyway, I think it would be much > better to minimize this as much as possible, and there's really no point > in translating audio error codes. > Also, the struct has never been really complete. Instead of retaining > unused audio error codes, we should better add those that are missing > (like -21, -22 and others) and relevant. > > @Thilo - can we get you warm with that? > > As an alternative, we could simply replace the two audio definitions with > plain integer values (MFX_ERR_INVALID_AUDIO_PARAM >> -19) > > > This is a small bit only, but before adding the oneVPL stuff, I think > we should consolidate the conditional stuff as much as possible. > > As discussed before, we also need to settle for a minimum libmfx SDK > version (compile-time, not runtime!). This will allow to drop quite > an amount of conditional code, and this cleanup should be done before > getting to oneVPL. Sure, I'll submit a patch for it. > > Another thing that is a bit unfortunate is that we are duplicating this > error mapping struct in qsv.c and qsvvpp.c. > I don't mean that it should be linked as an external between avfilter > and avcodec, but it should come (be included) from a single file. We moved the static error table to a .h in the past however it resulted in link error when building FFmpeg with static libraries. Thanks Haihao _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".