From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 65434401E4
	for <ffmpegdev@gitmailbox.com>; Thu, 20 Jan 2022 08:38:22 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B69668B2C2;
	Thu, 20 Jan 2022 10:38:19 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D4080687992
 for <ffmpeg-devel@ffmpeg.org>; Thu, 20 Jan 2022 10:38:12 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 20K8cBVZ001373-20K8cBVa001373
 for <ffmpeg-devel@ffmpeg.org>; Thu, 20 Jan 2022 10:38:11 +0200
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id 17974A1447
 for <ffmpeg-devel@ffmpeg.org>; Thu, 20 Jan 2022 10:38:10 +0200 (EET)
Date: Thu, 20 Jan 2022 10:38:09 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20220120081019.32711-1-jdek@itanimul.li>
Message-ID: <9890ed6-9e61-7078-cfc0-b8c79885f2@martin.st>
References: <20220120081019.32711-1-jdek@itanimul.li>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavc/aarch64: add hevc qpel assembly
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/9890ed6-9e61-7078-cfc0-b8c79885f2@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Thu, 20 Jan 2022, J. Dekker wrote:

> Based on patch by: Rafal Dabrowa <fatwildcat@gmail.com>
> ---
> libavcodec/aarch64/Makefile               |    1 +
> libavcodec/aarch64/hevcdsp_init_aarch64.c |   69 +
> libavcodec/aarch64/hevcdsp_qpel_neon.S    | 2799 +++++++++++++++++++++
> 3 files changed, 2869 insertions(+)
>
> Some changes since last time it was submitted, namely: split, macro'd
> and some scheduling and other improvements.

This fails to compile with every single toolchain I tested it with. It 
fails to compile on Apple Clang 12, LLVM.org Clang (nightly), GCC 7, GCC 
9, MSVC.

It fails with various incarnations of this issue:

src/libavcodec/aarch64/hevcdsp_init_aarch64.c:140:9: error: use of 
undeclared identifier 'ff_hevc_put_hevc_pel_pixels4_8_neon'
         NEON8_FNASSIGN(c->put_hevc_qpel, 0, 0, pel_pixels);

Not spending time on reviewing it in this form.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".