From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7F1E045872 for ; Fri, 26 May 2023 06:22:57 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 37AE068C1E3; Fri, 26 May 2023 09:22:54 +0300 (EEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E21A568B9FF for ; Fri, 26 May 2023 09:22:46 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685082172; x=1716618172; h=from:to:subject:date:message-id:references:in-reply-to: content-id:content-transfer-encoding:mime-version; bh=3jInz7D6NTFAVZdn6RVhzQ21Ofvl+32x1xFE+oS9PKs=; b=BxL2jKbkyQ3hQahqodJ0JT7J4DSyjdqnGYkTwKF1maUxKi7ONBT6YSNm 8pW7Nh9lAcjYxJOn9qtUxbXUBV3NEPOr/I9HTBpcvXE0iAA/SunGlhW2D Mc3K5JVeuMMpZtb4K7Py0eHpmcRU8zdYnb57CJ8h9ORpAuhqgeT+CchIl i1gkbG/fgb/gH3g8iU7pWvjIR72uP8Q3BM9a9KNDkgp6YaW2JG+NZCvrP y54jIJefUNhmB722YivZl4DWeOyL8q9KtVK/ChyB+G/i9RDhDrlYXckzW v37nAvv19hkhSweEFJse8aKN94y9Zz8QTHUWGX2pPIJYs/ulegMQX20Nb g==; X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="354146979" X-IronPort-AV: E=Sophos;i="6.00,193,1681196400"; d="scan'208";a="354146979" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 May 2023 23:22:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10721"; a="817424937" X-IronPort-AV: E=Sophos;i="6.00,193,1681196400"; d="scan'208";a="817424937" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga002.fm.intel.com with ESMTP; 25 May 2023 23:22:41 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 23:22:32 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 25 May 2023 23:22:30 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 25 May 2023 23:22:30 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 25 May 2023 23:22:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mqElNJBtvEpf5U3dpOh8W/Dn2BiTUO785Cb9U3pwbims0VlZ5w8cYNqe195s8+9Io5XTL0+Y4EebJiNQrPXbE5a5mZqbTX8o6R9Le7UaZ50FUB9qCyWB/j20B0XtA7Q1i9uXzXZ8CIKuEcPZEFVARIdQK9nMGje9lDamvmqcLSkPV97/8BqWGyBVqwEjSVKsSSo1QecraFrc2zqL1doLdE2f7ogyszidC7sIxwB8ID8FwhVkjvXDlrW8m+t1s8oISCAxZxf9EB6UAOa0pBJg+KZjjkAm3ZceuEgYt0dlvXUByUVISGOvi5FNZcbC7AzEnFW7Ws5qGLVeqM8wG+phiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3jInz7D6NTFAVZdn6RVhzQ21Ofvl+32x1xFE+oS9PKs=; b=YQy1pITsTyRzQ2QrygFklA0NPx8VPwir9tLUBlBbt9j6LuJALZU8om8reYBofklbT0+692aeXn/krG+CqBfjhu8K3dkWbPVqphTcXmX9gsqH4W/T3skGP846vLlRAvI5TuMYGxVpwRYqws4B01yTXVK7zjwEYiWTRg8ECvyPU0nQzriqbXgQrGxbPxNNEjaCIFCMJzg9j8b4/Gg3Oe+XB0fyy1n04Aqg9rxmaxrB8g/SE8flG8A4gpAJnlIVTnkpvcGhXDyXJg11thir45J4TSpy2p1nv1KDQJqFcXuUzVzsCX4dttsiN/rp6spxcBX55+JcG39gp47+okLcyZFm3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from PH0PR11MB5030.namprd11.prod.outlook.com (2603:10b6:510:41::5) by PH0PR11MB4792.namprd11.prod.outlook.com (2603:10b6:510:32::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.18; Fri, 26 May 2023 06:22:22 +0000 Received: from PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::77f9:34e2:7829:a043]) by PH0PR11MB5030.namprd11.prod.outlook.com ([fe80::77f9:34e2:7829:a043%5]) with mapi id 15.20.6433.018; Fri, 26 May 2023 06:22:22 +0000 From: "Wang, Fei W" To: "ffmpeg-devel@ffmpeg.org" Thread-Topic: [FFmpeg-devel] [PATCH 22/36] fftools/ffmpeg: drop an obsolete hack Thread-Index: AQHZiKnkUO0b3YT4o0aqBBPJD726Wa9sI48A Date: Fri, 26 May 2023 06:22:22 +0000 Message-ID: <982545f6a0dd3da61a06cebd80b719e70f502ffe.camel@intel.com> References: <20230517102029.541-1-anton@khirnov.net> <20230517102029.541-22-anton@khirnov.net> In-Reply-To: <20230517102029.541-22-anton@khirnov.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Evolution 3.36.5-0ubuntu1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: PH0PR11MB5030:EE_|PH0PR11MB4792:EE_ x-ms-office365-filtering-correlation-id: 73451096-6a42-4531-f980-08db5db190f1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: CLFuKC+gK9peiVw+faTUKqjYIYTzA0Qz2k/qpxfiS0GKz4oyOWNB3SAGB41xe5FvLowtvwauvQyrG10n1azrgtNJuQjFGe8qvyLJ8hoEm9zwWYMhVwM+DE2lS0nfFkYHxEDQM4dqOe5Wx9w4xmbWGZLevV3oPSjulldeJo19UdaTQeUsqWJ8PXik8jNhWZW5oKtSk9qL3dDaKl7PK2+Qv5cYSsuo5NhcfFmLJ1pT1DmbzvsrYbDhYRHWjw2UQlEd8kJHXU2lNYhJJojSTYIEhjd32+Jp1T7sQVvGB7F36AcT3lrf905E1u41VILoACDV+gnILAbHF5vf/lv4pmWKRuLum1VZ0QXe2At2EQKspPx7wZl0MxBfo1Qyk/WdSZlBzxCPrtZSkoO9ANCs817nWokH40rKDkzN9i+emSR+TtxDuzAhg18mw2Xyns7FIYnBYUupZa2VQ6npSOU8s80UDPd/b6L/JbkGgyvGy5ODUFSrfh4ZhnQU3p1UOD7Ar271xyZ2qixSeRqnCm/hSLWhFJQ3gfs67bd2D34ESxrPhx2rNtTDl+vbQSwC2BSuZjgSmf7wGd6qdcMhM6Nkr2dmfxSR+PI0/OtDIhTP4DSuQmL09LmKI1aTJsXSbASp73Kd x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5030.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(39860400002)(376002)(136003)(396003)(346002)(366004)(451199021)(91956017)(66446008)(76116006)(66946007)(66476007)(64756008)(66556008)(82960400001)(122000001)(6916009)(66899021)(71200400001)(478600001)(316002)(41300700001)(6486002)(186003)(2906002)(86362001)(26005)(6512007)(6506007)(8676002)(83380400001)(2616005)(38070700005)(36756003)(8936002)(38100700002)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?cG5wdDJPWlBYQUliUm9rL1pidmQvR3JMM3h4elZCTGhSTFlJbXMrTlp6eUF4?= =?utf-8?B?RXBVS3BYSnJQVTQ4RkZ6b1ZIaWtIVmxJWjNlS015MzJjRVB4ZnI1Ny9lQzVX?= =?utf-8?B?V1gyUGV1WEwrZlN3eVU0cDZyMlF2a096T2srUmpReDFubHFHY3ZHWldDeW4y?= =?utf-8?B?dzBReGpCS0ZPQVVvTFRvWTJQdmNyWno1cjhib2RKRFdxUXFpOVQwRU1TU1lQ?= =?utf-8?B?QkUwckM3VFZVYldxU0FVYVFKRzV2emlZNVJNaEloQ1k1RW1LVFM2TUROOVVx?= =?utf-8?B?a2QzNjYzMDk5cUxCTDRTc2ltU0JtVkpBeDdZeGxPdVBDL2lueURiaCtLN2tL?= =?utf-8?B?R2tuQTdRWlVaWnJLeVl4V0ZvMmd2MnRucDByMWpvWUJaR29Vc08rUHBFQy9Q?= =?utf-8?B?ZTVYZlV2Wk85bFVCeTNzZDBkeW5qajVwWVZOeXBvUGQ3TzdWMjdTWlMrUmhq?= =?utf-8?B?YUVxVTlwbXJtNzFYeXAzdkttL3lpZG8xaElEcm5hZWUreko0UXpyUnQ0RldT?= =?utf-8?B?NVJyWVB0ZUV5d0g3enNUalQrTklsNEw3YnlFay9DalorZXJ0YWxJeGl3NHFR?= =?utf-8?B?NDd4Z2k0R0lyc3U1TDAvZ3MxVVNKTUtvOFVJVlJKQ3NqTWl5bUV6cUdWdVBX?= =?utf-8?B?Q0RTMUpRdGd5dHZoQTZaVGFyR0RET3ROSXFUN0l4VzRGVDBHWnRObWgweTVo?= =?utf-8?B?YndaL3FJRENRU1pVaUI3YTJ6RGpHa25FVFNIV0d1eGJwQi9Sb2FaRENrK3FT?= =?utf-8?B?T0hMVUQ3Tm5SVTVHS1FrRE45M3hUdjhRendlQWhUVWxwWStqVjhLR0lNTnE4?= =?utf-8?B?L3crOFNyRHhNKzJpb2E3cFhhQ0JIQ1laUUlXbE4yYnMvSHNKeXVUTW9ydkFx?= =?utf-8?B?cllubTVzQzFPQ1hFVmthZVdlZEZNZ2RmZHFGSXppL0VEZk1pUmxjTitRU3Yw?= =?utf-8?B?Tjl0TkxZT2N1NjNFbGNTNWp6Ukk5K0hGYU41WEhUbDZLZ1RVUnc2c3l1Ym9h?= =?utf-8?B?MGhXN3YrTEcvRGdKY1FzUXAvbmRNdVgxS1VyN3NxNXFBd3VHMWJMVEk3QmZ6?= =?utf-8?B?MUtRR3liWERLTnEvQTJiMjFGRkh1NmgrRlYrVWozVWFOcVhJWEN4NGVVNGZj?= =?utf-8?B?dUYyOC9icmdvbGhSdWRaTU9KaW5rY1hNUGl0c2p3VGpEdUxKQmdYbVVPNXpU?= =?utf-8?B?MWtoa0wwL21Vem5jVWprOENLcU9BWFRGcWk5MG8xU0xGUUhsc0g1NGhMMGhy?= =?utf-8?B?WnkxUVZ6L0xheWVNeDZWZEJnNlkzek1JVldQNkd6QkU5bmg3eXkrZjRnK1Vq?= =?utf-8?B?Yy9OcktvM29ZM2h1Tm1aWEpISTlzUXpsVVB1SHZ5Q1pHMVFiVS9VQmRDTW5h?= =?utf-8?B?VE5UYlRSSW9haEhLaUNrMU1sY0M2NmpGOHNHZUpWZHVqS1JuRkhOMHhFLzN4?= =?utf-8?B?TlZlWEVleUYxRDM3NVNndlRML3JxNjVLc2Q2Z1R6OGVBQ0N0UDdWOHo0QytB?= =?utf-8?B?TENnMU11V0pSSVRVTS8rNWp4dm84T0Q4U2FDS1JYT3YrVjE0QjRDRWwwM21B?= =?utf-8?B?MnZ0QkVrd0tuMG9MU1EweUk0ZlNqU1ZiWGx6ZDg2UFpvK2pFd1RJbHVPUGlz?= =?utf-8?B?MnRGNWV2N04zb2d5NXFtaHh1ZkFOTnVMWXR2OGwvMmlJZklHZ1l0dnV2R0JY?= =?utf-8?B?Z0M3WXFrSHpTa2FXejF4SjJLYzI5SUQzRWV3UFdwYnZIWFNGOWZNL2cxaU4x?= =?utf-8?B?VFdudStsb0didjhRU2huTGM4eGRtNWxGVndvZUgzYmh1L0hwbTUyZ0thTm9l?= =?utf-8?B?VGRSK3NNZENJekM1bFd1NC90R1loM01xdjNjNWNrTjM4UEl6NXZ5RXp3VUJt?= =?utf-8?B?VGdmSUxucjJoNDgrVC84V3pnTVcra01VYlRjZjFGb1A1cHRQaFNlR2xEZi9O?= =?utf-8?B?TnZxWC9DTG1QcHppeXRFTGM4bmlrUWF2YnNOay82ZDlXYVRYUG9HRHpLY2Nt?= =?utf-8?B?Nll2eitEUm1EdW44cU1ud05nS0hYMDJtMHVFQzZndmdDdXFUSHRIVVorTVVI?= =?utf-8?B?WENNTFl6Q2VKeUFCaHdvWjFyRjZzOE9SVVFBdXRUaFhsSjZlNng2YThmV1FM?= =?utf-8?Q?86foOKTR/Cv6mHQhgI67ZI+M/?= Content-ID: MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5030.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 73451096-6a42-4531-f980-08db5db190f1 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 May 2023 06:22:22.4945 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: z1mxQKnuaZT5T7/VsIEmZQ/D58PelHvSYDCHZ4x/7NDU5cF55UdfXHT5pXY72vdR05DG4ehYXMbj6jV2no3h4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4792 X-OriginatorOrg: intel.com Subject: Re: [FFmpeg-devel] [PATCH 22/36] fftools/ffmpeg: drop an obsolete hack X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 2023-05-17 at 12:20 +0200, Anton Khirnov wrote: > This special handling for decoder flushing has not been needed since > af1761f7b5, as the filtergraph actually is drained after that commit. > --- > fftools/ffmpeg.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c > index 9d554e2fb0..49313edebc 100644 > --- a/fftools/ffmpeg.c > +++ b/fftools/ffmpeg.c > @@ -1418,17 +1418,6 @@ static int process_input_packet(InputStream > *ist, const AVPacket *pkt, int no_eo > if (!got_output) > break; > > - // During draining, we might get multiple output frames in > this loop. > - // ffmpeg.c does not drain the filter chain on configuration > changes, > - // which means if we send multiple frames at once to the > filters, and > - // one of those frames changes configuration, the buffered > frames will > - // be lost. This can upset certain FATE tests. > - // Decode only 1 frame per call on EOF to appease these FATE > tests. > - // The ideal solution would be to rewrite decoding to use > the new > - // decoding API in a better way. > - if (!pkt) > - break; > - Hi, This will drain out HW filter's output frames if it uses fixed number which is less than frame threads of decoder. Decoded frame keep sending to filter in flushing while filtered frames can't be reaped. An example cmd: ffmpeg -threads 20 -v verbose -init_hw_device vaapi=hw:/dev/dri/renderD128 -hwaccel_output_format vaapi -hwaccel vaapi -i avc.mp4 -vf 'scale_va api=w=720:h=480' -f null - ... Error while filtering: Cannot allocate memory Failed to inject frame into filter network: Cannot allocate memory Error while processing the decoded data for stream #0:0 Thanks > repeating = 1; > } > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".