From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
by master.gitmailbox.com (Postfix) with ESMTPS id 8EC9B4BB33
for <ffmpegdev@gitmailbox.com>; Wed, 2 Apr 2025 07:43:14 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id BD52F687C7D;
Wed, 2 Apr 2025 10:43:10 +0300 (EEST)
Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com
[209.85.167.41])
by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 958B0687B61
for <ffmpeg-devel@ffmpeg.org>; Wed, 2 Apr 2025 10:43:03 +0300 (EEST)
Received: by mail-lf1-f41.google.com with SMTP id
2adb3069b0e04-5498d2a8b89so7412939e87.1
for <ffmpeg-devel@ffmpeg.org>; Wed, 02 Apr 2025 00:43:03 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=martin-st.20230601.gappssmtp.com; s=20230601; t=1743579783; x=1744184583;
darn=ffmpeg.org;
h=mime-version:references:message-id:in-reply-to:subject:to:from:date
:from:to:cc:subject:date:message-id:reply-to;
bh=9NCWZ9p7m1GDSLEiMF1QS80k7KYqrBY85vkD6VwTjnk=;
b=WCiAy7UhO7fVddl8p32RK3wrGwaGJt1mtRcwqc1t79r96c1xYsXReNRUkLEQJCCQE4
wo3pCtV7+226N8mZLATyaRE6Olw0EhC4yUJ+lZ3Eo9ZvDM5WJ/+I/EfcXoVullaea7am
fyTbVlE4blpexBvbOrfCftVqaJufKQNnGOFrnQDRHDK7HFOAsyT3VhMHlg0x06S6TGKa
RmtTamsZwdcfow7MkdMjtR6tLrpsFcwTdT62iScmuDQzqFq2RBPHXWBCuqCwvwoIgmtF
ed9OYax5Lf5JUL0ucbTPjeA8WZiNE88eVA8Oze/wAv+LQDg0A1PukbwLtPH+TPC5G5Bc
vfOQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1743579783; x=1744184583;
h=mime-version:references:message-id:in-reply-to:subject:to:from:date
:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=9NCWZ9p7m1GDSLEiMF1QS80k7KYqrBY85vkD6VwTjnk=;
b=kG6qcqkI0GhtJzed1aVlXGiniy48n2SxSWTgH4/L6wAj8DLnnjqBAnMsJ+NaBgyF/y
cbkEVJrD3t2oTAFL5bXIGDUbrQS7bA4ikrWYFDusTNtVn9fB2RnJ2S8oEanSFnc2Jv0n
5HmO7cuqP8Xbp1/8hRnCzN8qnSJROJXDHX/BGi0dOVtCTOvUwM01t/L7tKrJ7gypkOtu
i3PMYWLwOGYExDHRypTzc9sMeHm/2FKO6CapWq0ASpy7rHaXn8duITdRTWhN4Fef8oNY
lEypw6mhtsrtkmCbkkWOCBLh0myyOzvR95Stm7V+SdGLH6wflqDCFBZTujtyfNSPbPIm
Dvcw==
X-Gm-Message-State: AOJu0YwW537ky1951Ad5CHsGbO302VOCu+3lXkkp6bFbW/NMLLk5vlW0
96oYfw2SaIP50cdvOFaviT4CV6yzMwRKeYqPcs+ZvYzffKp7nR9WfAr/B7aTcFle4DTNUPr5tN9
AlQ==
X-Gm-Gg: ASbGncuxgSOwAWNGgtJ40wJYsN4VqnnkVj0FMTihvC6TB/H1u3Fl6+WSgzHU6lVPxUp
FDDNsfFOK4wgYOqwO15LYkHSfyCi6QZTZw0ktwL+Y4xiGbVvEuIfVb7PAcOTV+PKshtBQnlyYXr
SPVXJfJDYReS6qYAV7r2Zx4idG/bzvRY9o3R+Ew+lBYcvMsTRWteTBzmSNuPEXvHg3wA72h7pmn
lvmZiy3lDmzWDUA+bRD+EOdIsDIZanHKoVfTYDxq/P1C5C77uxp+kxChdQAJB4FEgWbW35f8n04
R3pSss0Q3rZjvE6fCky5Z8H1SxT1d3mi2L0sHtkgltYHH1z9oBZpEIVxZ/ldWvq56Ngv9Bs6Vo6
l3d+gP6UXEhasVJRnhNFlTi/5JSx22i4f+e/zmbii
X-Google-Smtp-Source: AGHT+IG0St5S1anRP/px1QxNtjfbVRpIkXubb1Tkzd3DDgsZTBThMSNiLuro0K1YciGDF8sAFPsuBg==
X-Received: by 2002:a05:6512:3501:b0:549:8537:79d6 with SMTP id
2adb3069b0e04-54b11129212mr4781311e87.48.1743579782496;
Wed, 02 Apr 2025 00:43:02 -0700 (PDT)
Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net
(tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2])
by smtp.gmail.com with ESMTPSA id
2adb3069b0e04-54b09591a01sm1534341e87.164.2025.04.02.00.43.01
for <ffmpeg-devel@ffmpeg.org>
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 02 Apr 2025 00:43:01 -0700 (PDT)
Date: Wed, 2 Apr 2025 10:42:59 +0300 (EEST)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <20250402000358.483296-1-michael@niedermayer.cc>
Message-ID: <97e8989-b5d4-df35-d1d2-703d2fd2b12a@martin.st>
References: <20250402000358.483296-1-michael@niedermayer.cc>
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm/checkasm.c: Assert that
aligned_w/h do not overflow
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
<mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/97e8989-b5d4-df35-d1d2-703d2fd2b12a@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>
On Wed, 2 Apr 2025, Michael Niedermayer wrote:
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> tests/checkasm/checkasm.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
> index a5b862fe52e..1cfc4feb488 100644
> --- a/tests/checkasm/checkasm.c
> +++ b/tests/checkasm/checkasm.c
> @@ -58,6 +58,7 @@
> #include <stdlib.h>
> #include <string.h>
> #include "checkasm.h"
> +#include "libavutil/avassert.h"
> #include "libavutil/common.h"
> #include "libavutil/cpu.h"
> #include "libavutil/intfloat.h"
> @@ -1189,10 +1190,12 @@ int checkasm_check_##type(const char *file, int line, \
> int align_w, int align_h, \
> int padding) \
> { \
> - int aligned_w = (w + align_w - 1) & ~(align_w - 1); \
> - int aligned_h = (h + align_h - 1) & ~(align_h - 1); \
> + int64_t aligned_w = (w - 1LL + align_w) & ~(align_w - 1); \
> + int64_t aligned_h = (h - 1LL + align_h) & ~(align_h - 1); \
> int err = 0; \
> int y = 0; \
> + av_assert0(aligned_w == (int32_t)aligned_w);\
> + av_assert0(aligned_h == (int32_t)aligned_h);\
Ok with me.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".