From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id DD5E94B807 for ; Fri, 14 Jun 2024 13:03:34 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3C8A268D68B; Fri, 14 Jun 2024 16:03:31 +0300 (EEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7DE1D68D5B2 for ; Fri, 14 Jun 2024 16:03:25 +0300 (EEST) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-52bc27cfb14so2839610e87.0 for ; Fri, 14 Jun 2024 06:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718370204; x=1718975004; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=oPCm3kZmDmC4c2Dw5KIBeETJwBCS3vQvjSNBuwFWKAo=; b=eeXp6lrD6+D9dx/nuwVKkRglrWOeu+qf6CBoBbQFcsFL5PGPoZc5790f/ShUnlru9Z sGMZIu8bADOPIsiVkIrTgtDMCukwWkP6G2VxKbI5p021TYaUrcUg6e/LroFh5OMbFe0n 6q0nK7YxEhPj78AzI6wekAeRRAM9Dk+IqDGu/6SCPKKMBppjfSswyuetu4/sAhu7tS2Q O2WCCYQ0itDTcveXH8kK7xkzhR6Xbp4MhoalRWHJG4Yjtd9G+NbcAe+lv4jZ6ayzyaia KbmIyFShO8Ntr8VdGtR0k+jldLIPO+B6BqGnq4v/AgnOdIXHEZ8uN8vDGYroKRuVKZdn Fr8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718370204; x=1718975004; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oPCm3kZmDmC4c2Dw5KIBeETJwBCS3vQvjSNBuwFWKAo=; b=wdDV0DMWoFTfOlENvul3Cdaf3QrzYrx9QJXrWGN/HzxxhGC4XkW9e8Fa1jkkgAofp1 YZHx8TYXVG6MKXbbtMeYWo/uMx7pL6OqYU1fbsgEQ4674IOt3NL8zRHeSUvEMRHtZLwC KeAMrY1jtrf36MmsypN86duSP4806qiBweuxRRHPCD5uLFwjPlOnAbDxjAAYtYfqZCvE tpd8sFsBRrWQ0fgoimXUTCEiU4hrL24XkYMDD5bkNRupPVTz+r3lYp4yb2328xbFuDKJ v39YFc5UUwJD9AUTTpqMiDCOWRbYG1kkSDOAaLeazOYQomKqOliegPkY20BQFECJqKT5 cypA== X-Gm-Message-State: AOJu0YwjKCQfvfXKATz8qKK7LKLwV6TXO6WuL7nVSZWTFt5xZcgoHuSX kHGJj2NVzSj84y9/lFzhBTE4rOlSWSxh46LJTFOdZc9LeBHFsLM/r8H9Lg== X-Google-Smtp-Source: AGHT+IF4hZypGjqTI9zaxAzxWcyBWDSq062Zhr3esA20NmDiXUuydQyzZGtnXH8DoqQLiGQi6CCiBA== X-Received: by 2002:ac2:4d07:0:b0:52b:c33a:aa7c with SMTP id 2adb3069b0e04-52ca6e9dc95mr2009567e87.65.1718370203629; Fri, 14 Jun 2024 06:03:23 -0700 (PDT) Received: from [192.168.1.106] (0540dce9.skybroadband.com. [5.64.220.233]) by smtp.googlemail.com with ESMTPSA id a640c23a62f3a-a6f56fa4030sm182574166b.207.2024.06.14.06.03.22 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 14 Jun 2024 06:03:22 -0700 (PDT) Message-ID: <97aa1721-9908-480d-9b3d-c64368b24663@gmail.com> Date: Fri, 14 Jun 2024 14:03:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-GB To: ffmpeg-devel@ffmpeg.org References: <20240610184408.68171-1-derek.buitenhuis@gmail.com> <20240610184408.68171-2-derek.buitenhuis@gmail.com> From: Derek Buitenhuis In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/11/2024 7:44 PM, James Almer wrote: > This should ideally be the enum with value 0, but until next major when > such a change can happen, it would be IMO a good idea if you set > spherical->projection to AV_SPHERICAL_RECTANGULAR in av_spherical_alloc(). I think setting it to 0 (AV_STEREO3D_2D) is correct rather than this (and is already done), and I don't think we need to reorder. I had discussed this with Vittorio and it was decided that it was good to disambiguate between 2D (not stereoscopic) and coded rectangular. - Derek _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".