Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Derek Buitenhuis <derek.buitenhuis@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types
Date: Fri, 14 Jun 2024 14:03:21 +0100
Message-ID: <97aa1721-9908-480d-9b3d-c64368b24663@gmail.com> (raw)
In-Reply-To: <be47130c-e445-41c5-bd55-7288a81fbc87@gmail.com>

On 6/11/2024 7:44 PM, James Almer wrote:
> This should ideally be the enum with value 0, but until next major when 
> such a change can happen, it would be IMO a good idea if you set 
> spherical->projection to AV_SPHERICAL_RECTANGULAR in av_spherical_alloc().

I think setting it to 0 (AV_STEREO3D_2D) is correct rather than this (and is already
done), and I don't think we need to reorder.

I had discussed this with Vittorio and it was decided that it was good to disambiguate
between 2D (not stereoscopic) and coded rectangular.

- Derek

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2024-06-14 13:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-10 18:44 [FFmpeg-devel] [PATCH 0/5] Apple Spatial Metadata Derek Buitenhuis
2024-06-10 18:44 ` [FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types Derek Buitenhuis
2024-06-11 18:44   ` James Almer
2024-06-14 13:03     ` Derek Buitenhuis [this message]
2024-06-17 13:11       ` Derek Buitenhuis
2024-06-10 18:44 ` [FFmpeg-devel] [PATCH 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files Derek Buitenhuis
2024-06-10 18:44 ` [FFmpeg-devel] [PATCH 3/5] fftools/ffprobe: Print more Stereo 3D info from side data Derek Buitenhuis
2024-06-11 18:09   ` Michael Niedermayer
2024-06-11 18:43     ` Derek Buitenhuis
2024-06-14 13:04       ` Derek Buitenhuis
2024-06-10 18:44 ` [FFmpeg-devel] [PATCH 4/5] avformat/mov: Add support for exporting Video Extension Usage info Derek Buitenhuis
2024-06-10 19:38   ` James Almer
2024-06-10 19:45     ` Derek Buitenhuis
2024-06-10 18:44 ` [FFmpeg-devel] [PATCH 5/5] avformat/mov: Add support for reading and exporting horizontal field of view Derek Buitenhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97aa1721-9908-480d-9b3d-c64368b24663@gmail.com \
    --to=derek.buitenhuis@gmail.com \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git