From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2EC8343B1C for ; Wed, 13 Jul 2022 12:39:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C3F1168B94D; Wed, 13 Jul 2022 15:39:30 +0300 (EEST) Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3B4EA68B786 for ; Wed, 13 Jul 2022 15:39:24 +0300 (EEST) Received: by mail-oi1-f169.google.com with SMTP id w184so7925835oie.3 for ; Wed, 13 Jul 2022 05:39:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=klPGNmrg7R2L15SsHHrInaZ5TmkMFnvNwTVX8AZSP4w=; b=E9PfB34aajc6gxmGy9OGLru5e1pYeNeZdEAZqMbEQbfFlZDI7vt0Rt1wABqHPZmtPY fUINcmYx5BxToyGfXBz5ppHsNwkzWIZsEw6MFd/bzJEZ4Te6N+8YqOq7s3js+u2Luo6c yjzp6y9+6jlZ/jBEPIzY1RYHuThdHam9VU4IcIpjGMds+EN5RESI6NISkxmwtDrYuHUA UO7RifUxSNDjuN+Y9tok0oVOiDehygAZgMM2krKAAEwyyi4YE34Cg4VPCPREx9M8vJ9B il85aHDT8B3I/UaowaI3OBjnAOEa9OFsifFCxIRre8nWFWr8YGBXsH3RwirK4s2kWQs3 eB+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=klPGNmrg7R2L15SsHHrInaZ5TmkMFnvNwTVX8AZSP4w=; b=DRGxbF/pa+xr6Z//39p2X3JyakiXVVkScX3pIjpAn5HW0cq3aMe7LjnXNyXlTtP7HR ZKJaCsru2CG1sJTJTeffeOMmKVeOaCB+m/6R/E1Mgcc8ZapAxKce/4Y711gii2sbnVy9 piNuj4tJ1/mxtOOvjAD/ZhhEMqKaJmB8bpTXyosoZ2LmtWC1A6jI48H19VYTQaGK6Kb8 NIFff4YY082lSr+3Engu6MO6s8jEvPazIp5zK2JJH2wiwjWySYB3ITYVdaF5fjGDbrQE y2IP79SwqyPBxxokYKNkSZlkmXNPrQiAXZ5ePk6RMLgzbEebOaCrboSjofa/DTvOh/z8 y+jQ== X-Gm-Message-State: AJIora/gbJkMykBX2IvvNFNoMtH4FKFsjHWgVWNQGLWnaZTvpmnxNccI mrXMT9T2JruT4EHrgzQLTsY4A2ZSD3ShWw== X-Google-Smtp-Source: AGRyM1umUb0O8a6zpchLwrDgNRsMKhHgyYlNagtwbKL836hDmBNlKMLiaDEXi2U/whsXbKpUfqPtNw== X-Received: by 2002:a05:6808:d50:b0:33a:e22:8aa2 with SMTP id w16-20020a0568080d5000b0033a0e228aa2mr4601757oik.19.1657715961875; Wed, 13 Jul 2022 05:39:21 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id 37-20020a9d02a8000000b0061c24473ec4sm4666123otl.65.2022.07.13.05.39.20 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Jul 2022 05:39:20 -0700 (PDT) Message-ID: <978501a3-acef-cc0f-f655-ca1401594ad6@gmail.com> Date: Wed, 13 Jul 2022 09:39:20 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220713091725.16638-1-anton@khirnov.net> <20220713091725.16638-6-anton@khirnov.net> From: James Almer In-Reply-To: <20220713091725.16638-6-anton@khirnov.net> Subject: Re: [FFmpeg-devel] [PATCH 6/9] ffprobe: use AVFrame.duration instead of AVFrame.pkt_duration X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: You should probably add new entries to the schema file instead. https://git.videolan.org/?p=ffmpeg.git;a=blob;f=doc/ffprobe.xsd;h=3af621a17ae884adfeacb7cd50c60e1553808188;hb=HEAD#l93 Once frame->pkt_duration is gone, ffprobe shouldn't keep printing a frame->duration value as "pkt_duration" and "pkt_duration_time". Also, if frame->duration is supposed to be able to have values other than those we wrote to pkt_duration, maybe keep printing the latter with the existing schema entries until it's all gone (You can use AV_NOWARN_DEPRECATED() to shut compilers up). On 7/13/2022 6:17 AM, Anton Khirnov wrote: > --- > fftools/ffprobe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index f156663019..a041241e1e 100644 > --- a/fftools/ffprobe.c > +++ b/fftools/ffprobe.c > @@ -2570,8 +2570,8 @@ static void show_frame(WriterContext *w, AVFrame *frame, AVStream *stream, > print_time("pkt_dts_time", frame->pkt_dts, &stream->time_base); > print_ts ("best_effort_timestamp", frame->best_effort_timestamp); > print_time("best_effort_timestamp_time", frame->best_effort_timestamp, &stream->time_base); > - print_duration_ts ("pkt_duration", frame->pkt_duration); > - print_duration_time("pkt_duration_time", frame->pkt_duration, &stream->time_base); > + print_duration_ts ("pkt_duration", frame->duration); > + print_duration_time("pkt_duration_time", frame->duration, &stream->time_base); > if (frame->pkt_pos != -1) print_fmt ("pkt_pos", "%"PRId64, frame->pkt_pos); > else print_str_opt("pkt_pos", "N/A"); > if (frame->pkt_size != -1) print_val ("pkt_size", frame->pkt_size, unit_byte_str); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".