From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0E8CD4A8E3 for ; Mon, 24 Jun 2024 00:13:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 89B0068D50D; Mon, 24 Jun 2024 03:13:12 +0300 (EEST) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5A32D68CF1F for ; Mon, 24 Jun 2024 03:13:05 +0300 (EEST) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1f862f7c7edso28031035ad.3 for ; Sun, 23 Jun 2024 17:13:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719187982; x=1719792782; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=8tNSz+id6SJmk9JNs15P31qt0cxHpnx9nIJ7FEYQg6E=; b=dPyI+Ib2LkrVR/qynFPHXyd96W75HS/sApA39sm+KbVHVKiyA6Yd4WmZchwHNc3EGc rEFv25V+5jis3Xrsz4a1GglPL+j4W4zjlDHSYHUaeG0SOkAApGlusctWzUXbzmVcMQ2B 96VA4pdVz20j8z4KPMgmmcEVWcWPb6BEM2Uu8uZxjtWxoBBb51W67BUwJOePDByIbt+S adzNdi9A22/MNH1bnf5Hzq/DfKYh4FeXjVl+P2OGGaqLjucY4l/cDJpIhrQA+KjeLWQS IebRjr22OWNFfCoK2cjotxqEFRVd79C5bm1RHiqA+HQtUDhXcOjTy2KUxnPb0l7xuKGR LjpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719187982; x=1719792782; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8tNSz+id6SJmk9JNs15P31qt0cxHpnx9nIJ7FEYQg6E=; b=YkhL/NQ591jjlbDo2gbt/B3eDd7FMKE6l+RaWxqYj2RZeqAkVIsnDXmohBLd/FY4mQ UF/3/OHRZG7pbxw5CuLsHI0l2aD2A3WKqVaZDA1Z72g3t2kkVnxgf6B1JG7op6Bs6XHH gS4IvHQmh5Jgohg8pV8SaPEBYl0Jlt7Wzm/S1+yICQ9qYxyBUX1Xm18luxqsQCuLNxYB 41wMwiZ7DLq5/2oZyopg5JijrV1v1vrkVl4YwoFB8vXEpgZTqVIuqa+14GxkFrchm46C 7B5VQQjNx2XFo3gBpIDdBDhQRggO/hbF3+N+LYJv57fE8/SIIvPm93p3j9V33SXjiMiK lKKA== X-Gm-Message-State: AOJu0Ywd0ufIyMSY1++0Olp5ggrbNU01x73ySKPFK7JZptUw79ZHbWZq qxe6fMtiVmFFHon7Xs7dO8Ql+I3CanzwM+ZRUroFMA2d1JhrD1954xgpIw== X-Google-Smtp-Source: AGHT+IEuUL/UmFECeNOrRClyK/5AeP8MUhvZ/ziPrGxLPw4+OpEBiv3rsO03iSQZnNhW0uQzJkQRLw== X-Received: by 2002:a17:902:e807:b0:1fa:be7:aa7d with SMTP id d9443c01a7336-1fa1d683e8fmr43556475ad.61.1719187981913; Sun, 23 Jun 2024 17:13:01 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1fa1d3773d1sm23729845ad.270.2024.06.23.17.13.00 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 23 Jun 2024 17:13:01 -0700 (PDT) Message-ID: <975bb496-8a3c-4308-bf94-6ae108d3aefb@gmail.com> Date: Sun, 23 Jun 2024 21:13:14 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20240623141508.908804-1-dev@lynne.ee> Content-Language: en-US From: James Almer In-Reply-To: <20240623141508.908804-1-dev@lynne.ee> Subject: Re: [FFmpeg-devel] [PATCH v2] lavu/stereo3d: change the horizontal FOV field to a rational X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/23/2024 11:14 AM, Lynne via ffmpeg-devel wrote: > This avoids hardcoding any implementation-specific limitiations as > part of the API, and allows for future expandability. > > This also allows API users to more conveniently convert the > values into floats without hardcoding specific conversion constants. > > The API was committed 2 days ago, so changing this field now > is within the realms of acceptable. Five days, soon to be six. [...] > diff --git a/tests/ref/fate/matroska-spherical-mono b/tests/ref/fate/matroska-spherical-mono > index b108596350..8b011e332f 100644 > --- a/tests/ref/fate/matroska-spherical-mono > +++ b/tests/ref/fate/matroska-spherical-mono > @@ -7,7 +7,7 @@ view=packed > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > -horizontal_field_of_view=0 > +horizontal_field_of_view=0/0 Re-run fate. This and many other tests are not correct. If Derek is also ok with this then LGTM. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".