[FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[Michael Niedermayer]

Suggested-by: Anton

Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 doc/developer.texi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/developer.texi b/doc/developer.texi
index 0c2f2cd7d1..67f7f78e86 100644
--- a/doc/developer.texi
+++ b/doc/developer.texi
@@ -806,7 +806,7 @@ improves readability.
 
 @item
 Consider adding a regression test for your code. All new modules
-should be covered by tests. That includes demuxers, muxers, decoders, encoders
+must be covered by tests. That includes demuxers, muxers, decoders, encoders
 filters, bitstream filters, parsers. If its not possible to do that, add
 an explanation why to your patchset, its ok to not test if theres a reason.
 
-- 
2.17.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[Tomas Härdin]

tis 2023-07-04 klockan 01:00 +0200 skrev Michael Niedermayer:
> Suggested-by: Anton
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  doc/developer.texi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/developer.texi b/doc/developer.texi
> index 0c2f2cd7d1..67f7f78e86 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -806,7 +806,7 @@ improves readability.
>  
>  @item
>  Consider adding a regression test for your code. All new modules
> -should be covered by tests. That includes demuxers, muxers,
> decoders, encoders
> +must be covered by tests. That includes demuxers, muxers, decoders,
> encoders

+1

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[Paul B Mahol]

Tyrants and dictators.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[Tomas Härdin]

tis 2023-07-04 klockan 03:38 +0200 skrev Paul B Mahol:
> Tyrants and dictators.

You can't just have rules and stuff, man

(Send all non-test-writers to GNUlag)

/Tomas
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[Nicolas George]

[-- Attachment #1.1: Type: text/plain, Size: 799 bytes --]

Paul B Mahol (12023-07-04):
> Tyrants and dictators.

I would not have said it that way, but you are not wrong.

While in theory it would be nice to have tests for all new code, the
entitlement of the members of this project who contribute little code or
none at all who demand ever more and more from those who do is sincerely
disgusting.

They think they can get away with it because they believe they control
access to the project and the prestige of being published in FFmpeg will
push anybody to jump through hoops. Well, they are wrong on the second
point, nothing new happened in FFmpeg except interfacing with other
code, the prestige is melting like a glacier in the XXIst century. So
let us make sure they are wrong on the first point.

Regards,

-- 
  Nicolas George

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[Pierre-Anthony Lemieux]

+1

On Mon, Jul 3, 2023 at 19:32 Tomas Härdin <git@haerdin.se> wrote:

> tis 2023-07-04 klockan 01:00 +0200 skrev Michael Niedermayer:
> > Suggested-by: Anton
> >
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> >  doc/developer.texi | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/doc/developer.texi b/doc/developer.texi
> > index 0c2f2cd7d1..67f7f78e86 100644
> > --- a/doc/developer.texi
> > +++ b/doc/developer.texi
> > @@ -806,7 +806,7 @@ improves readability.
> >
> >  @item
> >  Consider adding a regression test for your code. All new modules
> > -should be covered by tests. That includes demuxers, muxers,
> > decoders, encoders
> > +must be covered by tests. That includes demuxers, muxers, decoders,
> > encoders
>
> +1
>
> /Tomas
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[Jean-Baptiste Kempf]

Hello,

On Tue, 4 Jul 2023, at 01:00, Michael Niedermayer wrote:
> Suggested-by: Anton
>
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  doc/developer.texi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/developer.texi b/doc/developer.texi
> index 0c2f2cd7d1..67f7f78e86 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -806,7 +806,7 @@ improves readability.
> 
>  @item
>  Consider adding a regression test for your code. All new modules
> -should be covered by tests. That includes demuxers, muxers, decoders, encoders
> +must be covered by tests. That includes demuxers, muxers, decoders, encoders
>  filters, bitstream filters, parsers. If its not possible to do that, add
>  an explanation why to your patchset, its ok to not test if theres a reason.

+1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] doc/developer: Make tests a requirement

[Rémi Denis-Courmont]

Le tiistaina 4. heinäkuuta 2023, 2.00.04 EEST Michael Niedermayer a écrit :
> Suggested-by: Anton
> 
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
>  doc/developer.texi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/developer.texi b/doc/developer.texi
> index 0c2f2cd7d1..67f7f78e86 100644
> --- a/doc/developer.texi
> +++ b/doc/developer.texi
> @@ -806,7 +806,7 @@ improves readability.
> 
>  @item
>  Consider adding a regression test for your code. All new modules
> -should be covered by tests. That includes demuxers, muxers, decoders,
> encoders +must be covered by tests. That includes demuxers, muxers,
> decoders, encoders filters, bitstream filters, parsers. If its not possible
> to do that, add an explanation why to your patchset, its ok to not test if
> theres a reason.

The way that this paragraph is worded is self-contradictory. And while we are 
at it, the first (unmodified) sentence sorely lacks context, as it can only 
realistic apply to bug fixes, not just any code.

Did you mean?

> Consider adding a regression test for your BUG FIXES. All new modules
> must be covered by AUTOMATED tests OR PROVIDE AN EXPLANATION WHY
> DOING SO IS NOT POSSIBLE. That includes demuxers, muxers, decoders,
> encoders, bitstream filters, parsers.

-- 
雷米‧德尼-库尔蒙
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".