From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 0218243BD7 for ; Fri, 22 Jul 2022 15:03:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E0CB568B698; Fri, 22 Jul 2022 18:03:16 +0300 (EEST) Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8702568B364 for ; Fri, 22 Jul 2022 18:03:13 +0300 (EEST) Received: by mail-oi1-f170.google.com with SMTP id w204so5831550oie.7 for ; Fri, 22 Jul 2022 08:03:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=AwuVdGUVchkxNwwAAXy3FCTkPKVm8RbLxrZ5BtsbWmc=; b=IcwMyl9UagwZMsQLIQjwLMUawyHDHK7/W0txUKdfhSyycXuhnbKQcg+3elGHv41m4v RQ79i9c9vxZi1bc1ViayXjTZTiip8aWbS+xBteYgtRXyoFiPfG0gKxkEuRWJJ+/NfPFu lPzxsDSSrHN3vZIkvwJ4jXUNlfGjuhONl7mHHu6VoxXgAXJ5peZzGGfQr7nzpjkspIWZ zZgWAom82apd0bGQwEO5PM0tTYwI3hhRrxkrqX+OxUpKGw3dahLvbBQJElhq348bpFJf 2dXzfv/cRG97fp/PoQmiMM+8SdhQgeDsR63qIisz0Q+RTTgDD4WudbEMch4zZ9B30i3S jOxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=AwuVdGUVchkxNwwAAXy3FCTkPKVm8RbLxrZ5BtsbWmc=; b=qNxC1bFEfcF10N4gk/oFjJ+8MSl4qG+8Zbho9V/wDi9IL26hO1fwCzHWwtbSmKi0IW YlOAlzNHbUlJq13FLD+7Mwh1oLqMDqA75ozM2hIQoRKsxOmC3s4AUYLprIxYobWaK7wL RpwQTTAs3qqoI1uuxEDtyusNU0Xk2oobZIg27GqMadDvHfxThNJsumO5wB/uRY3YQQ1g sN6Mu+CTyI89rUQtYWgkrcorB5qaFEWdXYdwAUdiqfWNTfqAc81YN0htEtJYfTe4Am74 5ZH6sTSxhRpctHQ+pNXJKVfwcyS8S3ZxAgahfwR1fTOq0Ajt9Jvv+AgcU2h8DSQOMg+T 9L7Q== X-Gm-Message-State: AJIora8t9HUKtIh0GG9F7J19++7IJuimIpOIFR4pgcwqjKgCyZTBtAhN 6YyaXE14s5+h6jmzkId28d741MxxmqKO5Q== X-Google-Smtp-Source: AGRyM1t8YbZPKoNt3SVHEbMNWiCXGa6s/+2WnxNCS/lIsKKpmAF8v567YPgoU9faZjDRhYjzty1cwA== X-Received: by 2002:aca:3cd6:0:b0:33a:a673:2926 with SMTP id j205-20020aca3cd6000000b0033aa6732926mr93072oia.40.1658502191291; Fri, 22 Jul 2022 08:03:11 -0700 (PDT) Received: from [192.168.0.11] ([186.136.131.204]) by smtp.gmail.com with ESMTPSA id s33-20020a05680820a100b00339bf4473bcsm1825434oiw.56.2022.07.22.08.03.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jul 2022 08:03:10 -0700 (PDT) Message-ID: <970d0900-7e9c-5dcc-b306-aee15a84c2b6@gmail.com> Date: Fri, 22 Jul 2022 12:03:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220713175948.1955-1-jamrial@gmail.com> <8b484a4e-ba96-d54e-a4b5-84e1ee5e53f9@gmail.com> <3dfc3a5b-6b08-e36c-44e7-40cdf062cb3c@gmail.com> From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: don't force HE-AACv2 profile if no PS info is present X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 7/22/2022 11:56 AM, Andreas Rheinhardt wrote: > James Almer: >> On 7/22/2022 11:23 AM, Andreas Rheinhardt wrote: >>> James Almer: >>>> On 7/18/2022 10:57 AM, Andreas Rheinhardt wrote: >>>>> James Almer: >>>>>> On 7/14/2022 9:10 AM, Andreas Rheinhardt wrote: >>>>>>> James Almer: >>>>>>>> Should fix ticket #3361 >>>>>>>> >>>>>>>> Signed-off-by: James Almer >>>>>>>> --- >>>>>>>> This also needs an update to some fate ref samples i'll upload >>>>>>>> before >>>>>>>> pushing >>>>>>>> (fate-aac-al_sbr_ps_04_ur and fate-aac-al_sbr_ps_06_ur which are now >>>>>>>> decoded >>>>>>>> properly as he_aac mono, so the .s16 files need to be replaced). >>>>>>>> >>>>>>> >>>>>>> We have both a fixed-point AAC as well as a floating point AAC >>>>>>> decoder. >>>>>>> Is there actually a test that tests that the output they produce is >>>>>>> reasonably close? If not, could we make the test so that the same >>>>>>> file >>>>>>> is decoded once with the fixed-point and once with the floating-point >>>>>>> decoder and then compared? >>>>>> >>>>>> That wouldn't help much, i think. Almost all changes to *_template.c >>>>>> files are going to affect both decoders, so a breakage would not be >>>>>> detected if you compare their output with each other as they would >>>>>> both >>>>>> exhibit it. >>>>>> >>>>> >>>>> I actually thought that the aac_fixed tests used checksums instead of >>>>> ref files; then changes and breakages would be visible by changes to >>>>> these files. Apparently I was wrong about that and the ref files are >>>>> used for both aac and aac_fixed. But a test like the one outlined above >>>>> would nevertheless obviate the need for a new ref file. >>>> >>>> Judging by >>>> https://git.videolan.org/?p=ffmpeg.git;a=blob;f=tests/fate/aac.mak;h=1743428f544fad8946dba11dd4ecec0630eb70a6;hb=HEAD#l117 >>>> >>>> it seems at least for these samples the fixed decoder does not generate >>>> a decoded stream comparable to the float one, so I'll just upload a new >>>> raw pcm file. >>> >>> When I decode both of these streams with git master, the left channel is >>> pretty much identical, yet the right channel of the fixed-point decoder >>> is silent and the right channel of the floating point decoder is not. >>> With this patch applied, the result are two mono streams that are pretty >>> much identical: The test sample created by the floating-point decoder >>> works with the fixed-point decoder test (if one uncomments and modifies >>> the latter). So the issue with aac-al_sbr_ps_06_ur is not a reason to >>> upload new samples. >> >> Ok, can you suggest how to add a test that decodes with the fixed point >> decoder then compares that with the output of the float decoder? Is >> there a helper in fate.sh already for this? >> > > There is currently no helper in fate-run.sh for this. Yeah, figures that's the case. Can you suggest how one would work for this? > >>> >>> - Andreas >>> >>> PS: libfdk-aac produces a file that looks pretty much like the floating >>> point decoder from git master. Are you sure your patch is correct? >> >> Yes, they duplicate the single channel in the stream and output it as >> stereo, something that should be done by a filter if that's what the >> user wants. Decoding a mono sample should generate a mono stream. > > Not really. The channels are different. ./ffmpeg -c:a libfdk_aac -i ../samples/aac/al_sbr_ps_04_new.mp4 -af channelmap=channel_layout=mono:map=0 -f md5 - has the same result as ./ffmpeg -c:a libfdk_aac -i ../samples/aac/al_sbr_ps_04_new.mp4 -af channelmap=channel_layout=mono:map=1 -f md5 - Same with the samples in the ticket. > > - Andreas > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".