From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id A8A5D41A01
	for <ffmpegdev@gitmailbox.com>; Fri, 14 Jan 2022 09:24:13 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 887CB68B4B1;
	Fri, 14 Jan 2022 11:24:10 +0200 (EET)
Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 195C468B481
 for <ffmpeg-devel@ffmpeg.org>; Fri, 14 Jan 2022 11:24:04 +0200 (EET)
Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21])
 by mail8.parnet.fi  with ESMTP id 20E9O2gh008812-20E9O2gi008812;
 Fri, 14 Jan 2022 11:24:02 +0200
Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187])
 by mail9.parnet.fi (Postfix) with ESMTPS id 04685A1428;
 Fri, 14 Jan 2022 11:24:02 +0200 (EET)
Date: Fri, 14 Jan 2022 11:23:59 +0200 (EET)
From: =?ISO-8859-15?Q?Martin_Storsj=F6?= <martin@martin.st>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <1642150837-22960-1-git-send-email-lance.lmwang@gmail.com>
Message-ID: <96ff1-8470-c9b6-9878-1b84a296a4e3@martin.st>
References: <1642070709-3104-1-git-send-email-lance.lmwang@gmail.com>
 <1642150837-22960-1-git-send-email-lance.lmwang@gmail.com>
MIME-Version: 1.0
X-FE-Policy-ID: 3:14:2:SYSTEM
Subject: Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libopenh264enc: support
 for colorspace and range information
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Limin Wang <lance.lmwang@gmail.com>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain; charset="us-ascii"; Format="flowed"
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/96ff1-8470-c9b6-9878-1b84a296a4e3@martin.st/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

On Fri, 14 Jan 2022, lance.lmwang@gmail.com wrote:

> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavcodec/libopenh264enc.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c
> index de4b85c..5b5914c 100644
> --- a/libavcodec/libopenh264enc.c
> +++ b/libavcodec/libopenh264enc.c
> @@ -330,6 +330,28 @@ static av_cold int svc_encode_init(AVCodecContext *avctx)
>         }
>     }
>
> +#if OPENH264_VER_AT_LEAST(1, 6)
> +    param.sSpatialLayers[0].uiVideoFormat = VF_UNDEF;
> +    if (avctx->color_range != AVCOL_RANGE_UNSPECIFIED) {
> +        param.sSpatialLayers[0].bVideoSignalTypePresent = true;
> +        param.sSpatialLayers[0].bFullRange = (avctx->color_range == AVCOL_RANGE_JPEG);
> +    }
> +
> +    if (avctx->colorspace != AVCOL_SPC_UNSPECIFIED      ||
> +        avctx->color_primaries != AVCOL_PRI_UNSPECIFIED ||
> +        avctx->color_trc != AVCOL_TRC_UNSPECIFIED) {
> +        param.sSpatialLayers[0].bVideoSignalTypePresent = true;
> +        param.sSpatialLayers[0].bColorDescriptionPresent = true;
> +    }
> +
> +    if (avctx->colorspace != AVCOL_SPC_UNSPECIFIED)
> +        param.sSpatialLayers[0].uiColorMatrix = avctx->colorspace;
> +    if (avctx->color_primaries != AVCOL_PRI_UNSPECIFIED)
> +        param.sSpatialLayers[0].uiColorPrimaries = avctx->color_primaries;
> +    if (avctx->color_trc != AVCOL_TRC_UNSPECIFIED)
> +        param.sSpatialLayers[0].uiTransferCharacteristics = avctx->color_trc;
> +#endif

Thanks, this looks correct to me.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".