Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/libopenh264enc: support for colorspace and range information

["Martin Storsjö" <martin@martin.st>]

On Fri, 14 Jan 2022, lance.lmwang@gmail.com wrote:

> From: Limin Wang <lance.lmwang@gmail.com>
>
> Signed-off-by: Limin Wang <lance.lmwang@gmail.com>
> ---
> libavcodec/libopenh264enc.c | 22 ++++++++++++++++++++++
> 1 file changed, 22 insertions(+)
>
> diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c
> index de4b85c..5b5914c 100644
> --- a/libavcodec/libopenh264enc.c
> +++ b/libavcodec/libopenh264enc.c
> @@ -330,6 +330,28 @@ static av_cold int svc_encode_init(AVCodecContext *avctx)
>         }
>     }
>
> +#if OPENH264_VER_AT_LEAST(1, 6)
> +    param.sSpatialLayers[0].uiVideoFormat = VF_UNDEF;
> +    if (avctx->color_range != AVCOL_RANGE_UNSPECIFIED) {
> +        param.sSpatialLayers[0].bVideoSignalTypePresent = true;
> +        param.sSpatialLayers[0].bFullRange = (avctx->color_range == AVCOL_RANGE_JPEG);
> +    }
> +
> +    if (avctx->colorspace != AVCOL_SPC_UNSPECIFIED      ||
> +        avctx->color_primaries != AVCOL_PRI_UNSPECIFIED ||
> +        avctx->color_trc != AVCOL_TRC_UNSPECIFIED) {
> +        param.sSpatialLayers[0].bVideoSignalTypePresent = true;
> +        param.sSpatialLayers[0].bColorDescriptionPresent = true;
> +    }
> +
> +    if (avctx->colorspace != AVCOL_SPC_UNSPECIFIED)
> +        param.sSpatialLayers[0].uiColorMatrix = avctx->colorspace;
> +    if (avctx->color_primaries != AVCOL_PRI_UNSPECIFIED)
> +        param.sSpatialLayers[0].uiColorPrimaries = avctx->color_primaries;
> +    if (avctx->color_trc != AVCOL_TRC_UNSPECIFIED)
> +        param.sSpatialLayers[0].uiTransferCharacteristics = avctx->color_trc;
> +#endif

Thanks, this looks correct to me.

// Martin

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".