From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2A1154654D for ; Sun, 21 May 2023 14:25:16 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C580768BFFC; Sun, 21 May 2023 17:25:13 +0300 (EEST) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 78B6068BF91 for ; Sun, 21 May 2023 17:25:07 +0300 (EEST) Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-6ab03bb1991so1784586a34.0 for ; Sun, 21 May 2023 07:25:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684679105; x=1687271105; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=ORX5hJSjgDuZIoe4JNn1QQsoczFzfsZrfeevGDOuj1g=; b=nXhFR0B1SoILxde00UjqJOGfKoASgBNbELMSZb6vf30eOH5adFfsy3reIeilmFXUdV dysd6PBK8Gn655d65NxZKIjcECM9Ue3i4sbsoSim+uzKWnze/On3ff1Y9+Qt3wvN3mPf k/qCOs8tc+1hPTlcbFn2i1cxqfuCURS9p+bgli2hMmeejtCVai8dY/jF05dIsJc2PhQG qB26z+JyDYqufQ2SCmEMR5mUJm1BGSFLGPqAMRxtJ489iplZK5U3qeEO/krz3aTW01SJ VsoI9XROlnZDQrhxGsZ3BnYAeeIFnT4W1/dybRgRN1Zti9DzbV8CO3bZBGiGzqgKe0rh CJ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684679105; x=1687271105; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ORX5hJSjgDuZIoe4JNn1QQsoczFzfsZrfeevGDOuj1g=; b=hFaDT3IsOL+HorT1SoTRzC0h3jMnbXWwCrQ6s11kFsyNnOeYIirUjB7YluMUQTjS2g rt0Ph8Cesw/cdDJkmJ3wrdneRHwLMf0Wj0+xAzgy47xbEfeWel6oUJ91NfYKbkUEXnBq DvqWSofJRmMqW6FbqFXv801zlqOhi5L+W6ubisoj/QR04gUEbP1UVGZssWSuflYJXJI4 RrRrT7QNsvSV0kETTTqVpfgNFAScJ8E1lzCmEif71Xc3CT/zfMlmUkj9eF3ng9NydEPf I9eTCh/RgHTWef83qih9/0tkPkr5f4yPgaq3C033m1SJp5NXt3kCTN77yqtvnE8O+Ehp gGeg== X-Gm-Message-State: AC+VfDxcvCKygPRlkZ+BeUEVcJSjhal3Oby/ZWNF4akZjGCjq4pQXF/l 3zVT79JmAWf3iTqmbJujl24wWB8N1+M= X-Google-Smtp-Source: ACHHUZ6vhQXcIkUE2Z9PwgmzDpDDnRe8Z91w7W4rWVeeREeOjbPeGYH4iUqcNB+l5/ZpfX/Gk8U41A== X-Received: by 2002:a9d:7f93:0:b0:6af:7c91:6ba2 with SMTP id t19-20020a9d7f93000000b006af7c916ba2mr306972otp.4.1684679105384; Sun, 21 May 2023 07:25:05 -0700 (PDT) Received: from [192.168.0.12] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id q11-20020a056830018b00b006aaff32ac36sm1464947ota.66.2023.05.21.07.25.04 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 21 May 2023 07:25:05 -0700 (PDT) Message-ID: <96c9f7f8-3dd2-e22d-876d-ff7a8ee97a33@gmail.com> Date: Sun, 21 May 2023 11:25:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 To: ffmpeg-devel@ffmpeg.org References: <20230521130319.13813-1-nuomi2021@gmail.com> <20230521130319.13813-4-nuomi2021@gmail.com> Content-Language: en-US From: James Almer In-Reply-To: <20230521130319.13813-4-nuomi2021@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 03/14] vvcdec: add sps, pps, sh parser X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/21/2023 10:03 AM, Nuo Mi wrote: > --- > libavcodec/vvc/Makefile | 4 +- > libavcodec/vvc/vvc_data.c | 3295 ++++++++++++++++++++++++++++++++++++ > libavcodec/vvc/vvc_data.h | 69 + > libavcodec/vvc/vvc_ps.c | 3379 +++++++++++++++++++++++++++++++++++++ > libavcodec/vvc/vvc_ps.h | 811 +++++++++ > libavcodec/vvc/vvcdec.h | 3 + > 6 files changed, 7560 insertions(+), 1 deletion(-) > create mode 100644 libavcodec/vvc/vvc_data.c > create mode 100644 libavcodec/vvc/vvc_data.h > create mode 100644 libavcodec/vvc/vvc_ps.c > create mode 100644 libavcodec/vvc/vvc_ps.h As mentioned on IRC, this should ideally use the already written CBS implementation of h266 instead of rewriting a second standalone implementation, removing code duplication and and preventing extra work in the future when extensions are added to the spec. I'd like to hear Mark's opinion about this, too. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".