From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] speexdec: fix framesize for ultra-wideband
Date: Sat, 29 Mar 2025 21:34:11 -0300
Message-ID: <96a8893f-3288-4955-8352-aa133ef2584c@gmail.com> (raw)
In-Reply-To: <20250329214631.GQ4991@pb2>
[-- Attachment #1.1.1: Type: text/plain, Size: 687 bytes --]
On 3/29/2025 6:46 PM, Michael Niedermayer wrote:
> Hi Tristan
>
> On Thu, Mar 13, 2025 at 02:54:48PM -0400, Tristan Matthews wrote:
>> This matches how the libspeex decoder is calculating frame size (except in clamp form).
>>
>> Fixes #11495
>> ---
>> libavcodec/speexdec.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I belive this is a regression since ab39cc36c72bb73318bb911acb66873de850a107
> also james did multiple fixes to this piece of code afterwards
> maybe james can comment
It may also fix #11054, and if it doesn't regress what that patch fixed
(namely, vp5/potter512-400-partial.avi parsing) or reintroduces #11078,
then LGTM.
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-03-30 0:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-13 18:54 Tristan Matthews
2025-03-25 11:39 ` Tristan Matthews via ffmpeg-devel
2025-03-29 21:46 ` Michael Niedermayer
2025-03-30 0:34 ` James Almer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96a8893f-3288-4955-8352-aa133ef2584c@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git