Re: [FFmpeg-devel] [PATCH] vvcdec: Mark as experimental

[James Almer <jamrial@gmail.com>]

On 2/14/2024 10:41 AM, Kieran Kunhya wrote:
> On Wed, 14 Feb 2024 at 11:47, Andreas Rheinhardt <
> andreas.rheinhardt@outlook.com> wrote:
> 
>> Kieran Kunhya:
>>>  From 15c9311c49ebbe87fc4517b67cb73b3079ec3510 Mon Sep 17 00:00:00 2001
>>> From: Kieran Kunhya <kierank@obe.tv>
>>> Date: Wed, 7 Feb 2024 21:10:08 +0000
>>> Subject: [PATCH] vvcdec: Mark as experimental
>>>
>>> ---
>>>   libavcodec/vvc/vvcdec.c | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/libavcodec/vvc/vvcdec.c b/libavcodec/vvc/vvcdec.c
>>> index 8163b5e..e0554c6 100644
>>> --- a/libavcodec/vvc/vvcdec.c
>>> +++ b/libavcodec/vvc/vvcdec.c
>>> @@ -1011,7 +1011,7 @@ const FFCodec ff_vvc_decoder = {
>>>       .close          = vvc_decode_free,
>>>       FF_CODEC_DECODE_CB(vvc_decode_frame),
>>>       .flush          = vvc_decode_flush,
>>> -    .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY |
>> AV_CODEC_CAP_OTHER_THREADS,
>>> +    .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY |
>> AV_CODEC_CAP_OTHER_THREADS | AV_CODEC_CAP_EXPERIMENTAL,
>>>       .caps_internal  = FF_CODEC_CAP_EXPORTS_CROPPING |
>> FF_CODEC_CAP_INIT_CLEANUP |
>>>                         FF_CODEC_CAP_AUTO_THREADS,
>>>       .p.profiles     = NULL_IF_CONFIG_SMALL(ff_vvc_profiles),
>>
>> Did you run FATE with that? If I am not mistaken, all the VVC decoding
>> tests (and probably also tests where the VVC decoder is only used to get
>> stream parameters) will fail (in avcodec_open2()) now, because
>> strict_std_compliance does by default not allow experimental codecs.
>>
> 
> I am aware, it was more to see if there were any objections to the FOSDEM
> decision to make it experimental.
> 
> Kieran

I'll apply this patch soon (with the addition of forcing the vvc decoder 
and -strict experimental for the tests).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".