From: "Martin Storsjö" <martin@martin.st>
To: Nuo Mi <nuomi2021@gmail.com>
Cc: Zhao Zhili <zhilizhao@tencent.com>, ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/vvc: Add aarch64 neon optimization for ALF
Date: Tue, 23 Jul 2024 14:24:49 +0300 (EEST)
Message-ID: <95e03345-6acd-6a74-28df-45a27a7ee36d@martin.st> (raw)
In-Reply-To: <CAFXK13fEgvczEZbNXMFiedmTKrEx-RKuq6E4aqJNH1hPPg3r9Q@mail.gmail.com>
On Mon, 22 Jul 2024, Nuo Mi wrote:
> On Mon, Jul 22, 2024 at 9:15 PM Martin Storsjö <martin@martin.st> wrote:
> On Mon, 22 Jul 2024, Zhao Zhili wrote:
>
> > ffmpeg | branch: master | Zhao Zhili <zhilizhao@tencent.com> |
> Tue Jul 16 00:19:15 2024 +0800|
> [2d4ef304c9e13f5e8abe37c20ddd0f17102c6393] | committer: Nuo Mi
> >
> > avcodec/vvc: Add aarch64 neon optimization for ALF
> >
> >>http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=2d4ef304c9e13f5e8
> abe37c20ddd0f17102c6393
> > ---
> >
> > libavcodec/aarch64/vvc/Makefile | 5 +
> > libavcodec/aarch64/vvc/alf.S | 293
> ++++++++++++++++++++++++++++++++++
> > libavcodec/aarch64/vvc/alf_template.c | 157 ++++++++++++++++++
> > libavcodec/aarch64/vvc/dsp_init.c | 57 +++++++
> > libavcodec/vvc/dsp.c | 4 +-
> > libavcodec/vvc/dsp.h | 1 +
> > 6 files changed, 516 insertions(+), 1 deletion(-)
>
> I didn't review this patch yet.
>
> I've been on vacation, and I was hoping to get to reviewing this
> (and
> other things) soon when I catch up.
>
> The patch hasn't even been on the mailing list for one single
> week! For
> areas where earlier reviews have required multiple iterations to
> get
> patches right, I would hope that we could wait for an actual
> review.
>
> Hi Martin,
> Sorry for this.I will wait more time next time.
> Do you prefer to revert the patch temporarily?
No, it doesn't seem to be necesssary - the patch seems mostly fine in
practice; I only have a couple of minor suggestions. I'll send a patch to
fix those bits.
// Martin
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-23 11:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240722131038.9D44C41262C@natalya.videolan.org>
2024-07-22 13:15 ` Martin Storsjö
2024-07-22 14:13 ` Nuo Mi
2024-07-23 11:24 ` Martin Storsjö [this message]
2024-07-23 15:00 ` Nuo Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=95e03345-6acd-6a74-28df-45a27a7ee36d@martin.st \
--to=martin@martin.st \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=nuomi2021@gmail.com \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git