From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 43E6240245 for ; Sun, 20 Mar 2022 17:05:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 22A1468B0A2; Sun, 20 Mar 2022 19:05:01 +0200 (EET) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D1D8368A255 for ; Sun, 20 Mar 2022 19:04:54 +0200 (EET) Received: by mail-oi1-f181.google.com with SMTP id b188so14093766oia.13 for ; Sun, 20 Mar 2022 10:04:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=PhnXMHYoPJ6RoqjDrFYQm5+Nx/W24ByPPcIyzdnVgLQ=; b=aMqNSLv+GE/oZFu7e21mKc39J43cBguiY5et9lO86SPyRDZgiAzuYAw/163hbE/lXU KxNo/9+Ymgwy4/MsIx/SA4YpvsgGN9PY66J1lK1F/CHBkJo3n7dfeQ26L9wwKxo9OXrf nxvxEzbvCNuB+eXRdS3+DBN4i8IlR2jaorw0M+ad9xrN2tcWI/qYDXlwIHfV/E+STmb/ 6VvaofZ/ssGN79wlY/U1ojxsHL1D7MIWSNGQpPEH+T4Cuxs6GQGl5FijDdzwgzLt0+RB 3GIXdgfEFQzUd6cOoolEZfh80vqfNU8SfeN/2pP5V9EZyczyTIrwIsejIzm2Pp/E5e2L roxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=PhnXMHYoPJ6RoqjDrFYQm5+Nx/W24ByPPcIyzdnVgLQ=; b=zvVoElwzYh/CIdg3cPzaN7aOvBawMZIyXEF54/amqKFG3yF9eDhqoyJSkpVTryVPYi dnl5gu6FIXCXHdZoiIB9sSlyR0BZ7CiwryPSZ0xq62LBnVnyd9ED69HjJPzSZcPRPB/X yOw2eYpd51BrlKbFVhEjLCQJovitSjIYQSl6MJFxYz381F6NClRTAKrcaD+TbRmtNS6h qKl/Re4vRSowXti5Ey5BYU70g0jQtXg+r+Mw2igH3rpFNu3XQW/Ulh43q4PWW17p7QDb FPFExX8mcZlwIf7eY5w8+gowfpkvA3hCt9yU/wXnmplBAKk8nc9BGMgUP0ae23bxJGtZ Xy2Q== X-Gm-Message-State: AOAM531jFCDxRDJtG3N7TwMTuimrms1JYMDdXpMNKRm/enVl8k5ye/wt PKBVh6OEPHhuWEEkyUeq1+GB+NeUmCXe4Q== X-Google-Smtp-Source: ABdhPJwFjX5ptk3JgVxQbRtMRbTjKul7/nMj/bBhaoJOYMKl3RGcDPTAE40qefsbtTbboOQhLvljMA== X-Received: by 2002:a05:6808:f07:b0:2da:4916:578c with SMTP id m7-20020a0568080f0700b002da4916578cmr9073844oiw.239.1647795892825; Sun, 20 Mar 2022 10:04:52 -0700 (PDT) Received: from [192.168.0.13] ([186.136.131.95]) by smtp.gmail.com with ESMTPSA id a32-20020a056870a1a000b000d458b1469dsm5994993oaf.10.2022.03.20.10.04.51 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 20 Mar 2022 10:04:52 -0700 (PDT) Message-ID: <9592ea09-31df-03ff-108c-2cde734bd1e7@gmail.com> Date: Sun, 20 Mar 2022 14:04:53 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220318220018.49285410427@natalya.videolan.org> <20220320112904.GA1006142@pb2> From: James Almer In-Reply-To: <20220320112904.GA1006142@pb2> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/20/2022 8:29 AM, Michael Niedermayer wrote: > On Fri, Mar 18, 2022 at 10:00:17PM +0000, James Almer wrote: >> ffmpeg | branch: master | James Almer | Fri Mar 18 18:46:40 2022 -0300| [327efa66331ebdc0087c6b656059a8df2f404019] | committer: James Almer >> >> avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free() >> >> Fixes potential memleaks for existing options of this type. >> >> Signed-off-by: James Almer >> >>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=327efa66331ebdc0087c6b656059a8df2f404019 >> --- >> >> libavutil/opt.c | 4 ++++ >> 1 file changed, 4 insertions(+) > > this removes most timestamps from > libavformat/tests/seek ~/tickets/1605/08.rm -frames 10 > > ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32 > ret: 0 st:-1 flags:0 ts:-1.000000 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32 > ... > > vs. > ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32 > ret: 0 st:-1 flags:0 ts:-1.000000 > ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32 > ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32 Yes, this will be fixed by https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220319030407.45503-1-jamrial@gmail.com/ or some other way to prevent ch_layout from being nuked by avcodec_close() in libavformat/demux.c _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".