* Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free()
[not found] <20220318220018.49285410427@natalya.videolan.org>
@ 2022-03-20 11:29 ` Michael Niedermayer
2022-03-20 17:04 ` James Almer
0 siblings, 1 reply; 2+ messages in thread
From: Michael Niedermayer @ 2022-03-20 11:29 UTC (permalink / raw)
To: ffmpeg-devel
[-- Attachment #1.1: Type: text/plain, Size: 4419 bytes --]
On Fri, Mar 18, 2022 at 10:00:17PM +0000, James Almer wrote:
> ffmpeg | branch: master | James Almer <jamrial@gmail.com> | Fri Mar 18 18:46:40 2022 -0300| [327efa66331ebdc0087c6b656059a8df2f404019] | committer: James Almer
>
> avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free()
>
> Fixes potential memleaks for existing options of this type.
>
> Signed-off-by: James Almer <jamrial@gmail.com>
>
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=327efa66331ebdc0087c6b656059a8df2f404019
> ---
>
> libavutil/opt.c | 4 ++++
> 1 file changed, 4 insertions(+)
this removes most timestamps from
libavformat/tests/seek ~/tickets/1605/08.rm -frames 10
ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32
ret: 0 st:-1 flags:0 ts:-1.000000
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
...
vs.
ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32
ret: 0 st:-1 flags:0 ts:-1.000000
ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32
ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
"You are 36 times more likely to die in a bathtub than at the hands of a
terrorist. Also, you are 2.5 times more likely to become a president and
2 times more likely to become an astronaut, than to die in a terrorist
attack." -- Thoughty2
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [FFmpeg-cvslog] avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free()
2022-03-20 11:29 ` [FFmpeg-devel] [FFmpeg-cvslog] avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free() Michael Niedermayer
@ 2022-03-20 17:04 ` James Almer
0 siblings, 0 replies; 2+ messages in thread
From: James Almer @ 2022-03-20 17:04 UTC (permalink / raw)
To: ffmpeg-devel
On 3/20/2022 8:29 AM, Michael Niedermayer wrote:
> On Fri, Mar 18, 2022 at 10:00:17PM +0000, James Almer wrote:
>> ffmpeg | branch: master | James Almer <jamrial@gmail.com> | Fri Mar 18 18:46:40 2022 -0300| [327efa66331ebdc0087c6b656059a8df2f404019] | committer: James Almer
>>
>> avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free()
>>
>> Fixes potential memleaks for existing options of this type.
>>
>> Signed-off-by: James Almer <jamrial@gmail.com>
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=327efa66331ebdc0087c6b656059a8df2f404019
>> ---
>>
>> libavutil/opt.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>
> this removes most timestamps from
> libavformat/tests/seek ~/tickets/1605/08.rm -frames 10
>
> ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32
> ret: 0 st:-1 flags:0 ts:-1.000000
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: NOPTS pts: NOPTS pos: -1 size: 32
> ...
>
> vs.
> ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32
> ret: 0 st:-1 flags:0 ts:-1.000000
> ret: 0 st: 0 flags:1 dts: 0.000000 pts: 0.000000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.023000 pts: 0.023000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.046000 pts: 0.046000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.069000 pts: 0.069000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.092000 pts: 0.092000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.115000 pts: 0.115000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.138000 pts: 0.138000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.161000 pts: 0.161000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.184000 pts: 0.184000 pos: -1 size: 32
> ret: 0 st: 0 flags:1 dts: 0.207000 pts: 0.207000 pos: -1 size: 32
Yes, this will be fixed by
https://patchwork.ffmpeg.org/project/ffmpeg/patch/20220319030407.45503-1-jamrial@gmail.com/
or some other way to prevent ch_layout from being nuked by
avcodec_close() in libavformat/demux.c
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-03-20 17:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20220318220018.49285410427@natalya.videolan.org>
2022-03-20 11:29 ` [FFmpeg-devel] [FFmpeg-cvslog] avutil/opt: add missing case for AV_OPT_TYPE_CHLAYOUT in av_opt_free() Michael Niedermayer
2022-03-20 17:04 ` James Almer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git