From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 772E749497 for ; Wed, 13 Mar 2024 12:04:19 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E4BFC68CF01; Wed, 13 Mar 2024 14:04:16 +0200 (EET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7D26F68CEEB for ; Wed, 13 Mar 2024 14:04:10 +0200 (EET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1dd916ad172so27710025ad.2 for ; Wed, 13 Mar 2024 05:04:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1710331448; x=1710936248; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ic3fDEHWDGrfSyhR2Alvvga9K66kV4Usm2aqTvvEcio=; b=PV+IJZZEcI6FYKlGQswaeNKsuAoNEt2sUrq5OUOB4/ml2d9FHsYw/HRQ3rnbT8hzQ5 ilXbnmUmcbKbwgghlLE94sF79wZaAJPyv3BCa/+8zx5oLOfsBmiTHijiPfAz7YnOx2qc iSPl7YoiGxTD9ws5GKlw7D8kEIiK2NxCKWg8oXocpZTB/euqFcMt7zMMRHfvjAvtxuTY IKJ+E0ge3N5ceGU4jGOleQAJW5IICjt+c/ghjVNLlxvODJcUX4G0v1tLGmGG2LBNNexd ERyCgqjmgdqVIGXxhmNYt6mnljdiOueAyiYJiYnBDEkKGb+SzgxUKZ2FbtUEQyyOB+0N hE3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1710331448; x=1710936248; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ic3fDEHWDGrfSyhR2Alvvga9K66kV4Usm2aqTvvEcio=; b=eqZln+NZYuT20fBiluHluOlC6dzX4keOU2/+za84h6mTQlof+arZuTydqrfvzcTcwK +gMA+tTA6DbPgWSpnfHoevZby6khnK37zSjHB6Xr/7vECUer1cImLqEcaCEoXLUzLctK qUGWBLC69Wy8lRpcGCl4RtjchTN6RTXVwVG4HCNqZo3uSl/EKLt/eV4hdzQJphfYzt5g loXi50n2zYyRELxHPggj5FCFIwaqhyCwL7Enxp3XftJmfnWYMKHzoFRDN39c9zCbHGhS 2s+P+yuQobdgnF4Jlc8+w7JtsEZlStL3y88mTEIp2/tGgI3DpL8SRS0J3qhxyQNm2LCT 0aXQ== X-Gm-Message-State: AOJu0Yz9O+eLiMQkCLF+HIgzcHv9LJrsnOPaJLuw4e3dsSTOicuP5+cR tX4qWXh/ayNgjYzqLHCjVbpEJNhzVHel7u5Nri/JIg3xa/FRm3xobd1i7iuh X-Google-Smtp-Source: AGHT+IGqUG83lTAyCHOzvX0RcupPAs7sJtf7El9TtWxAmxPYkbJzRX1u0jDa/l1cOsaGwWUa4L9G1Q== X-Received: by 2002:a17:903:1250:b0:1dd:c7ee:2ca6 with SMTP id u16-20020a170903125000b001ddc7ee2ca6mr3155800plh.50.1710331447354; Wed, 13 Mar 2024 05:04:07 -0700 (PDT) Received: from [192.168.0.10] ([190.194.169.124]) by smtp.gmail.com with ESMTPSA id mn13-20020a1709030a4d00b001dc96292774sm8478239plb.296.2024.03.13.05.04.05 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 13 Mar 2024 05:04:06 -0700 (PDT) Message-ID: <9572cae6-7c1c-4882-a07e-14020f06e1a3@gmail.com> Date: Wed, 13 Mar 2024 09:04:10 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2] avcodec/ppc/h264dsp: Fix unaligned stores X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 3/13/2024 8:30 AM, Andreas Rheinhardt wrote: > Also fix an effective-type violation. > Exposed by https://fate.ffmpeg.org/report.cgi?time=20240312011016&slot=ppc-linux-gcc-13.2-ubsan-altivec-qemu > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/ppc/h264dsp.c | 35 +++++++++++++++++------------------ > 1 file changed, 17 insertions(+), 18 deletions(-) > > diff --git a/libavcodec/ppc/h264dsp.c b/libavcodec/ppc/h264dsp.c > index c02733dda2..f50f2553a2 100644 > --- a/libavcodec/ppc/h264dsp.c > +++ b/libavcodec/ppc/h264dsp.c > @@ -401,30 +401,29 @@ static inline void write16x4(uint8_t *dst, int dst_stride, > register vec_u8 r0, register vec_u8 r1, > register vec_u8 r2, register vec_u8 r3) { > DECLARE_ALIGNED(16, unsigned char, result)[64]; > - uint32_t *src_int = (uint32_t *)result, *dst_int = (uint32_t *)dst; > - int int_dst_stride = dst_stride/4; > + uint32_t *src_int = (uint32_t *)result; > > vec_st(r0, 0, result); > vec_st(r1, 16, result); > vec_st(r2, 32, result); > vec_st(r3, 48, result); > /* FIXME: there has to be a better way!!!! */ > - *dst_int = *src_int; > - *(dst_int+ int_dst_stride) = *(src_int + 1); > - *(dst_int+ 2*int_dst_stride) = *(src_int + 2); > - *(dst_int+ 3*int_dst_stride) = *(src_int + 3); > - *(dst_int+ 4*int_dst_stride) = *(src_int + 4); > - *(dst_int+ 5*int_dst_stride) = *(src_int + 5); > - *(dst_int+ 6*int_dst_stride) = *(src_int + 6); > - *(dst_int+ 7*int_dst_stride) = *(src_int + 7); > - *(dst_int+ 8*int_dst_stride) = *(src_int + 8); > - *(dst_int+ 9*int_dst_stride) = *(src_int + 9); > - *(dst_int+10*int_dst_stride) = *(src_int + 10); > - *(dst_int+11*int_dst_stride) = *(src_int + 11); > - *(dst_int+12*int_dst_stride) = *(src_int + 12); > - *(dst_int+13*int_dst_stride) = *(src_int + 13); > - *(dst_int+14*int_dst_stride) = *(src_int + 14); > - *(dst_int+15*int_dst_stride) = *(src_int + 15); > + AV_WN32(dst, AV_RN32A(src_int + 0)); > + AV_WN32(dst + dst_stride, AV_RN32A(src_int + 1)); > + AV_WN32(dst + 2 * dst_stride, AV_RN32A(src_int + 2)); > + AV_WN32(dst + 3 * dst_stride, AV_RN32A(src_int + 3)); > + AV_WN32(dst + 4 * dst_stride, AV_RN32A(src_int + 4)); > + AV_WN32(dst + 5 * dst_stride, AV_RN32A(src_int + 5)); > + AV_WN32(dst + 6 * dst_stride, AV_RN32A(src_int + 6)); > + AV_WN32(dst + 7 * dst_stride, AV_RN32A(src_int + 7)); > + AV_WN32(dst + 8 * dst_stride, AV_RN32A(src_int + 8)); > + AV_WN32(dst + 9 * dst_stride, AV_RN32A(src_int + 9)); > + AV_WN32(dst + 10 * dst_stride, AV_RN32A(src_int + 10)); > + AV_WN32(dst + 11 * dst_stride, AV_RN32A(src_int + 11)); > + AV_WN32(dst + 12 * dst_stride, AV_RN32A(src_int + 12)); > + AV_WN32(dst + 13 * dst_stride, AV_RN32A(src_int + 13)); > + AV_WN32(dst + 14 * dst_stride, AV_RN32A(src_int + 14)); > + AV_WN32(dst + 15 * dst_stride, AV_RN32A(src_int + 15)); Is there any benefit using AV_RN32A() when src_int is already a pointer to a uint32_t? > } > > /** @brief performs a 6x16 transpose of data in src, and stores it to dst _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".