From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id AAEE14A50F for ; Fri, 29 Mar 2024 09:19:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE8B868D657; Fri, 29 Mar 2024 11:19:24 +0200 (EET) Received: from mout-p-103.mailbox.org (mout-p-103.mailbox.org [80.241.56.161]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9308F68D515 for ; Fri, 29 Mar 2024 11:19:18 +0200 (EET) Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:b231:465::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4V5Zbl3yDzz9s7Q for ; Fri, 29 Mar 2024 10:19:15 +0100 (CET) Message-ID: <956a6e07-c5ae-4b79-be32-98839ea06d5a@gyani.pro> Date: Fri, 29 Mar 2024 14:49:15 +0530 MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org References: <20240329083509.10130-1-anton@khirnov.net> Content-Language: en-US From: Gyan Doshi In-Reply-To: <20240329083509.10130-1-anton@khirnov.net> X-Rspamd-Queue-Id: 4V5Zbl3yDzz9s7Q Subject: Re: [FFmpeg-devel] [PATCH] lavf/movenc: mark mov/mp4 as supporting VFR X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 2024-03-29 02:05 pm, Anton Khirnov wrote: > --- > libavformat/movenc.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index b97c479cc4..30cfbf6e74 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/movenc.c > @@ -8230,11 +8230,11 @@ const FFOutputFormat ff_mov_muxer = { > .write_packet = mov_write_packet, > .write_trailer = mov_write_trailer, > .deinit = mov_free, > + .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE | AVFMT_VARIABLE_FPS > #if FF_API_ALLOW_FLUSH > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE, > -#else > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE, > + | AVFMT_ALLOW_FLUSH > #endif > + , > .p.codec_tag = (const AVCodecTag* const []){ > ff_codec_movvideo_tags, ff_codec_movaudio_tags, ff_codec_movsubtitle_tags, 0 > }, > @@ -8282,11 +8282,11 @@ const FFOutputFormat ff_mp4_muxer = { > .write_packet = mov_write_packet, > .write_trailer = mov_write_trailer, > .deinit = mov_free, > + .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE | AVFMT_VARIABLE_FPS > #if FF_API_ALLOW_FLUSH > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_ALLOW_FLUSH | AVFMT_TS_NEGATIVE, > -#else > - .p.flags = AVFMT_GLOBALHEADER | AVFMT_TS_NEGATIVE, > + | AVFMT_ALLOW_FLUSH > #endif > + , > .p.codec_tag = mp4_codec_tags_list, > .check_bitstream = mov_check_bitstream, > .p.priv_class = &mov_isobmff_muxer_class, LGTM. Should have been done a long time ago. What about the other muxers in movenc? Regards, Gyan _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".