* [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation
@ 2024-04-22 20:31 Mark Thompson
2024-04-22 20:36 ` Lynne
0 siblings, 1 reply; 3+ messages in thread
From: Mark Thompson @ 2024-04-22 20:31 UTC (permalink / raw)
To: FFmpeg development discussions and patches
---
Actually match the specification. (Though I'm guessing this field isn't actually used if things pass anyway?)
libavcodec/av1dec.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
index 69da08b686..79a30a114d 100644
--- a/libavcodec/av1dec.c
+++ b/libavcodec/av1dec.c
@@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s)
int ref_order_hint = s->ref[ref_slot].order_hint;
frame->order_hints[ref_name] = ref_order_hint;
- frame->ref_frame_sign_bias[ref_name] =
- get_relative_dist(seq, ref_order_hint, frame->order_hint);
+ if (!seq->enable_order_hint) {
+ frame->ref_frame_sign_bias[ref_name] = 0;
+ } else {
+ frame->ref_frame_sign_bias[ref_name] =
+ get_relative_dist(seq, ref_order_hint,
+ frame->order_hint) > 0;
+ }
}
}
--
2.43.0
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation
2024-04-22 20:31 [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation Mark Thompson
@ 2024-04-22 20:36 ` Lynne
2024-04-22 20:45 ` Mark Thompson
0 siblings, 1 reply; 3+ messages in thread
From: Lynne @ 2024-04-22 20:36 UTC (permalink / raw)
To: FFmpeg development discussions and patches
Apr 22, 2024, 22:31 by sw@jkqxz.net:
> ---
> Actually match the specification. (Though I'm guessing this field isn't actually used if things pass anyway?)
>
> libavcodec/av1dec.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
> index 69da08b686..79a30a114d 100644
> --- a/libavcodec/av1dec.c
> +++ b/libavcodec/av1dec.c
> @@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s)
> int ref_order_hint = s->ref[ref_slot].order_hint;
>
> frame->order_hints[ref_name] = ref_order_hint;
> - frame->ref_frame_sign_bias[ref_name] =
> - get_relative_dist(seq, ref_order_hint, frame->order_hint);
> + if (!seq->enable_order_hint) {
> + frame->ref_frame_sign_bias[ref_name] = 0;
> + } else {
> + frame->ref_frame_sign_bias[ref_name] =
> + get_relative_dist(seq, ref_order_hint,
> + frame->order_hint) > 0;
> + }
> }
> }
>
LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation
2024-04-22 20:36 ` Lynne
@ 2024-04-22 20:45 ` Mark Thompson
0 siblings, 0 replies; 3+ messages in thread
From: Mark Thompson @ 2024-04-22 20:45 UTC (permalink / raw)
To: ffmpeg-devel
On 22/04/2024 21:36, Lynne wrote:
> Apr 22, 2024, 22:31 by sw@jkqxz.net:
>
>> ---
>> Actually match the specification. (Though I'm guessing this field isn't actually used if things pass anyway?)
>>
>> libavcodec/av1dec.c | 9 +++++++--
>> 1 file changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c
>> index 69da08b686..79a30a114d 100644
>> --- a/libavcodec/av1dec.c
>> +++ b/libavcodec/av1dec.c
>> @@ -373,8 +373,13 @@ static void order_hint_info(AV1DecContext *s)
>> int ref_order_hint = s->ref[ref_slot].order_hint;
>>
>> frame->order_hints[ref_name] = ref_order_hint;
>> - frame->ref_frame_sign_bias[ref_name] =
>> - get_relative_dist(seq, ref_order_hint, frame->order_hint);
>> + if (!seq->enable_order_hint) {
>> + frame->ref_frame_sign_bias[ref_name] = 0;
>> + } else {
>> + frame->ref_frame_sign_bias[ref_name] =
>> + get_relative_dist(seq, ref_order_hint,
>> + frame->order_hint) > 0;
>> + }
>> }
>> }
>>
>
> LGTM
Applied, thank you.
- Mark
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-04-22 20:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-22 20:31 [FFmpeg-devel] [PATCH] av1dec: Fix RefFrameSignBias calculation Mark Thompson
2024-04-22 20:36 ` Lynne
2024-04-22 20:45 ` Mark Thompson
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git