From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 9AB3D41D2B for ; Thu, 17 Feb 2022 20:05:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id CBCF568B34F; Thu, 17 Feb 2022 22:05:42 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A44D768B28A for ; Thu, 17 Feb 2022 22:05:36 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 2C65DE64A7 for ; Thu, 17 Feb 2022 21:05:36 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id FZAafhedv9ah for ; Thu, 17 Feb 2022 21:05:31 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 095ABE216B for ; Thu, 17 Feb 2022 21:05:31 +0100 (CET) Date: Thu, 17 Feb 2022 21:05:30 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20220216150859.16844-5-nil-admirari@mailo.com> Message-ID: <94ddaad-1c96-2eea-39ee-222c41f36b3@passwd.hu> References: <20220216150859.16844-1-nil-admirari@mailo.com> <20220216150859.16844-5-nil-admirari@mailo.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v3 5/5] fftools: Enable long path support on Windows (fixes #8885) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 16 Feb 2022, nihil-admirari wrote: > --- > fftools/Makefile | 5 +++++ > fftools/long_paths_utf8.manifest | 12 ++++++++++++ > fftools/long_paths_utf8.rc | 3 +++ > 3 files changed, 20 insertions(+) > create mode 100644 fftools/long_paths_utf8.manifest > create mode 100644 fftools/long_paths_utf8.rc > > diff --git a/fftools/Makefile b/fftools/Makefile > index da42078..53438b6 100644 > --- a/fftools/Makefile > +++ b/fftools/Makefile > @@ -11,6 +11,11 @@ ALLAVPROGS_G = $(AVBASENAMES:%=%$(PROGSSUF)_g$(EXESUF)) > > OBJS-ffmpeg += fftools/ffmpeg_opt.o fftools/ffmpeg_filter.o fftools/ffmpeg_hw.o > > +# Windows resource files > +OBJS-ffmpeg-$(HAVE_GNU_WINDRES) += fftools/long_paths_utf8.o > +OBJS-ffplay-$(HAVE_GNU_WINDRES) += fftools/long_paths_utf8.o > +OBJS-ffprobe-$(HAVE_GNU_WINDRES) += fftools/long_paths_utf8.o > + > define DOFFTOOL > OBJS-$(1) += fftools/cmdutils.o fftools/$(1).o $(OBJS-$(1)-yes) > $(1)$(PROGSSUF)_g$(EXESUF): $$(OBJS-$(1)) > diff --git a/fftools/long_paths_utf8.manifest b/fftools/long_paths_utf8.manifest > new file mode 100644 > index 0000000..d1ac1e4 > --- /dev/null > +++ b/fftools/long_paths_utf8.manifest > @@ -0,0 +1,12 @@ > + > + > + > + > + > + + xmlns:ws2019="http://schemas.microsoft.com/SMI/2019/WindowsSettings"> > + true > + UTF-8 Generally UTF-8 codepage should not be needed, because unicode windows functions should be used everywhere, right? I'd perfer if you enable UTF8 codepage in a separate patch. And use simple fftools/fftools.manifest and fftools/manifest.rc as filenames, because later other things might be put there, not only utf8/longpath support. Thanks, Marton > + > + > + > diff --git a/fftools/long_paths_utf8.rc b/fftools/long_paths_utf8.rc > new file mode 100644 > index 0000000..f33de76 > --- /dev/null > +++ b/fftools/long_paths_utf8.rc > @@ -0,0 +1,3 @@ > +#include > + > +CREATEPROCESS_MANIFEST_RESOURCE_ID RT_MANIFEST "long_paths_utf8.manifest" > -- > 2.32.0 > > > > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".