From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 71955420F7 for ; Thu, 28 Apr 2022 10:58:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C461C68B399; Thu, 28 Apr 2022 13:58:49 +0300 (EEST) Received: from mo4-p01-ob.smtp.rzone.de (mo4-p01-ob.smtp.rzone.de [85.215.255.52]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AB85868B104 for ; Thu, 28 Apr 2022 13:58:42 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1651143522; s=strato-dkim-0002; d=videmo.de; h=In-Reply-To:From:Subject:References:To:Date:Message-ID:Cc:Date:From: Subject:Sender; bh=WIY2dG+vNwqjjRO8cbTmlm7kDUv1xQbWlpiZXA4GnyI=; b=UbdnW8s78dIsM3YE49Mt4Gs02Dy7/Mj3ATR+P7T6E/qBCqAb7JcQwcVKLYS4FPs0yf TEdaQDTDQYTvSlRz71DkNgydhFxOpwq4KiTZjRnNh4gXV80a63W7ALeEZ7gq/zpGuaPL kwIB+FaWsT+1GRW1nVNrJCJ+WJInNLuBYbaFPYt0oOUkLRAMQ5ghhyDcoN33ewPLkAaa 35tDsrp4GiMif3F/PYNutDL0VSiyt61y0ZbELjxql9Wg3WLeKVxIbuIuLgs4HoXEYPkL BfRtT8IJxLKI1yIsG/0iVpCPT3S6wzaDMV0bGHeg/4A0C69FK/aKK0QnxQ7lVr8LjUnA 7gfQ== Authentication-Results: strato.com; dkim=none X-RZG-AUTH: ":KmUXdkitad8weeb+H1gpvUxD1DOUaE6Zx+DK0oCJ4Dx47MSH97dmalu/YWJaikJksGCnZu1ytNKx+9F93Too2iRkjj6kT4TWDnrC" X-RZG-CLASS-ID: mo00 Received: from [IPV6:2003:f9:5f00:3400:c191:8d77:68bf:42d7] by smtp.strato.de (RZmta 47.42.2 AUTH) with ESMTPSA id 070216y3SAwfsp8 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate) for ; Thu, 28 Apr 2022 12:58:41 +0200 (CEST) Message-ID: <94c354ae-bf25-1035-ff67-2272ce0aa83c@videmo.de> Date: Thu, 28 Apr 2022 12:58:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 To: ffmpeg-devel@ffmpeg.org References: <20210911194900.17480-1-onemda@gmail.com> From: Mika Fischer Organization: Videmo Intelligente Videoanalyse GmbH In-Reply-To: <20210911194900.17480-1-onemda@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Hi, I think this patch, which was applied on 2021-09-12 in 19802d170a304f5853d92e01d0513b9e06897d61 and is included in n5.0 and n5.0.1 causes a regression. This is the (shortened) diff for the test decoding in the patch: ---------------- diff --git a/tests/ref/fate/flcl1905 b/tests/ref/fate/flcl1905 index 5f5245ebcf..d702139db8 100644 --- a/tests/ref/fate/flcl1905 +++ b/tests/ref/fate/flcl1905 @@ -1,6 +1,4 @@ packet|[...]|pts=0|pts_time=0.000000|[...] -frame|[...]|pts=0|pts_time=0.000000|[...] -frame|[...]|pts=N/A|pts_time=N/A|[...] frame|[...]|pts=N/A|pts_time=N/A|[...] ---------------- As can be seen, the patch causes the first two frames to be dropped, which might be OK to better conform to the MS decoder. The problem is that only the first frame had the timestamp info from the packet. Since that got dropped, now the first frame decoded from the packet has no timestamp info. This causes us issues since we assumed that the first audio frame decoded after seeking always has timestamp info. Best regards, Mika Fischer _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".