From: Mika Fischer <fischer@videmo.de>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/wmadec: fix WMA gapless playback
Date: Thu, 28 Apr 2022 12:58:41 +0200
Message-ID: <94c354ae-bf25-1035-ff67-2272ce0aa83c@videmo.de> (raw)
In-Reply-To: <20210911194900.17480-1-onemda@gmail.com>
Hi,
I think this patch, which was applied on 2021-09-12 in
19802d170a304f5853d92e01d0513b9e06897d61 and is included in n5.0 and
n5.0.1 causes a regression.
This is the (shortened) diff for the test decoding in the patch:
----------------
diff --git a/tests/ref/fate/flcl1905 b/tests/ref/fate/flcl1905
index 5f5245ebcf..d702139db8 100644
--- a/tests/ref/fate/flcl1905
+++ b/tests/ref/fate/flcl1905
@@ -1,6 +1,4 @@
packet|[...]|pts=0|pts_time=0.000000|[...]
-frame|[...]|pts=0|pts_time=0.000000|[...]
-frame|[...]|pts=N/A|pts_time=N/A|[...]
frame|[...]|pts=N/A|pts_time=N/A|[...]
----------------
As can be seen, the patch causes the first two frames to be dropped,
which might be OK to better conform to the MS decoder.
The problem is that only the first frame had the timestamp info from the
packet. Since that got dropped, now the first frame decoded from the
packet has no timestamp info.
This causes us issues since we assumed that the first audio frame
decoded after seeking always has timestamp info.
Best regards,
Mika Fischer
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
parent reply other threads:[~2022-04-28 10:58 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20210911194900.17480-1-onemda@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94c354ae-bf25-1035-ff67-2272ce0aa83c@videmo.de \
--to=fischer@videmo.de \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git