From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations
Date: Fri, 11 Jul 2025 17:34:48 +0200
Message-ID: <94AB3400-8305-48BB-B69E-6EE6999BF812@gmail.com> (raw)
In-Reply-To: <mailman.4499.1750887565.1384.ffmpeg-devel@ffmpeg.org>
On 25 Jun 2025, at 23:39, Tristan Matthews via ffmpeg-devel wrote:
> On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
>
> Tristan Matthews via ffmpeg-devel:
>
> On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt andreas.rheinhardt@outlook.com wrote:
>
> Patch attached.
>
> LGTM, and sorry about that, for future reference did you do anything in particular (instrumentation wise) to catch the stack overflow? I tried make fate on a few different machines and didn't hit that.
>
> Best,
> Tristan
>
>
> I used (Clang) ASAN. Presumably Zhao Zhili (who first reported the stack
> buffer overflow) did so, too.
>
> - Andreas
>
>
> It'd be good to merge either this or Zhao Zhili's patch to get checkasm back to being ASAN clean.
>
> Best,
> Tristan
If there are no objections, I would like to merge this patch soon.
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2025-07-11 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-16 10:53 Andreas Rheinhardt
2025-06-16 15:01 ` Tristan Matthews via ffmpeg-devel
2025-06-16 18:21 ` Andreas Rheinhardt
2025-06-25 21:39 ` Tristan Matthews via ffmpeg-devel
2025-07-11 15:34 ` Marvin Scholz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=94AB3400-8305-48BB-B69E-6EE6999BF812@gmail.com \
--to=epirat07-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git