From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6803140D8A for ; Sat, 9 Apr 2022 19:40:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3297D68B309; Sat, 9 Apr 2022 22:39:59 +0300 (EEST) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 59AF468ACAB for ; Sat, 9 Apr 2022 22:39:53 +0300 (EEST) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id F29B4E686B for ; Sat, 9 Apr 2022 21:39:53 +0200 (CEST) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id IPW0Q7f3YkVT for ; Sat, 9 Apr 2022 21:39:51 +0200 (CEST) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id 9086DE6825 for ; Sat, 9 Apr 2022 21:39:51 +0200 (CEST) Date: Sat, 9 Apr 2022 21:39:51 +0200 (CEST) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <949d1e94-e044-6537-d12c-32ae0d9a830@passwd.hu> References: <20220322133957.81743-1-toots@rastageeks.org> <20220322133957.81743-2-toots@rastageeks.org> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/6] Fix dshow device name/description X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 22 Mar 2022, Diederick C. Niehorster wrote: > On Tue, Mar 22, 2022 at 3:10 PM Roger Pack wrote: >> >> On Tue, Mar 22, 2022 at 7:40 AM wrote: >>> >>> From: Romain Beauxis >>> >>> diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c >>> index 6039578ff9..4ee3f6e194 100644 >>> --- a/libavdevice/dshow.c >>> +++ b/libavdevice/dshow.c >>> @@ -552,8 +552,8 @@ dshow_cycle_devices(AVFormatContext *avctx, ICreateDevEnum *devenum, >>> if (!device) >>> goto fail; >>> >>> - device->device_name = av_strdup(friendly_name); >>> - device->device_description = av_strdup(unique_name); >>> + device->device_name = av_strdup(unique_name); >>> + device->device_description = av_strdup(friendly_name); >>> if (!device->device_name || !device->device_description) >>> goto fail; >>> >> >> LGTM. >> The device enumeration API was added only recently to dshow, guess a >> bug crept in. >> Thanks! > > LGTM. > > Indeed, this was code introduced by my patch, committed to the ffmpeg > repo only 91 days ago. Indeed, this should have been the other way > around given the documentation of struct AVDeviceInfo. Applied, thanks. Marton > > All the best, > Dee > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".