From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4E1B04F072 for ; Fri, 16 May 2025 08:51:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7F8F768C949; Fri, 16 May 2025 11:51:00 +0300 (EEST) Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 835F568C91E for ; Fri, 16 May 2025 11:50:53 +0300 (EEST) Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-54fcd7186dfso2194685e87.0 for ; Fri, 16 May 2025 01:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1747385452; x=1747990252; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=EB90p/hZ6ipnlBiWHUmjLJjSJo5fCs84ahEGOgkLHtM=; b=TJG15p1bzA9Iz8/2K4tqXKFPqph5bvcKphebmXCgexymCN4tL84JQOywIUn5enO8mq GeBeyBB67lEh4H1FZ9WI3kfuOP1IpNESwrzyz/KuDtvY0iuiPUAXEwX1dMcAgJw1WslR eBaiGofN+a/w193k8m+B27USlPOYw/ITzqEZfbM+ylO9zryArisaQoA49A5WyoA1Am7U 2I3Ib1ESMHNKmChjTnCzMlt7yMmvI8DDISK1Ea2ragsY893Z+C6CUCgR7dSIlBdAR1g7 05EnFJm6AlJnY/xXNme4+MyqlDIfVx/AAzD1JeUoPyg3uGcLZUayydyDlcLTwoBjcI8W e2Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1747385452; x=1747990252; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EB90p/hZ6ipnlBiWHUmjLJjSJo5fCs84ahEGOgkLHtM=; b=rQpnuW9B9ek0fH+RvtAjYIf1Oxf7d92N0dVOyy4LlfCY7fJ+CPTigUi4MhzE01dBjW TtCjXHWrZlu1yLZHwXnsZsawUi/gf2ziHXsEhiuHWQ6AtJnL2OREolcJENG4nZQD8JWs uTP27kXBc1znrjTHKhMMFOffiyJixedOTKhEOy/g1HyyRRTv4lto6qv+sm5oteicsOk3 z9vjFE1A7YRgdXaG+HKYkfrWMvyb4j0MPd5/AeIJC2vNfinMP6gOhC4Yd4MNheSlZQtI uSkn2YCUi9BWe07qBiXwXaxJBaeiX4lEd8tsYJr0uouFon16eErPvulM+TCgwXMpPISH T1ZA== X-Gm-Message-State: AOJu0Yzi8iSJzxCMALokQTtNr8G4/2MXuZT8p57hhUdulDQYgC0tMorE PirjHBWNzA0dEAoIYjNzVY45WdMPjn2oa9MYeVVH/mqufjDOTJaZz6BEDEAwLR0RVrn3BXG2o7u E9w228w== X-Gm-Gg: ASbGnctWZmXWuQRc3IuWLU6H9KrHf1EtQm3qrndZnVymwgl1RZ9jGHNMUQFV1idbLm4 cGN7JQPUw590sAnE6Y+VbVGUZN40UhQeUQlKbOqHDZGqsoDZ0FZlWLqk1+BN4QdpLGqGs9VQj4/ lnb+vppdyxj2LH8jGADX65td+FaYLM3NPZ5CyqbAQV3iOLzipwLs3WMFge4N0cFoXc8XlIUzYi/ TcttxTFB7PesD1sv8TiQOvgcAikft2hsdL85exdYG8APKIzdG7FvwvllzQ7ydosDfTAb+Lgp534 BVMSvZ9zJKEhLeFmcddXcZz2f+EWoRzB6xToXxOJ8aRa21rOAq6FxAnzE/wsLAQp2YJEmyax3Sj KQdb96EwQAMdi8QYtP9wquoAQFcN+/0hTARRRiEhjLao+1tk= X-Google-Smtp-Source: AGHT+IHVB+05e953wR1zC8HGRkuToBHAoJDU+/jvCmvX6lbWHQ34YFer48qCCkelLQ3OQEve028A+w== X-Received: by 2002:a05:6512:6415:b0:550:e451:5505 with SMTP id 2adb3069b0e04-550e7245461mr627738e87.39.1747385452358; Fri, 16 May 2025 01:50:52 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-550e6f3543fsm339606e87.97.2025.05.16.01.50.51 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 May 2025 01:50:52 -0700 (PDT) Date: Fri, 16 May 2025 11:50:51 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <941b73b-44cb-b49a-7c3e-62f2cffb2e10@martin.st> References: <20250515211148.6C91C4128B8@natalya.videolan.org> <3df3113a-203a-11de-6bdb-6a3ed7771c94@martin.st> MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, make it a Killer-Feature! X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Fri, 16 May 2025, softworkz . wrote: >> -----Original Message----- >> From: ffmpeg-devel On Behalf Of Martin >> Storsj=F6 >> Sent: Freitag, 16. Mai 2025 10:19 >> To: FFmpeg development discussions and patches >> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, mak= e it a >> Killer-Feature! >> >> On Fri, 16 May 2025, softworkz . wrote: >> >>> >>> >>>> -----Original Message----- >>>> From: ffmpeg-devel On Behalf Of Mart= in >>>> Storsj=F6 >>>> Sent: Freitag, 16. Mai 2025 08:22 >>>> To: ffmpeg-devel@ffmpeg.org >>>> Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/graphprint: Now, m= ake >> it a >>>> Killer-Feature! >>>> >>>> On Thu, 15 May 2025, softworkz wrote: >>>> >>>>> ffmpeg | branch: master | softworkz | Thu May= 15 >>>> 23:10:02 2025 +0200| [1f2b8d7238eff4ab8a4d8d6177e250b8180d51f4] | >> committer: >>>> softworkz >>>>> >>>>> fftools/graphprint: Now, make it a Killer-Feature! >>>>> >>>>> remember this: -sg <=3D means Show Graph >>>>> >>>>> Signed-off-by: softworkz >>>>> >>>>>> >>>> >> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=3Dcommit;h=3D1f2b8d7238= eff4ab8a4d >>>> 8d6177e250b8180d51f4 >>>>> --- >>>> >>>> This broke compilation in a number of configurations: >>>> >>>> Windows UWP/Phone: >>>> https://fate.ffmpeg.org/report.cgi?slot=3Darm-msvc2022- >>>> winphone&time=3D20250516053009 >>>> >>>> filelauncher.o : error LNK2019: unresolved external symbol ShellExecut= eA >>>> referenced in function ff_open_html_in_browser >>>> ffmpeg_g.exe : fatal error LNK1120: 1 unresolved externals >>>> >>>> iOS: >>>> https://fate.ffmpeg.org/report.cgi?slot=3Daarch64-apple-darwin- >>>> ios18&time=3D20250516011754 >>>> >>>> src/fftools/graph/filelauncher.c:61:13: error: 'system' is unavailable: >>>> not available on iOS >>>> 61 | if (system(cmd) !=3D 0) >>>> | ^ >>>> >> /Users/mstorsjo/Xcode_16.2.app/Contents/Developer/Platforms/iPhoneOS.pla= tform/ >>>> Developer/SDKs/iPhoneOS.sdk/usr/include/_stdlib.h:184:6: >>>> note: 'system' has been explicitly marked unavailable here >>>> 184 | int system(const char *) __DARWIN_ALIAS_C(system); >>>> | ^ >>>> 1 error generated. >>>> >>>> tvOS: >>>> https://fate.ffmpeg.org/report.cgi?slot=3Daarch64-apple-darwin- >>>> tvos18&time=3D20250516014542 >>>> >>>> src/fftools/graph/filelauncher.c:61:13: error: 'system' is unavailable: >>>> not available on tvOS >>>> 61 | if (system(cmd) !=3D 0) >>>> | ^ >>>> >> /Users/mstorsjo/Xcode_16.2.app/Contents/Developer/Platforms/AppleTVOS.pl= atform >>>> /Developer/SDKs/AppleTVOS.sdk/usr/include/_stdlib.h:184:6: >>>> note: 'system' has been explicitly marked unavailable here >>>> 184 | int system(const char *) __DARWIN_ALIAS_C(system); >>>> | ^ >>>> 1 error generated. >>>> >>>> // Martin >>>> >>> >>> Hi Martin, >>> >>> do you think this is a reasonable condition for Apple in configure? >>> >>> enable browser_launch >>> if test -n "$sysroot"; then >>> case "$sysroot" in >>> */iPhone*.sdk|\ >>> */AppleTV*.sdk|\ >>> */WatchOS*.sdk|\ >>> */BridgeOS*.sdk) >>> disable browser_launch >>> ;; >>> esac >>> fi >> >> This is not how we normally do it. String matching trying to detect thin= gs >> is generally brittle. If the problem is that we can't compile a call to >> system(), the configure check should try to compile a call to system(), >> and if that doesn't succeed, avoid compiling the code that does that. Th= at >> also works for e.g. ShellExecuteA. > > I'm preparing a patch that aims to limit this to Windows, Linux and Mac > (regardless of API availability) and I'm not sure how to determine whether > mac or the others above in configure. > > Is there a better way? Test compiling code and checking if the expected things are defined. You = can include TargetConditionals.h and check if TARGET_OS_OSX evaluates to = nonzero; that's what we do in code elsewhere anyway - grep for = TARGET_OS_OSX. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".