* [FFmpeg-devel] [PATCH] lavc/sbrdsp: fix inverted boundary check
@ 2024-05-25 17:52 Rémi Denis-Courmont
2024-05-25 17:53 ` Rémi Denis-Courmont
0 siblings, 1 reply; 2+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-25 17:52 UTC (permalink / raw)
To: ffmpeg-devel
128-it is the maximum, not the minimum here. Larger vector sizes can
result in reads past the end of the noise value table.
This partially reverts commit cdcb4b98b7f74d87a6274899ff70724795d551cb.
---
libavcodec/riscv/sbrdsp_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/riscv/sbrdsp_init.c b/libavcodec/riscv/sbrdsp_init.c
index d3bafa961e..6c17b12ae0 100644
--- a/libavcodec/riscv/sbrdsp_init.c
+++ b/libavcodec/riscv/sbrdsp_init.c
@@ -52,7 +52,7 @@ av_cold void ff_sbrdsp_init_riscv(SBRDSPContext *c)
c->sum_square = ff_sbr_sum_square_rvv;
c->hf_gen = ff_sbr_hf_gen_rvv;
c->hf_g_filt = ff_sbr_hf_g_filt_rvv;
- if (ff_rv_vlen_least(128)) {
+ if (ff_get_rv_vlenb() <= 16) {
c->hf_apply_noise[0] = ff_sbr_hf_apply_noise_0_rvv;
c->hf_apply_noise[2] = ff_sbr_hf_apply_noise_2_rvv;
if (flags & AV_CPU_FLAG_RVB_BASIC) {
--
2.45.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] lavc/sbrdsp: fix inverted boundary check
2024-05-25 17:52 [FFmpeg-devel] [PATCH] lavc/sbrdsp: fix inverted boundary check Rémi Denis-Courmont
@ 2024-05-25 17:53 ` Rémi Denis-Courmont
0 siblings, 0 replies; 2+ messages in thread
From: Rémi Denis-Courmont @ 2024-05-25 17:53 UTC (permalink / raw)
To: ffmpeg-devel
Le lauantaina 25. toukokuuta 2024, 20.52.44 EEST Rémi Denis-Courmont a écrit :
> 128-it is the maximum, not the minimum here. Larger vector sizes can
> result in reads past the end of the noise value table.
Nit: bit
>
> This partially reverts commit cdcb4b98b7f74d87a6274899ff70724795d551cb.
> ---
> libavcodec/riscv/sbrdsp_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/riscv/sbrdsp_init.c b/libavcodec/riscv/sbrdsp_init.c
> index d3bafa961e..6c17b12ae0 100644
> --- a/libavcodec/riscv/sbrdsp_init.c
> +++ b/libavcodec/riscv/sbrdsp_init.c
> @@ -52,7 +52,7 @@ av_cold void ff_sbrdsp_init_riscv(SBRDSPContext *c)
> c->sum_square = ff_sbr_sum_square_rvv;
> c->hf_gen = ff_sbr_hf_gen_rvv;
> c->hf_g_filt = ff_sbr_hf_g_filt_rvv;
> - if (ff_rv_vlen_least(128)) {
> + if (ff_get_rv_vlenb() <= 16) {
> c->hf_apply_noise[0] = ff_sbr_hf_apply_noise_0_rvv;
> c->hf_apply_noise[2] = ff_sbr_hf_apply_noise_2_rvv;
> if (flags & AV_CPU_FLAG_RVB_BASIC) {
--
レミ・デニ-クールモン
http://www.remlab.net/
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-25 17:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-25 17:52 [FFmpeg-devel] [PATCH] lavc/sbrdsp: fix inverted boundary check Rémi Denis-Courmont
2024-05-25 17:53 ` Rémi Denis-Courmont
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git