From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8526D4DEB7 for ; Thu, 5 Jun 2025 22:09:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4325168CA72; Fri, 6 Jun 2025 01:09:28 +0300 (EEST) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 387E568B508 for ; Fri, 6 Jun 2025 01:09:21 +0300 (EEST) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2349f096605so17490835ad.3 for ; Thu, 05 Jun 2025 15:09:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1749161359; x=1749766159; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=BNnpfmv1v+QzmiTXIJshCNlVoNxayCEBuKRmZidCGTI=; b=U2oK1jHtA37OeHry5AnZn92Seey6UOrWWxsmp5klwirvx6ndYKMQKZV6KAo+gqnhFB vhyUJJuy6dYRxvOyvRIrBiYJERaTrlgM0K4qhuGaoviaHQUvfUC8Vxo8W5oe3fi01Sjp Nc6JX9E4ZMae2bQjC0ErXDCLR7FUJ6xpwhJzD0vqXPYpbsn4UEtSkvrQowxtgVKIryg7 Cm6ToRdeCaH2a7VMsTFKGFYCKMKr3JpDUAfGXRCeBdmcWo+hnu4kE6xrnJkAIqh6LGGA jr1BmJ7QY0wWAsufQpycS3ScShWTJ/eTms2wAR+ie1V/yX+f9llgcIGO/4YfeCJq7KMO ZPhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749161359; x=1749766159; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BNnpfmv1v+QzmiTXIJshCNlVoNxayCEBuKRmZidCGTI=; b=BUXOg0ctGlx96q2seOJSXsGnoEzm7abzYa9ISy5trmrLFit2ZlzieMbnUm2QsNidy4 CehFJSebyQR32TbTFTvK7rKnrAcezy6bYUCI3hsksyXxJMNHdEvZyhG3+9VeiOqeEQjg qxwr/LLMzfIx/vtcrbWdvR0erP3zMWQNVMPA7caLWo9UbUnZmvhQlMs+NNOYQJgIQCcF nLsqpLk7P6uhoQX5FUIz+31UiWNn6DpHkUcwrlnUTRd3Eki4Vws6hBVWRsnFRuBVy0lq iCafWISRLF7ulWqJvpd6l3vq//jxYFq7V5xZRGY2qDvtdLD0zYrLgvGIDD+W1XhRcIi3 jnBw== X-Gm-Message-State: AOJu0YwqftvO6zhZ6FWc2QP81rUgsU8e74dlrEX5G1afvChtxvLALVg1 28zQ4IeEzK7oGaYBnLtUb8rpPz98lPE0H/imW9VgL9tK/2RkRGWZixqItQsmOg== X-Gm-Gg: ASbGnctYZEeT9GquFYjgn9aMX0UwP6N6t9w494OLjfBjif/0fXJf5z/2OCpVw5IkRaz G9iy1aSv6t6s05B8gHvtiWtE/We7WWWcMzRNZpU9oJgFHE01zeVFsg7K5snD2/cTkeO0vK7XI8y kTd4mrQc1Jr1k2dscRJusnXwu+UsBuCmOKPn24e71kx59xukr8VHm0Bp0blXhScvrbnNcNaPaQO 1ezyDb+Wyo6tebg12jLQO9H2gGq1aElSEcAlNO2xyPfIfOfLPjgDRU83MFC2EbeqE4Z3I+nrKlN sS9e2DhqlKhJMu7HlxwlzTtAdGKmWzi/YrsSpPedvOIIvzsEQmh3OxlIJ60gPO20Gm8fF6cq5qD 5zmmwtceoW2H1uQ== X-Google-Smtp-Source: AGHT+IGNRaz7Hbz66AKB/VarJ6ItxoZ1DaulPpN5AN72ZODrrq0M2nFHGc990Gypj/Sy01b1pTJUNw== X-Received: by 2002:a17:903:234b:b0:235:f078:473e with SMTP id d9443c01a7336-23601de93b7mr14119095ad.43.1749161359232; Thu, 05 Jun 2025 15:09:19 -0700 (PDT) Received: from smtpclient.apple ([47.154.17.136]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23603077eb7sm950865ad.39.2025.06.05.15.09.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Jun 2025 15:09:18 -0700 (PDT) From: Baptiste Coudurier Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\)) Date: Thu, 5 Jun 2025 15:09:08 -0700 References: <20250605214938.142938-1-jamrial@gmail.com> <20250605214938.142938-3-jamrial@gmail.com> To: FFmpeg development discussions and patches In-Reply-To: <20250605214938.142938-3-jamrial@gmail.com> Message-Id: <931E507C-69D4-4DEF-AB35-0B3171D1CB31@gmail.com> X-Mailer: Apple Mail (2.3826.600.51.1.1) Subject: Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: handle EAC-3 extension bits for Atmos X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Cj4gT24gSnVuIDUsIDIwMjUsIGF0IDI6NDnigK9QTSwgSmFtZXMgQWxtZXIgPGphbXJpYWxAZ21h aWwuY29tPiB3cm90ZToKPiAKPiBGcm9tOiBueWFubWlzYWthIDxuc3Q3OTk2MTA4MTBAZ21haWwu Y29tPgo+IAo+IEZpeGVzIGNvbW1pdCAjOTk5Ni4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBKYW1lcyBB bG1lciA8amFtcmlhbEBnbWFpbC5jb20+Cj4gLS0tCj4gbGliYXZmb3JtYXQvbW92ZW5jLmMgfCAz MSArKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tCj4gMSBmaWxlIGNoYW5nZWQsIDE1IGlu c2VydGlvbnMoKyksIDE2IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9saWJhdmZvcm1h dC9tb3ZlbmMuYyBiL2xpYmF2Zm9ybWF0L21vdmVuYy5jCj4gaW5kZXggMjUzNjBiMDA0ZC4uYjU0 NmM4YjU0NSAxMDA2NDQKPiAtLS0gYS9saWJhdmZvcm1hdC9tb3ZlbmMuYwo+ICsrKyBiL2xpYmF2 Zm9ybWF0L21vdmVuYy5jCj4gQEAgLTM5Myw2ICszOTMsMTAgQEAgc3RydWN0IGVhYzNfaW5mbyB7 Cj4gICAgICAgICB1aW50MTZfdCBjaGFuX2xvYzsKPiAgICAgICAgIC8qIGlmIHRoZXJlIGlzIG5v IGRlcGVuZGVudCBzdWJzdHJlYW0sIHRoZW4gb25lIGJpdCByZXNlcnZlZCBpbnN0ZWFkICovCj4g ICAgIH0gc3Vic3RyZWFtWzFdOyAvKiBUT0RPOiBzdXBwb3J0IDggaW5kZXBlbmRlbnQgc3Vic3Ry ZWFtcyAqLwo+ICsgICAgLyogaW5kaWNhdGVzIHRoZSBlbmhhbmNlZCBBQy0zIGV4dGVuc2lvbiwg MSBiaXQgKi8KPiArICAgIHVpbnQ4X3QgZWFjM19leHRlbnNpb25fdHlwZV9hOwo+ICsgICAgLyog aW5kaWNhdGVzIHRoZSBkZWNvZGluZyBjb21wbGV4aXR5LCA4IGJpdHMgKi8KPiArICAgIHVpbnQ4 X3QgY29tcGxleGl0eV9pbmRleF90eXBlX2E7Cj4gfTsKCkkgdGhpbmsgd2Ugb25seSBuZWVkIGNv bXBsZXhpdHlfaW5kZXhfdHlwZV9hLCBpZiBpdOKAmXMgMCBpdOKAmXMgbm90IG5lY2Vzc2FyeQoK PiAKPiBzdGF0aWMgaW50IG1vdl93cml0ZV9hYzNfdGFnKEFWRm9ybWF0Q29udGV4dCAqcywgQVZJ T0NvbnRleHQgKnBiLCBNT1ZUcmFjayAqdHJhY2spCj4gQEAgLTQ3NCw2ICs0NzgsOSBAQCBzdGF0 aWMgaW50IGhhbmRsZV9lYWMzKE1PVk11eENvbnRleHQgKm1vdiwgQVZQYWNrZXQgKnBrdCwgTU9W VHJhY2sgKnRyYWNrKQo+ICAgICBpbmZvLT5kYXRhX3JhdGUgPSBGRk1BWChpbmZvLT5kYXRhX3Jh dGUsIGhkci0+Yml0X3JhdGUgLyAxMDAwKTsKPiAgICAgaW5mby0+YWMzX2JpdF9yYXRlX2NvZGUg PSBGRk1BWChpbmZvLT5hYzNfYml0X3JhdGVfY29kZSwKPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICBoZHItPmFjM19iaXRfcmF0ZV9jb2RlKTsKPiArICAgIGluZm8tPmVhYzNf ZXh0ZW5zaW9uX3R5cGVfYSAgID0gaGRyLT5lYWMzX2V4dGVuc2lvbl90eXBlX2E7Cj4gKyAgICBp bmZvLT5jb21wbGV4aXR5X2luZGV4X3R5cGVfYSA9IGhkci0+Y29tcGxleGl0eV9pbmRleF90eXBl X2E7Cj4gKwo+ICAgICBudW1fYmxvY2tzID0gaGRyLT5udW1fYmxvY2tzOwo+IAo+ICAgICBpZiAo IWluZm8tPmVjM19kb25lKSB7Cj4gQEAgLTUzMiw4ICs1MzksNiBAQCBzdGF0aWMgaW50IGhhbmRs ZV9lYWMzKE1PVk11eENvbnRleHQgKm1vdiwgQVZQYWNrZXQgKnBrdCwgTU9WVHJhY2sgKnRyYWNr KQo+ICAgICAgICAgICAgIGludCBwYXJlbnQgPSBoZHItPnN1YnN0cmVhbWlkOwo+IAo+ICAgICAg ICAgICAgIHdoaWxlIChjdW11bF9zaXplICE9IHBrdC0+c2l6ZSkgewo+IC0gICAgICAgICAgICAg ICAgR2V0Qml0Q29udGV4dCBnYmM7Cj4gLSAgICAgICAgICAgICAgICBpbnQgaTsKPiAgICAgICAg ICAgICAgICAgcmV0ID0gYXZwcml2X2FjM19wYXJzZV9oZWFkZXIoJmhkciwgcGt0LT5kYXRhICsg Y3VtdWxfc2l6ZSwgcGt0LT5zaXplIC0gY3VtdWxfc2l6ZSk7Cj4gICAgICAgICAgICAgICAgIGlm IChyZXQgPCAwKQo+ICAgICAgICAgICAgICAgICAgICAgZ290byBlbmQ7Cj4gQEAgLTU0NCwyMCAr NTQ5LDkgQEAgc3RhdGljIGludCBoYW5kbGVfZWFjMyhNT1ZNdXhDb250ZXh0ICptb3YsIEFWUGFj a2V0ICpwa3QsIE1PVlRyYWNrICp0cmFjaykKPiAgICAgICAgICAgICAgICAgaW5mby0+c3Vic3Ry ZWFtW3BhcmVudF0ubnVtX2RlcF9zdWIrKzsKPiAgICAgICAgICAgICAgICAgcmV0IC89IDg7Cj4g Cj4gLSAgICAgICAgICAgICAgICAvKiBoZWFkZXIgaXMgcGFyc2VkIHVwIHRvIGxmZW9uLCBidXQg Y3VzdG9tIGNoYW5uZWwgbWFwIG1heSBiZSBuZWVkZWQgKi8KPiAtICAgICAgICAgICAgICAgIGlu aXRfZ2V0X2JpdHM4KCZnYmMsIHBrdC0+ZGF0YSArIGN1bXVsX3NpemUgKyByZXQsIHBrdC0+c2l6 ZSAtIGN1bXVsX3NpemUgLSByZXQpOwo+IC0gICAgICAgICAgICAgICAgLyogc2tpcCBic2lkICov Cj4gLSAgICAgICAgICAgICAgICBza2lwX2JpdHMoJmdiYywgNSk7Cj4gLSAgICAgICAgICAgICAg ICAvKiBza2lwIHZvbHVtZSBjb250cm9sIHBhcmFtcyAqLwo+IC0gICAgICAgICAgICAgICAgZm9y IChpID0gMDsgaSA8IChoZHItPmNoYW5uZWxfbW9kZSA/IDEgOiAyKTsgaSsrKSB7Cj4gLSAgICAg ICAgICAgICAgICAgICAgc2tpcF9iaXRzKCZnYmMsIDUpOyAvLyBza2lwIGRpYWxvZyBub3JtYWxp emF0aW9uCj4gLSAgICAgICAgICAgICAgICAgICAgaWYgKGdldF9iaXRzMSgmZ2JjKSkgewo+IC0g ICAgICAgICAgICAgICAgICAgICAgICBza2lwX2JpdHMoJmdiYywgOCk7IC8vIHNraXAgY29tcHJl c3Npb24gZ2FpbiB3b3JkCj4gLSAgICAgICAgICAgICAgICAgICAgfQo+IC0gICAgICAgICAgICAg ICAgfQo+ICAgICAgICAgICAgICAgICAvKiBnZXQgdGhlIGRlcGVuZGVudCBzdHJlYW0gY2hhbm5l bCBtYXAsIGlmIGV4aXN0cyAqLwo+IC0gICAgICAgICAgICAgICAgaWYgKGdldF9iaXRzMSgmZ2Jj KSkKPiAtICAgICAgICAgICAgICAgICAgICBpbmZvLT5zdWJzdHJlYW1bcGFyZW50XS5jaGFuX2xv YyB8PSAoZ2V0X2JpdHMoJmdiYywgMTYpID4+IDUpICYgMHgxZjsKPiArICAgICAgICAgICAgICAg IGlmIChoZHItPmNoYW5uZWxfbWFwX3ByZXNlbnQpCj4gKyAgICAgICAgICAgICAgICAgICAgaW5m by0+c3Vic3RyZWFtW3BhcmVudF0uY2hhbl9sb2MgfD0gKGhkci0+Y2hhbm5lbF9tYXAgPj4gNSkg JiAweDFmOwoKQmVhdXRpZnVsIGNsZWFudXAKCj4gICAgICAgICAgICAgICAgIGVsc2UKPiAgICAg ICAgICAgICAgICAgICAgIGluZm8tPnN1YnN0cmVhbVtwYXJlbnRdLmNoYW5fbG9jIHw9IGhkci0+ Y2hhbm5lbF9tb2RlOwo+ICAgICAgICAgICAgICAgICBjdW11bF9zaXplICs9IGhkci0+ZnJhbWVf c2l6ZTsKPiBAQCAtNjE0LDcgKzYwOCw3IEBAIHN0YXRpYyBpbnQgbW92X3dyaXRlX2VhYzNfdGFn KEFWRm9ybWF0Q29udGV4dCAqcywgQVZJT0NvbnRleHQgKnBiLCBNT1ZUcmFjayAqdHJhCj4gICAg IH0KPiAKPiAgICAgaW5mbyA9IHRyYWNrLT5lYWMzX3ByaXY7Cj4gLSAgICBzaXplID0gMiArICgo MzQgKiAoaW5mby0+bnVtX2luZF9zdWIgKyAxKSArIDcpID4+IDMpOwo+ICsgICAgc2l6ZSA9IDIg KyAoKDMyICogKGluZm8tPm51bV9pbmRfc3ViICsgMSkgKyA3ICsgMSArIDgpID4+IDMpOwoKTGV0 4oCZcyBqdXN0IG1ha2UgaXQgb3B0aW9uYWwgb24gY29tcGxleGl0eV90eXBlX2EKCuKAlCAKQmFw dGlzdGUKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZmZt cGVnLWRldmVsIG1haWxpbmcgbGlzdApmZm1wZWctZGV2ZWxAZmZtcGVnLm9yZwpodHRwczovL2Zm bXBlZy5vcmcvbWFpbG1hbi9saXN0aW5mby9mZm1wZWctZGV2ZWwKClRvIHVuc3Vic2NyaWJlLCB2 aXNpdCBsaW5rIGFib3ZlLCBvciBlbWFpbApmZm1wZWctZGV2ZWwtcmVxdWVzdEBmZm1wZWcub3Jn IHdpdGggc3ViamVjdCAidW5zdWJzY3JpYmUiLgo=