From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A587B4AEE3 for ; Thu, 23 May 2024 08:51:06 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2564168D37E; Thu, 23 May 2024 11:51:04 +0300 (EEST) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 81B5268D13A for ; Thu, 23 May 2024 11:50:57 +0300 (EEST) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1eca195a7c8so117824175ad.2 for ; Thu, 23 May 2024 01:50:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716454255; x=1717059055; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=2PADGmzCHYYzPP2Kwv9ionWo6JCu6zm/811bEisUzdI=; b=i6Fb9EfAUPw82ngi1BLvyEpgwgLckNM3GPshiobJsTnmZKuKuicT7LTqiwuZ8R27s+ Xcy+P+/dIlv+vQL6VI+lKdHJObhxs8DVdwmX1heFFQxoaBJApcef2hrLWdjX4tR+gAEf aff7ln53S9OfnSEtbXulf1hcHn9OrO9fGiAu6gl0ABQfu+0JA8mOvAWs0PIA/IZayADR lvAvHETeKzc+eJSG6sLdAQOPrsifhJykXpyby96533Q9ilVwxPvJp2ednR/hPMnaoNBO 3JxVpqrEd2M940V4e80AMfeAUs6lUIYl33wj6+UfEASKc0fOdQD09+gvKgNOu4xdWjFc 8Tvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716454255; x=1717059055; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=2PADGmzCHYYzPP2Kwv9ionWo6JCu6zm/811bEisUzdI=; b=QnOp6tHTu9VNwSnmjd9VgJ3dgNHPrAFkRAbg3M6//FvuWTpG6+cXVyJ5PHqy/Brs8o QmmH+uSONvfhzxqs57soPzcZjX9LOEd1vAXcy8eHHUe74ThvM/+GfFNYxQMI2I1l5L7p strGtM7ghTMnAO0GZw5QyDzUIMVgIRH/k9neXWM6uBjCu3+qSy1hKrvx7QzTL/0asfGD Epx8XjNmsmZ7QOzdfbkTunMabdf40XWHBvnmkjM+4AdPLC2pFy+lXX9kidJVdSe1XWwr 9hJHZJEP8kkXpBPpoZ6VH89Fl59FP9gUPEbjyjvPp7DKAx2HWRQ9znqNi1c7as8HtFwK ZvZA== X-Gm-Message-State: AOJu0YyvH0VrKz5G6aO+rNDQxV4rzgiS2S7R1K6TyKvUX24sC1tevl5e OiyBTboAb4mwRwTYzQD5WpB1j3f+e9zdmWS1tyW7xriGOpENhHRh1Myg/Q== X-Google-Smtp-Source: AGHT+IEq6dd+tDi8LQ7G0QlqtVIpjU2tc23iwdH3swrzMRse+XDIrpeX1FqtGHicHGKgWMDEdkSLSA== X-Received: by 2002:a17:902:f813:b0:1f3:134:533a with SMTP id d9443c01a7336-1f31c97bb7fmr40075845ad.28.1716454254713; Thu, 23 May 2024 01:50:54 -0700 (PDT) Received: from [192.168.1.107] ([103.208.20.250]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f3326428b4sm14897665ad.19.2024.05.23.01.50.53 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 May 2024 01:50:54 -0700 (PDT) Message-ID: <930d208d-8425-45d2-aad3-0b35224d14fe@gmail.com> Date: Thu, 23 May 2024 14:20:50 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240523083750.1332-2-llyyr.public@gmail.com> From: llyyr In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH v2] lavc/vp9: reset segmentation fields when segmentation isn't enabled X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 5/23/24 2:13 PM, Andreas Rheinhardt wrote: > llyyr.public@gmail.com: >> From: llyyr >> >> Fields under the segmentation switch are never reset on a new frame, and >> retain the value from the previous frame. This bugs out a bunch of >> hwaccel drivers when segmentation is disabled but update_map isn't >> reset because they don't ignore values behind switches. This commit also >> resets the temporal field, though it may not be required. >> >> We also do this for vp8 [1] so this commit is just mirroring the vp8 >> logic. >> >> This fixes an issue with certain samples [2] that causes blocky >> artifacts with vaapi, d3d11va and cuda (and possibly others). >> Mesa worked around [3] this by ignoring these fields if >> segmentation.enabled is 0, but d3d11va still displays blocky artifacts. >> >> [1] https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/HEAD:/libavcodec/vp8.c#l811 > > You should probably not link to HEAD here, because the line number will > be wrong in the future. > Should I resent the patch with a v3 or could whoever applies the patch fix it when applying it? The correct url is https://git.ffmpeg.org/gitweb/ffmpeg.git/blob/2e877090f958131accb8c7e5ac10e5b9865d1735:/libavcodec/vp8.c#l797 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".