From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E319D4B45C for ; Wed, 5 Jun 2024 20:12:01 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id E98B668D4EF; Wed, 5 Jun 2024 23:11:59 +0300 (EEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BC46868D4EF for ; Wed, 5 Jun 2024 23:11:53 +0300 (EEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1f6342c5fa8so2447795ad.1 for ; Wed, 05 Jun 2024 13:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1717618311; x=1718223111; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=paz8cVo9qvz5MgoeweqEreJlnukpv4bxdydEgmBsc1Y=; b=YFGhUm3Skaq3LF8CkQyFlVlEN65pvA2iCL2qViJqZMd/ffCDClKrxef1mxfhzDaZoa 9kisl5mxcSKQHb5qbm3x5MwO/XJcyFiVGUB44odmjTEFM4SDfVnI5NQ4a8JiAspTWGgN Nv4JUdv960OnZ4b1SZ12YwFYFzJThTdQy+y4RokFKwYX5jtxRFTNst2zP93NVPmur7Sv 4qvgLG5BhbeYbuUjZTvXxNlebBzDYHGK8WcWfDf/f+RL+n5FL8gXpLQCkTxEJaAz7rEv ue11Dgn2b1GO/3diQhYWukIbNmYCK18nsnnAMdCtx142+Or1H7V/bAFiOqEE4kLhktP4 jENg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717618311; x=1718223111; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=paz8cVo9qvz5MgoeweqEreJlnukpv4bxdydEgmBsc1Y=; b=ZuMXQXGj5Qj44Nrb14vXS4eB88EuRpynYSDYW9xmo86+tHuEdogZc55vbkyW59Q388 N2wbeUkdspAV9DR9gjCfUkDWgUOGsq/kSF1QWytbgK89vE9QntxZdUQ3pVdOF647kIlw g9iQAwka4Qkma1RglaG5skQd8c8o1273fniDvseqTXXJ+EboKsBhSYK8H+Tw6Qy8jRM5 4jRBg2ql8h44b3HMhJiii6klq/Pv+vDMI5e1cA5pCS/fFFgeZlGYG1q5CQg+3b5Gb7+7 xrwX3lUxj8PgAnURDRCLu51yKu3c9xFvw240fDwkb5eDXhRAG7FrZtANAo8J13NdfCDw vajA== X-Gm-Message-State: AOJu0Yzj7iEwPg0ZPH4Vx1RddwJwQNy0BJuwxRJyY3FH0zWt1fHodwrm FZzyZhBA9Zcc26ZZlV9C8MnO22eR87yxPRAbN7mM9T3QnSm2E9CsF+z7XA== X-Google-Smtp-Source: AGHT+IGnUVDwf2Xv5v5WJgSw15HYFlOuP3yRba//99BoRpp1UH2z3m9p9IYD/4M3GPTy//1wvNLEAA== X-Received: by 2002:a17:903:1105:b0:1f6:3750:5258 with SMTP id d9443c01a7336-1f6a5a6a6d0mr46978705ad.43.1717618310662; Wed, 05 Jun 2024 13:11:50 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f63232dde8sm109261765ad.1.2024.06.05.13.11.49 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 05 Jun 2024 13:11:50 -0700 (PDT) Message-ID: <92ec133b-2db6-47cf-bab4-f0700b12358b@gmail.com> Date: Wed, 5 Jun 2024 17:12:01 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: Content-Language: en-US From: James Almer In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] tests/checkasm/sw_rgb: Be more strict about clobbering MMX state X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/5/2024 5:08 PM, Andreas Rheinhardt wrote: > The MMXEXT versions of the rgb2rgb functions tested here > always emit emms on their own. Therefore one can use > a stricter test to ensure that it stays that way. Or we could nuke it in favor of an SSE2 version :p > > Signed-off-by: Andreas Rheinhardt > --- > tests/checkasm/sw_rgb.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c > index b51d0836c3..47c3cdfcc8 100644 > --- a/tests/checkasm/sw_rgb.c > +++ b/tests/checkasm/sw_rgb.c > @@ -53,7 +53,7 @@ static void check_shuffle_bytes(void * func, const char * report) > LOCAL_ALIGNED_32(uint8_t, dst0, [MAX_STRIDE]); > LOCAL_ALIGNED_32(uint8_t, dst1, [MAX_STRIDE]); > > - declare_func_emms(AV_CPU_FLAG_MMX, void, const uint8_t *src, uint8_t *dst, int src_size); > + declare_func(void, const uint8_t *src, uint8_t *dst, int src_size); > > memset(dst0, 0, MAX_STRIDE); > memset(dst1, 0, MAX_STRIDE); > @@ -84,9 +84,9 @@ static void check_uyvy_to_422p(void) > LOCAL_ALIGNED_32(uint8_t, dst_v_0, [(MAX_STRIDE/2) * MAX_HEIGHT]); > LOCAL_ALIGNED_32(uint8_t, dst_v_1, [(MAX_STRIDE/2) * MAX_HEIGHT]); > > - declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *ydst, uint8_t *udst, uint8_t *vdst, > - const uint8_t *src, int width, int height, > - int lumStride, int chromStride, int srcStride); > + declare_func(void, uint8_t *ydst, uint8_t *udst, uint8_t *vdst, > + const uint8_t *src, int width, int height, > + int lumStride, int chromStride, int srcStride); > > randomize_buffers(src0, MAX_STRIDE * MAX_HEIGHT * 2); > memcpy(src1, src0, MAX_STRIDE * MAX_HEIGHT * 2); > @@ -127,8 +127,8 @@ static void check_interleave_bytes(void) > uint8_t *dst0 = dst0_buf + 2; > uint8_t *dst1 = dst1_buf + 2; > > - declare_func_emms(AV_CPU_FLAG_MMX, void, const uint8_t *, const uint8_t *, > - uint8_t *, int, int, int, int, int); > + declare_func(void, const uint8_t *, const uint8_t *, > + uint8_t *, int, int, int, int, int); > > randomize_buffers(src0, MAX_STRIDE * MAX_HEIGHT); > randomize_buffers(src1, MAX_STRIDE * MAX_HEIGHT); _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".