On 10/03/2023 22:10, Marton Balint wrote:
>
>
> On Mon, 6 Mar 2023, Nicolas Gaullier wrote:
>
> [...]
>>
>> Some weeks later now and no replies, maybe time to go on ?
>> I think the "case AV_CODEC_ID_DVVIDEO:" can be removed as discussed, 
>> fate updated and that should be ok for everybody.
>> (Ideally, it could have been an opportunity to document why we have 
>> this "DV exception", but I understand it is not very comfortable to 
>> write as there is no meaningful reason, so forget about this, this 
>> won't hold up the patch anyway)
>> For information, there was a long thread recently on ffmpeg-user 
>> about a "bug" in dnxhd stored_height (will be fixed with your patch):
>> https://ffmpeg.org/pipermail/ffmpeg-user/2023-February/056111.html
>
> Will apply the patch in a couple of days unless somebody objects. If 
> you want to change DV height (seems reasonable), please send a follow 
> up patch with fate updates after that.


Apologizes for the huge delay.
Attached is an updated patch.

I changed the DV part (also removed from the 16x16 macroblock thing)
I added some comments about specs (summary: DNxHD is explicit, others 
are not but implementation I know don't do the 16x16 macroblock thing).
The FATE tests for DV are not impacted because they are SD and SD 
width/height are multiple of 16 so I added a DV100 test.

Jérôme