[FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

[FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

[Gavin Smith]

Some NLVEs may insert a KLV packet for EIA-608 data even though
the number of encapsulated ANC packets is zero.
---
 libavformat/mxfdec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
index 400941c348..f3d2cf4efa 100644
--- a/libavformat/mxfdec.c
+++ b/libavformat/mxfdec.c
@@ -509,7 +509,7 @@ static int mxf_get_eia608_packet(AVFormatContext *s, AVStream *st, AVPacket *pkt
     int did, sdid, data_length;
     int i, ret;
 
-    if (count != 1)
+    if (count > 1)
         av_log(s, AV_LOG_WARNING, "unsupported multiple ANC packets (%d) per KLV packet\n", count);
 
     for (i = 0; i < count; i++) {
-- 
2.34.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

[Tomas Härdin]

fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith:
> Some NLVEs may insert a KLV packet for EIA-608 data even though
> the number of encapsulated ANC packets is zero.
> ---
>  libavformat/mxfdec.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Looks OK. Also I'm looking at maybe adding S436m support to mxfenc, but
it's going to require a bit of plumbing in ffmpeg.c I think.

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

[Gavin Smith]

On 06/08/2022 21:44, Tomas Härdin wrote:
> fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith:
>> Some NLVEs may insert a KLV packet for EIA-608 data even though
>> the number of encapsulated ANC packets is zero.
>> ---
>>   libavformat/mxfdec.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
> Looks OK. Also I'm looking at maybe adding S436m support to mxfenc, but
> it's going to require a bit of plumbing in ffmpeg.c I think.
>
> /Tomas

Can this be merged since there have been no objections?
Gavin.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

[Tomas Härdin]

ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith:
> 
> On 06/08/2022 21:44, Tomas Härdin wrote:
> > fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith:
> > > Some NLVEs may insert a KLV packet for EIA-608 data even though
> > > the number of encapsulated ANC packets is zero.
> > > ---
> > >   libavformat/mxfdec.c | 2 +-
> > >   1 file changed, 1 insertion(+), 1 deletion(-)
> > Looks OK. Also I'm looking at maybe adding S436m support to mxfenc,
> > but
> > it's going to require a bit of plumbing in ffmpeg.c I think.
> > 
> > /Tomas
> 
> Can this be merged since there have been no objections?

Probably but I'm recovering from surgery, so some time next week for me
unless someone else feels like pushing. I see there are other MXF
patches too that I don't have the energy to deal with at the moment

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

[Gavin Smith]

On 09/09/2022 10:45, Tomas Härdin wrote:
> ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith:
>> On 06/08/2022 21:44, Tomas Härdin wrote:
>>> fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith:
>>>> Some NLVEs may insert a KLV packet for EIA-608 data even though
>>>> the number of encapsulated ANC packets is zero.
>>>> ---
>>>>    libavformat/mxfdec.c | 2 +-
>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>> Looks OK. Also I'm looking at maybe adding S436m support to mxfenc,
>>> but
>>> it's going to require a bit of plumbing in ffmpeg.c I think.
>>>
>>> /Tomas
>> Can this be merged since there have been no objections?
> Probably but I'm recovering from surgery, so some time next week for me
> unless someone else feels like pushing. I see there are other MXF
> patches too that I don't have the energy to deal with at the moment
>
> /Tomas


Thanks for the update. I wish you a speedy recovery.
Gavin.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

[Gavin Smith]

On 09/09/2022 16:33, Gavin Smith wrote:
>
> On 09/09/2022 10:45, Tomas Härdin wrote:
>> ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith:
>>> On 06/08/2022 21:44, Tomas Härdin wrote:
>>>> fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith:
>>>>> Some NLVEs may insert a KLV packet for EIA-608 data even though
>>>>> the number of encapsulated ANC packets is zero.
>>>>> ---
>>>>>    libavformat/mxfdec.c | 2 +-
>>>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>> Looks OK. Also I'm looking at maybe adding S436m support to mxfenc,
>>>> but
>>>> it's going to require a bit of plumbing in ffmpeg.c I think.
>>>>
>>>> /Tomas
>>> Can this be merged since there have been no objections?
>> Probably but I'm recovering from surgery, so some time next week for me
>> unless someone else feels like pushing. I see there are other MXF
>> patches too that I don't have the energy to deal with at the moment
>>
>> /Tomas
>
>
> Thanks for the update. I wish you a speedy recovery.
> Gavin.



Any update on this? Thanks. Gavin.

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not log warning of multiple ANC packets if count is 0

[Tomas Härdin]

ons 2022-10-05 klockan 17:12 +0100 skrev Gavin Smith:
> On 09/09/2022 16:33, Gavin Smith wrote:
> > 
> > On 09/09/2022 10:45, Tomas Härdin wrote:
> > > ons 2022-09-07 klockan 15:28 +0100 skrev Gavin Smith:
> > > > On 06/08/2022 21:44, Tomas Härdin wrote:
> > > > > fre 2022-08-05 klockan 00:03 +0100 skrev Gavin Smith:
> > > > > > Some NLVEs may insert a KLV packet for EIA-608 data even
> > > > > > though
> > > > > > the number of encapsulated ANC packets is zero.
> > > > > > ---
> > > > > >    libavformat/mxfdec.c | 2 +-
> > > > > >    1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > Looks OK. Also I'm looking at maybe adding S436m support to
> > > > > mxfenc,
> > > > > but
> > > > > it's going to require a bit of plumbing in ffmpeg.c I think.
> > > > > 
> > > > > /Tomas
> > > > Can this be merged since there have been no objections?
> > > Probably but I'm recovering from surgery, so some time next week
> > > for me
> > > unless someone else feels like pushing. I see there are other MXF
> > > patches too that I don't have the energy to deal with at the
> > > moment
> > > 
> > > /Tomas
> > 
> > 
> > Thanks for the update. I wish you a speedy recovery.
> > Gavin.
> 
> 
> 
> Any update on this? Thanks. Gavin.

Pushed. Sorry for the delay

/Tomas

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".