From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B86E24A3C6 for ; Wed, 27 Mar 2024 12:46:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3A12868D668; Wed, 27 Mar 2024 14:46:50 +0200 (EET) Received: from EUR01-DB5-obe.outbound.protection.outlook.com (mail-db5eur01on2135.outbound.protection.outlook.com [40.107.15.135]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C644368CD83 for ; Wed, 27 Mar 2024 14:46:43 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NYUV7NtI0f9ZA+hQMhUb4MwPdMh5k5bpzCdpszfsOspOv8WSp3/TW/Pu2j7qYezk51FZBu0yjlmy5+eAGmIJJ3NUcq9oEzIwTiuwj2uIS28j5L5Uvi4u/u+a4qesb/JOD4gNFWQ2gGfo4U8wM5EXiAWLz2IaUG1o3+x6jKAqN3TN/46gycyksA1RjaO2C1CiogMGVZJpAfXN3r+ZZyddlzAYgIcWKZNotwo+VDiRIXkrZBSAuN0JJOCgfFEBQ1WpasyNJ3/v3jYEYf7YqjzesEgn289wXnif/4x3rSkzAUQyLJAAyY3kmV+Q0+mMtbLW7jsXieIFFs1yUBpla+mqMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=H6UC91RlUaGnOM3o3V/w52pCQvQURDvnliHDw5tCKLk=; b=Ks/N048V0zFASa580mSoNcWmt1tSIJv5yTjPW2tOXUQ6k783CVqMQj1tj4h4Lkp2y1kHakJT7mRzSZPPgYTyY8ReSQGBDD3zImJtCSaKJR8+2ZJzFWGJjwHUJO/2XRR/GGhzqw7pQKHuO1fe1LzQCngD+KFkmSO5ig3TO2LxBtk0oPGCZbK9M3DRsDGcQxzcsPDW2GKloonMfvs3v6naIGsK2EczGgY25tKITosk4YiLYCjOl7SK4R3GStgJQtjOjsUumcupOkdnzNbCmAQFWP/R6fYsq5RqSTK//X9nqAJtgDEPQO7g0OYjX4JpqL7EfGgrdnARW8WmuSRRh5fSbg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=noa-archive.com; dmarc=pass action=none header.from=noa-archive.com; dkim=pass header.d=noa-archive.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=noa-archive.com; Received: from DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) by AM7PR09MB4006.eurprd09.prod.outlook.com (2603:10a6:20b:120::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.32; Wed, 27 Mar 2024 12:46:42 +0000 Received: from DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::2a3e:8641:1f40:c79]) by DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::2a3e:8641:1f40:c79%5]) with mapi id 15.20.7409.031; Wed, 27 Mar 2024 12:46:41 +0000 Message-ID: <91da0313-e4c4-46e7-9379-30306ee3f0ca@noa-archive.com> Date: Wed, 27 Mar 2024 13:46:40 +0100 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <1711536691-15749-1-git-send-email-t.rapp@noa-archive.com> <1711536691-15749-2-git-send-email-t.rapp@noa-archive.com> Content-Language: en-US From: Tobias Rapp Organization: NOA GmbH In-Reply-To: X-ClientProxiedBy: FR3P281CA0066.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:4b::17) To DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB4PR09MB5847:EE_|AM7PR09MB4006:EE_ X-MS-Office365-Filtering-Correlation-Id: 3770f7ed-fc9a-46c9-6d06-08dc4e5bf3a2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: a4A5OXqS1oB/5fcJTQcOhDk6lwcFPTpHCQMd1jVAIZYWDytkD35uzYIAnCyDLN2NGa7o980okwW0m4zmrKbHOTtQVxxs7YzhQvXs4rGfs1BGo6vruhPL992UcP8JkbLTZEdmn0FCFPqikI16o83yIwtlfV3gePig0ur+opzUNLFHhIncuvYR+46rCqNIQuRIiBnZbSDD/Ci2cB4k2zDggkXP63ncGftVLyE79quURSsNPAq+lUr8AXbeEwaa6KREIXqeZ3Cwg3PT2tjXYRqpsxV8wDY0KmUpa1dV4IoRIyWIO2sD15/zYH6eXYJfkJkca6ZIHRtTEsfeNN2FujeHNQxRZZ47jRJgt/y5UCLzpnrzrvBEtanER5GQx3gyiRk4QOcMtOqYVdnimL2LyeodpberdVFTxbboNp6NSd1Q7+HRnZSrgN2mrUjk9dHhsEdj+WP5t+MIWgGffYfwXGUhVRFnwK0huVbf5vrYLNkiiTKK9Z8rROAXCiAGGksQnpINhLbao5CiNeY7vu840HIBUm1tuNANpXHWcuNfSuh2wClWFIE/mk0nyNJYfGXxPWaQ3X+z48u7W7zbIKea8yqDni9YCplO50FOy3D8ZqOMkgTKgkHbiyM5eLB+KaERUn1PUH8QZfK3U0d2obATSBNDgrn0ilyHLTm9NraWB1hsP5s= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR09MB5847.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(366007)(1800799015)(376005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZS8xU3RMUVFYdDB1NVk2Y2RBb01mNmowMTJNMlBTb0JiR0F1MnJzcnBMNWl1?= =?utf-8?B?cHg4YkowRnpvbmRIK2h2T1V4TFZZRXFoZHpQSEJkTkhySC9YNFZFNjRHaGps?= =?utf-8?B?c2RWd0J3dmp0NWI5WHZweGh0cHlZcWxmVFlDcTFKTUdKcnpsdVJyaE1ONm9o?= =?utf-8?B?U21VK0JLVUN2T1VLMTNBSXNWbHRrRU9iZlVLQ2lscmhudmUvWVBPNWNkaDlx?= =?utf-8?B?U00zakdMT1ppcTE4by9PV2YyOWc2T3dlbjZuOGMxa2tqb09ESU52RnNsUXVl?= =?utf-8?B?cUs0UEQxSEZCYmk2aUJXaVNLd3NNdnBTd1dkVittSTMzUzBJbUF3VUx4Wms3?= =?utf-8?B?M2s1VDRTS2hmYjdveDdrcHltTDBUNFBETEx3REhKZGhwTEthckVFZHp2K252?= =?utf-8?B?SUpiSlVTcXZkNW9kWjRzNDRFeEtIYkt1U0VEQnE3a3VmV1Y5cXdYVVczRWpj?= =?utf-8?B?NmpPOVNqdjU3WXVGOWloN3FDT0pIT3hrZ2oxc09VQnY2UW9WQ1pROUxnamh2?= =?utf-8?B?ckpzZnpObFRoV1V4WEUxcnFPQXFhMURjMlFSZC9aRk5iOVkwZnBYZXNCcS9u?= =?utf-8?B?Tk5OY2gxWk9zTUFZd0xEb2lkUmdVL1ZsZ2FnVlRLcm1rRER1NTRsZ2REU2hH?= =?utf-8?B?WWthRTZpczdYWTUvRXZZMGNWenJ4UU8rTFVmYXo4ODhOdkpYMWQvQ3JheGp3?= =?utf-8?B?QWxhSGNJZWZIazJDeUFaVVU0MUh0Y1dEcis4aGhBalA1ajF2SnR4Qk91RWo3?= =?utf-8?B?YUozYSsxQWczYkVOUXJJMWxDME5FTDQySGo1Zy80WTZ2T3k1dW5Mdy85dVhB?= =?utf-8?B?NHBvYXYzc0tDN3d6aWhOYWpXTlZpVEdGN0JhRlNKYUgzSG9EMlZQWEdZeDll?= =?utf-8?B?eHMwNnFuNFFqSnBVOWZUeFlTbzJzb2p6MnZPbkdGUXo0RFpGcDdPNWl4TWNZ?= =?utf-8?B?NFVobk9pemFDdkF3c3kzTnhzZkhKeGtiVExTKzVFcFhURjZ2djM1UEZaaU1J?= =?utf-8?B?SExPUnl4blM0S2tyMWZtV0VwK2QyNnJqelByemtENlF0Q3lxa0JaS1R0UjVq?= =?utf-8?B?OW12RXB1N0t3SEtxL2FYVFQrTFozWTlOdzhIbmRyOEdPTkVvMDViSjlRcEtT?= =?utf-8?B?YzNRcU1yVThCYTJuOFJtbzlFL3QvUTlFWU1LeDgyQm5tN0xnbW1vaDJDRytv?= =?utf-8?B?MFVzUE00VzBSczZxdVlDZDFrdnRhWUgyRkRhOWZsQ0Q1bHJCcEdkb1dRZlhC?= =?utf-8?B?bEhMWDZLV0Y5b2RESFNBT3B6S1hhY1hVZ0QzM1dPV0dMVDhZcGdEeWQ4YVpq?= =?utf-8?B?MzBnei9OUXJCTFFtR1cxb3lVT0FNdlpLR2NyWXcrWGJ3bnBmMkZHWUtaVXhz?= =?utf-8?B?Q3hNNFUvS2VCbm9lem5lelIvVitMOWliK2pqUGgyUFJ0SDdHWlY5U21aSXA0?= =?utf-8?B?RGw0ZG5hOFVLYnE3ajE4Q2VKd0dTNmVBNEVUZGp6ZWlmelE5a3Y1UFhUZS9X?= =?utf-8?B?REw0elJRU3BrMlZ1M1FWdUJrLzNzdXArdXE4UXpRLzBYeHpjUm0vRFU0R1lD?= =?utf-8?B?VDRNQkxlTERkWlZ3R1UvbVhudG11SDRCUzdhUG5SdjNUUjZ6ZXJ5Z2o3Qy9y?= =?utf-8?B?MFFDaUZrcUNLZ2QzUCtESkg4ODlncGNmbWZFdDA4TFQxSXpDNEhhNFhxTFoz?= =?utf-8?B?bGcyU1pVaGNxYzlaazZ1NUtMWEcrTmNlYUYvNGN2SG9uWG03eVc4Q09aOEc3?= =?utf-8?B?RTZBR2JjaUs4Q1BHNnNKaldRREdJbUZqbEJqaXRKYnFkZWxPMHpRREYzVk1H?= =?utf-8?B?L2I5ZGJMUUVTYTVOdmJjRm1zVkpoQzZRNlZ2L010VmtnaVJMdm9NcXZqdHov?= =?utf-8?B?aFMwem9ubzNjT2xocllnQ0MrNXdraFR2NVd3UXhkVmpMRHBWOEZyQzNwWDEy?= =?utf-8?B?bGRjWGRRM2NQUUdwZm9sSm5VYlppaFVSVi9xSm9GVmtBTTVFcnRPMFZlSEtQ?= =?utf-8?B?V2IvVWFQOVVqMkJmMUZLZUVLcDVkc2QwcmphRkc0dkwxekxpTFlhLytqbXA1?= =?utf-8?B?MkgrTWtoYSs2QUthWjNSWXdhMVhYbmVVVXVCTE9ZMitPSTRLRnltd1ZibE5p?= =?utf-8?B?d2hXUGlMSkl5WHgvLzc2Y1ZaMVc5WERzSWxVN0IvQ0k5dHZnMTVRWmxEU1Jy?= =?utf-8?B?MGc9PQ==?= X-OriginatorOrg: noa-archive.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3770f7ed-fc9a-46c9-6d06-08dc4e5bf3a2 X-MS-Exchange-CrossTenant-AuthSource: DB4PR09MB5847.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 27 Mar 2024 12:46:41.7440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a676c8d7-7f39-4c99-a306-48abb76a98e9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Tpj1N3J1RK4UTxhUJe9lIoMTX7U5Aq4po66wD+PwamR0HTz59B1LB4acqXJbiXFv//rDqJKHbUGtBnPhkZEKog== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR09MB4006 Subject: Re: [FFmpeg-devel] [PATCH 2/2] examples/decode_filter_video: Add loop for draining the filtergraph X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 27/03/2024 13:06, Stefano Sabatini wrote: > On date Wednesday 2024-03-27 11:51:31 +0100, Tobias Rapp wrote: >> Depending on the filters used the filtergraph can produce trailing data >> after feeding it the last input frame. Update the example to include the >> necessary loop for draining the filtergrap. >> >> Signed-off-by: Tobias Rapp >> --- >> doc/examples/decode_filter_video.c | 19 +++++++++++++++++++ >> 1 file changed, 19 insertions(+) >> >> diff --git a/doc/examples/decode_filter_video.c b/doc/examples/decode_filter_video.c >> index 454c192..a57e6df 100644 >> --- a/doc/examples/decode_filter_video.c >> +++ b/doc/examples/decode_filter_video.c >> @@ -276,6 +276,25 @@ int main(int argc, char **argv) >> } >> av_packet_unref(packet); >> } >> + if (ret == AVERROR_EOF) { >> + /* signal EOF to the filtergraph */ >> + if (av_buffersrc_add_frame_flags(buffersrc_ctx, NULL, 0) < 0) { >> + av_log(NULL, AV_LOG_ERROR, "Error while closing the filtergraph\n"); >> + goto end; >> + } >> + >> + /* pull remaining frames from the filtergraph */ >> + while (1) { >> + ret = av_buffersink_get_frame(buffersink_ctx, filt_frame); >> + if (ret == AVERROR(EAGAIN) || ret == AVERROR_EOF) >> + break; > how are we supposed to handle the EAGAIN case? Shouldn't this be a > sleep and retry? Good suggestion. I could add something like usleep(100) upon EAGAIN. Will post an updated patch. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".