From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7D3A1499EF for ; Mon, 26 Feb 2024 00:40:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 53CE468C769; Mon, 26 Feb 2024 02:40:16 +0200 (EET) Received: from iq.passwd.hu (iq.passwd.hu [217.27.212.140]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 96DE868AA84 for ; Mon, 26 Feb 2024 02:40:10 +0200 (EET) Received: from localhost (localhost [127.0.0.1]) by iq.passwd.hu (Postfix) with ESMTP id 3B12FEA079 for ; Mon, 26 Feb 2024 01:40:10 +0100 (CET) X-Virus-Scanned: amavisd-new at passwd.hu Received: from iq.passwd.hu ([127.0.0.1]) by localhost (iq.passwd.hu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id t4Ui-_S3TUgi for ; Mon, 26 Feb 2024 01:40:05 +0100 (CET) Received: from iq (iq [217.27.212.140]) by iq.passwd.hu (Postfix) with ESMTPS id AC8D6EA078 for ; Mon, 26 Feb 2024 01:40:04 +0100 (CET) Date: Mon, 26 Feb 2024 01:40:04 +0100 (CET) From: Marton Balint To: FFmpeg development discussions and patches In-Reply-To: <20240225184350.GO6420@pb2> Message-ID: <91c85dcc-4b79-753d-7518-8a1588e08f88@passwd.hu> References: <6374b936-e240-12fb-ec44-72d60656a893@passwd.hu> <20240225184350.GO6420@pb2> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] Swresample strangeness X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 25 Feb 2024, Michael Niedermayer wrote: > On Sun, Feb 25, 2024 at 05:38:27PM +0100, Marton Balint wrote: >> Hi, >> >> I am working on a patch to select a better default packet size for the wav >> demuxer, since it reads at most 4096 bytes which can cause insanely small >> packets for files with high channel count. >> >> Unfortunately some swresample fate tests blew up, and I wonder if the result >> of the resampling should be dependant on size of the audio chunks which are >> being fed to it. My assumption is that if it causes audible difference in >> the output, then it is likely a bug in swresample, but I am not familiar >> with its code and its many tunable variables, so if someone could confirm, >> (or even better, fix it :)) that would be great. > > From what you describe, the first thing that comes to mind are timestamps. > If you resample with timestamps that mismatch the exact values expected from > the sample rate. You will have different resuls when the packet size is changed. > Its the same data but at a different point in time and thats different then. > > I have too many things to do though so i cant really look into this. Ok, thanks anyway. For the async tests the timestamps were randomly generated, and that changed. For other tests however I am quite sure about the swresample bug, so I will send a patch soon to fix that. Regards, Marton _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".