Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Rémi Denis-Courmont" <remi@remlab.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 1/5] lavc/vp9dsp: R-V V mc avg
Date: Tue, 21 May 2024 18:55:41 +0300
Message-ID: <9179490.uTkFbkzr3S@basile.remlab.net> (raw)
In-Reply-To: <CAEa-L+vTgnhw-2A9ht=A+chvJRBHWaOu4o_B8JBBbuWZEg9qMw@mail.gmail.com>

Le tiistaina 21. toukokuuta 2024, 18.36.02 EEST flow gg a écrit :
> > Please put commas between operands.
> 
> Okay
> 
> > This should probably be ff_avg_vp9 or something slightly more specific.
> 
> Is it necessary here?

It works because VP9 is the odd one out doing this. All non-static symbols in 
libavcodec are in the same namespace.

> Many macros in the C file are copied from MIPS, where
> it is called ff_avg4_msa. Here, it has been simply changed to ff_avg4_rvv.

AArch64 uses ff_vp9_avg which seems a lot saner.


-- 
Rémi Denis-Courmont
http://www.remlab.net/



_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2024-05-21 15:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-18 18:15 uk7b
2024-05-18 18:16 ` flow gg
2024-05-21 15:23 ` Rémi Denis-Courmont
2024-05-21 15:36   ` flow gg
2024-05-21 15:55     ` Rémi Denis-Courmont [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9179490.uTkFbkzr3S@basile.remlab.net \
    --to=remi@remlab.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git