From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6146642454 for ; Wed, 18 Jan 2023 08:51:41 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B286E68BEB4; Wed, 18 Jan 2023 10:51:37 +0200 (EET) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-vi1eur04on2122.outbound.protection.outlook.com [40.107.8.122]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2C4A268BE80 for ; Wed, 18 Jan 2023 10:51:31 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YYg4a0TCipFDPb6W2L5urkoYo9WQsN5xNJ1zwFn+K9g6Lj+q1Cxg1A38CEPrJ16QvPdoWmx+TxSIde8AZ/2lHlhRtV9r14s+Qy2iF+N9v6m2UNv5nbYdfK60oTogentHm4yJUSK1TlVUBRY3zIZd0Jh1soI6dbSJcsXpfa6JXt3WGYUgplM9QUcoc9u33Ro9AvvqXd9OfSXsOryEUo7xlkIeIQ45tK4d+bHlsFsek8Nxafmta1VAOlAiEq/ahuSJJ0x2ktu9W+8SFjKWBCwUgh3aqvkxrAe0GQu23MvKFhcQFHItxCXg0epO/NhnyNuN24hpTwsBi6pnF/INbyjqGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CPTUkCxnZTZk7jNj8yQqnCv83JUdj4Ll0A3tdI2EuvQ=; b=SaaTSHyJckpy2Ww/cPgJvvdpQ+Ak2U+22z88MTjC/Hx9MPDBynRSlXjzJy9ZP7+4DQ48JCCHzalFJkfI+kGTGJSvJJoIFRSM64kVogX6ebMwtt+i4xnBQ5M/bsRTPo7WB2AWdUMeOgkM3lASPs80aiZkxuGasYjDePS4QbY6d0bMkM+BxY+HGUKv9auP6k89iFQsAzOl8EucFADdKlPLYsISQTTE9OaQE+hjZw+FP5QvGoSkMLI7ORwvU3MmzUYzp3HvgbWuJo6r+y+bOS6tk/gPnExZExC1bh6D3tJhw7UA16MM2teepRjOhCxZ4eFL3+NqFR+IIIejX69g7QP24g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=noa-archive.com; dmarc=pass action=none header.from=noa-archive.com; dkim=pass header.d=noa-archive.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=noa-archive.com; Received: from DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) by PR3PR09MB4329.eurprd09.prod.outlook.com (2603:10a6:102:3c::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6002.24; Wed, 18 Jan 2023 08:51:27 +0000 Received: from DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::520c:6bd4:410d:a2bc]) by DB4PR09MB5847.eurprd09.prod.outlook.com ([fe80::520c:6bd4:410d:a2bc%7]) with mapi id 15.20.6002.024; Wed, 18 Jan 2023 08:51:27 +0000 Message-ID: <9135ef14-f767-095d-5ea6-40c9df9e0695@noa-archive.com> Date: Wed, 18 Jan 2023 09:51:25 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Tobias Rapp Organization: NOA GmbH In-Reply-To: X-ClientProxiedBy: FR2P281CA0017.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:a::27) To DB4PR09MB5847.eurprd09.prod.outlook.com (2603:10a6:10:38d::8) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB4PR09MB5847:EE_|PR3PR09MB4329:EE_ X-MS-Office365-Filtering-Correlation-Id: bcbd5d9d-4571-4ff0-ba84-08daf9312f92 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FCvh+oIsOa3VTE6rNWWUfqSr9ea7nObQN7gsZVjhYm8iNGn+Ev6xh4KEQ4n+J8bS+6kLBADdyKE3OOlG5em0gtzI7z7BGyNP+H7wbXHmTvrvhe3AmqIVBcFBIfZfD0kRPhrR/7fdD8MT2P/mL6p/rG1fmCnXF8qYJx/e7yT2ekzO4gHpdylDOuHxTbXWfrxMfj7DQhA2uJ+LBKN1HLVGWITNO5pRNBdKmKMyVY68SGO6Ww5T2cAhpUmFrdTRPDkrzsI/koJ7dajBS1CsEIN+d5w9fhZG2fgVjGjQQtZ78dU7rdwvitjg4ddaPCvXXYmkxlsTG0jwO0UChQPpfsPmOCKOWyowrO8a8qdkf5F2MVBxVpd5EYTSfpMFTTRbp0SyBkZng8K2zqjJroj0jOOWiKVQNcKOw99awnauq7dizzGsj5YegLxvPgDK/BFVkO9w5X0ZQQfpf+vmHJZ9NkHQiwzeOpCD42sv78Tw+8PdH9q2trN1lYotP8lhngRfVWDonUe2DWVr3ui08+d9s3R+zfZqOw/KOPVhO3ptGKH9NFmSlS7AHF6gZknoQ2t69at/ByU/wN1gDqWn2KckZx0afoJT/fTREMYdEIam3k7nzjjYDqlcWLT4tbZx6uNd9drUXX78AHzCo+qnnZWJEPxe7DZgAuFCX2vRGqF9SGMGmptymAgprDyTl+Yj6nqkcKfGAEK/Qy0Pw7L6p5bTayvozoLS0dGlQ8VrRBzr7syujco= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB4PR09MB5847.eurprd09.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230022)(366004)(396003)(346002)(136003)(376002)(39830400003)(451199015)(316002)(31696002)(38100700002)(86362001)(66476007)(8936002)(5660300002)(2906002)(66556008)(66946007)(8676002)(41300700001)(6916009)(26005)(2616005)(6512007)(186003)(83380400001)(53546011)(36916002)(6486002)(6506007)(36756003)(478600001)(31686004)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1RKakVDelhUSlZnZHBFejR5WXE3dEVTWTI3RGo3NXVld0h4TjhJM0k1U1Nn?= =?utf-8?B?OUpNampMOTFKamxIdlo3VnhlSHFwa09ES0x4TlJGYWdxeDVkcUh0MjI3M0Zz?= =?utf-8?B?NDdJR05pYzhjK1RxQWthcEh4Y1hveDVQSFdFUUxVNUVFOWNuSFh4SU55UFB5?= =?utf-8?B?RmxkRDhmMFRlTlpaNDZVKzh5Ym02TkJhZmdEM1pIalp4RFJ3ZzczTXp4YnFG?= =?utf-8?B?SDRrKzBLK3RaTGgxaUwvOXNtRXQzZkQ5VlNncmZpcUpLVnVTeFBnZEdLNEJv?= =?utf-8?B?NEV0RFl1dHdxRjFTa1E1WnpLazY5Nkh2aGNSNkJycDJZQ0pKVUhabTBJOXF3?= =?utf-8?B?TnY0a0dtN0RwTnBlK3FYOEkrQlJKbGMyV3JXbDZMQ3R0c3h1VTdxQ2NTZVJY?= =?utf-8?B?RTlRYU15b3JrTmxkaVJFMURuUDZIdGl6YzFpZzMzK0dUdndjcmRJeEQweTUz?= =?utf-8?B?SVNBMWc4TEtqWjZQdVh6YUtaSmFGYXVGdUpTNHdJTlNuM0NNM1RhY1FwY3kz?= =?utf-8?B?VjdEWUY5QTBYRk8rZEVKcUtRbHo4ME5XQmdvRy9VNkxXWlZOMDI5YmpQb2Rq?= =?utf-8?B?ZTRhQUxlMkhmM0xaekFkUUh3YzVPdVJtUGhoY2x5a0ZQQ09yZnJ6UUMwTVZC?= =?utf-8?B?TGtTVzBJQTAvODVaY2toTHI2bUZtbGd3NVhOYi9YTlNnSzNzRG1DcmJmaEVT?= =?utf-8?B?WHFONnVrNnFPT28rMFJ5VXVrZjJIV2Q2ejlNMmhlc093dHJKRnhzV2JxVDVG?= =?utf-8?B?Z095TmlUbUNidVBmU0ZISHI3aUlKMHhTOGxTazUrTzRmZlhkcERKSWVaQ1NQ?= =?utf-8?B?VktaOTVqUDJRRUdtT2F1S1YrcVJDT1VWOS9CdjVUcG91dWhUME8zRHNXRkNJ?= =?utf-8?B?dXQzVkNkQW1pRkUzelJ5cytUbmhwdEdWa3ZDNXNMZTRpcDc5VC9nUEN0NFQ4?= =?utf-8?B?SHNXdXZqSUtlYWhLTE1MdDdZeDRwcjRkcUlteS90K1pkSm1QWmljYzl3RHNR?= =?utf-8?B?dXBsT0NMbTBvanF4U2doZG9nUFNJblBCNHVTY1Erd2VRbWJSL2hGRUpDUGJY?= =?utf-8?B?TFF4OVhiVjk1KzV1dGtzakgzRDZwczBpdnllMlM3R3VCbHhpek9VNE5MQ2dW?= =?utf-8?B?ZDRzd0oycjhSQ1FlWnBOY0pncUswQnZtVEpkWHB6Y3ZWY1pQOXloNmxTYVBI?= =?utf-8?B?OE1reXF0UUtITXlvSVpoUnlRYVZMQWU4Qm8rVjB1QlZ2QXdvZzdqVHNKdlR4?= =?utf-8?B?aFlNSVBpZER1clhpRHZkTEN5amtXRVF1dnVPMnNsQXZFdE9MbXNmcWxBMDYw?= =?utf-8?B?Z1poUkhmRWRncXlYclBCcUZzV3EyZDR3K1FVNllYTjNqc1JKcmV2OC9KOGNT?= =?utf-8?B?QVk4cnZrRFJzdVRFZEZSb3Nsc2FQOTFzYUZEa3pmWnlLUGhQN2dvYUw4ODZm?= =?utf-8?B?MEpRQUUyM1BFTWhNblM4dStpeFdJR1A3K3lLMnFaNm5aTENVU2hqV0MvdTdK?= =?utf-8?B?S1VPd0pONHJwOXF6bzZYZm1kSlA0R3VZdEVTNGVDNUwrbit5SitzeHNINVQ4?= =?utf-8?B?V2ZITEJRWjRFRXlCY29TSzU5RjZpa1VNdWdRSDZVMzNQOENoQ3RxZlVOTXdU?= =?utf-8?B?NXpHRkcvaGpPa2h0cXdFL1JsWFdoZllRbCtSRXZYcDd0Z2VHZHFyTmppOWNl?= =?utf-8?B?dUZKOVNURzZCaVovZkl4TzlOMWVsUVh2WE53R05wclRVc0FkeU5qY3RvNUZq?= =?utf-8?B?ZWV2R1FKa3ZKVG84SFhrcGdxRGdiQisyblV2QU9QUjFHcVd1clYyYnc0dmZy?= =?utf-8?B?dTNaMUppQWhXcEZXaUtweVEvQ05uVGZxckZQQ0l2eEdIeDhWSnJDVXpkVG90?= =?utf-8?B?MkVpQ25DK2ZFN2FlOUJzczhLQzdjMTZBajl0c1ZQNStsSHR6YWJDOXE4U1Jt?= =?utf-8?B?Z25YR1JXZ2dQVnRBbzRUa2V1YkxyeTRxNEFITlVJaUlWRjljWkc3ZGFsTDBq?= =?utf-8?B?VHYwenFRUTJ1OWRMVS9zOWErWVBjT0pFSlh4L3pGNXh1QWRYaHVBOUR5SWpJ?= =?utf-8?B?TThEQUhkeG5oVXJUM2RnVFprSDF4VWk0TEhrcVd2SG53a2RFaEZEOE1XVUZ5?= =?utf-8?B?aWFWVTB4YkpLdXVjbnZ3SlBRWTBDN0dTa3N3Z1VDTGV1c2dya084Q3Flb2NK?= =?utf-8?B?alE9PQ==?= X-OriginatorOrg: noa-archive.com X-MS-Exchange-CrossTenant-Network-Message-Id: bcbd5d9d-4571-4ff0-ba84-08daf9312f92 X-MS-Exchange-CrossTenant-AuthSource: DB4PR09MB5847.eurprd09.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Jan 2023 08:51:27.5050 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a676c8d7-7f39-4c99-a306-48abb76a98e9 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: JI9jcuZkzHwevGnccFB9/5pSGI5hEETpkh/pzpMftg0PAvtlaUmfvPUL3VGzRhLO2LsiVX1WVsQts5UsKfxkhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PR3PR09MB4329 Subject: Re: [FFmpeg-devel] [PATCH] libavutil/log: Support for logging timestamps in the log X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 17/01/2023 22:52, Prakash wrote: > libavutil/log: Support for logging timestamps in the log. > Add 'time' flag to the -loglevel option to turn on timestamp logging. > Useful for troubleshooting where time is spent from the log files. > > Signed-off-by: Prakash Duggaraju The commit message seems to be lacking a blank line between headline and body in the attached patch file. > --- > > doc/fftools-common-opts.texi | 4 ++++ > > fftools/opt_common.c | 6 ++++++ > > libavutil/log.c | 14 ++++++++++++++ > > libavutil/log.h | 8 ++++++++ > > 4 files changed, 32 insertions(+) > > > > diff --git a/doc/fftools-common-opts.texi b/doc/fftools-common-opts.texi > > index d9145704d6..a3cf9eb57d 100644 > > --- a/doc/fftools-common-opts.texi > > +++ b/doc/fftools-common-opts.texi > > @@ -201,6 +201,10 @@ and the "Last message repeated n times" line will be > omitted. > > Indicates that log output should add a @code{[level]} prefix to each > message > > line. This can be used as an alternative to log coloring, e.g. when > dumping the > > log to file. > > +@item time > > +Indicates that log output should add a @code{[time]} prefix to each message > > +line. The time is the relative time in microseconds precision. This can be > > +useful for troubleshooting where time is spent from the logs. Maybe you should mention here that adding the "time" flag practically disables any "repeated" flag if given. > @end table > > Flags can also be used alone by adding a '+'/'-' prefix to set/reset a > single > > flag without affecting other @var{flags} or changing @var{loglevel}. When > > diff --git a/fftools/opt_common.c b/fftools/opt_common.c > > index 8a06df82df..a081ad6b08 100644 > > --- a/fftools/opt_common.c > > +++ b/fftools/opt_common.c > > @@ -1269,6 +1269,12 @@ int opt_loglevel(void *optctx, const char *opt, > const char *arg) > > } else { > > flags |= AV_LOG_PRINT_LEVEL; > > } > > + } else if (av_strstart(token, "time", &arg)) { > > + if (cmd == '-') { > > + flags &= ~AV_LOG_PRINT_TIME; > > + } else { > > + flags |= AV_LOG_PRINT_TIME; > > + } > > } else { > > break; > > } > > diff --git a/libavutil/log.c b/libavutil/log.c > > index 5948e50467..cc16427178 100644 > > --- a/libavutil/log.c > > +++ b/libavutil/log.c > > @@ -42,6 +42,7 @@ > > #include "internal.h" > > #include "log.h" > > #include "thread.h" > > +#include "time.h" > > > > static AVMutex mutex = AV_MUTEX_INITIALIZER; > > > > @@ -319,6 +320,19 @@ static void format_line(void *avcl, int level, const > char *fmt, va_list vl, > > if (*print_prefix && (level > AV_LOG_QUIET) && (flags & > AV_LOG_PRINT_LEVEL)) > > av_bprintf(part+2, "[%s] ", get_level_str(level)); > > > > + if (*print_prefix && (level > AV_LOG_QUIET) && (flags & > AV_LOG_PRINT_TIME)) { > > + int secs, mins; > > + int64_t hours; > > + int64_t time = av_gettime_relative(); > > + float millis = (time % 100000) / 1000.0f; Should be modulo one million, instead one hundred thousand. But see comment regarding formatting below. > + time /= 1000000; > > + secs = time % 60; > > + time /= 60; > > + mins = time % 60; > > + hours = time / 60; > > + av_bprintf(part+2, "[%ldh:%02dm:%02ds:%07.03fms] ", hours, mins, > secs, millis); Adding it to part[2] will colorize time according to the log message level. Maybe add an own AVBPrint buffer for it? > + } > > + > > av_vbprintf(part+3, fmt, vl); > > > > if(*part[0].str || *part[1].str || *part[2].str || *part[3].str) { > > diff --git a/libavutil/log.h b/libavutil/log.h > > index ab7ceabe22..2e2d83f6d0 100644 > > --- a/libavutil/log.h > > +++ b/libavutil/log.h > > @@ -377,6 +377,14 @@ int av_log_format_line2(void *ptr, int level, const > char *fmt, va_list vl, > > */ > > #define AV_LOG_PRINT_LEVEL 2 > > > > +/** > > + * Include the system time with each log message. > > + * Useful for troubleshooting where the time was spent. > > + * Results in messages such as: > > + * [rawvideo @ 0xDEADBEEF] [01h:03m:05s:3.112ms] [error] encode did not > produce valid pts In my personal opinion I find formatting the timestamp with integer seconds and float milliseconds a bit weird. Using float seconds (like HH:MM:SS.mmm) would look more familiar to me. And maybe add the timestamp at the very front of the formatted log message? That way it should be easier to scroll through the log file and spot time jumps. > + */ > > +#define AV_LOG_PRINT_TIME 4 > > + > > void av_log_set_flags(int arg); > > int av_log_get_flags(void); Regards, Tobias _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".