From: Marton Balint <cus@passwd.hu>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 4/4] avfilter/vf_zscale: realign output buffer if needed
Date: Wed, 16 Mar 2022 23:01:19 +0100 (CET)
Message-ID: <90d19382-6ae2-a1a5-719a-87433cb5f5d9@passwd.hu> (raw)
In-Reply-To: <905fd001-1562-816d-332e-4a0d10fcbfab@gmail.com>
On Wed, 16 Mar 2022, James Almer wrote:
> On 3/14/2022 6:06 PM, Marton Balint wrote:
>> Output buffer alignment might be different to ZIMG_ALIGNMENT or it may not
>> be
>> aligned at all if a downstream filter (e.g. vf_pad) intentionally
>> misaligns it.
>
> av_frame_get_buffer() align parameter is used to align linesizes, not
> buffers. av_malloc() has a hardcoded alignment defined at compile time based
> on configure settings.
Good point.
>
> If what you need is aligned data pointers, you should either use the trick i
> used in the libdav1d wrapper, or change av_malloc() in order to use
> av_cpu_max_align().
Actually av_cpu_max_align() also depends on compile time, so your trick is
the only way to ensure ZIMG alignment as far as I see...
Regards,
Marton
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2022-03-16 22:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-14 21:06 [FFmpeg-devel] [PATCH 1/4] avfilter/x86/vf_blend: use unaligned movs for output Marton Balint
2022-03-14 21:06 ` [FFmpeg-devel] [PATCH 2/4] avfilter/vf_zscale: fix number of threads Marton Balint
2022-03-14 21:58 ` Paul B Mahol
2022-03-16 11:33 ` Victoria Zhislina
2022-03-16 19:26 ` Marton Balint
2022-03-14 21:06 ` [FFmpeg-devel] [PATCH 3/4] avfilter/vf_zscale: properly check return value of slice threads Marton Balint
2022-03-14 21:59 ` Paul B Mahol
2022-03-14 21:06 ` [FFmpeg-devel] [PATCH 4/4] avfilter/vf_zscale: realign output buffer if needed Marton Balint
2022-03-14 21:59 ` Paul B Mahol
2022-03-16 20:52 ` James Almer
2022-03-16 20:58 ` James Almer
2022-03-16 22:01 ` Marton Balint [this message]
2022-03-18 10:40 ` [FFmpeg-devel] [PATCH 1/4] avfilter/x86/vf_blend: use unaligned movs for output Paul B Mahol
2022-03-20 23:56 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90d19382-6ae2-a1a5-719a-87433cb5f5d9@passwd.hu \
--to=cus@passwd.hu \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git