From: Jerome Martinez <jerome@mediaarea.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] avformat/mxfenc: fix stored/sampled/displayed width/height
Date: Sun, 15 Jan 2023 15:24:37 +0100
Message-ID: <90886e84-2dff-5e05-6802-ec577a4307ff@mediaarea.net> (raw)
In-Reply-To: <20230114200452.GQ1949656@pb2>
On 14/01/2023 21:04, Michael Niedermayer wrote:
> On Sat, Jan 14, 2023 at 04:48:10PM +0100, Jerome Martinez wrote:
> [...]
>> + stored_height = (stored_height+15)/16*16;
> If this is supposed to match the actual macroblocks, then this would
> have to consider field pictures and interlacing as it differs from
> progressive
There is no change on that side, no addition, no change about it, this
code is moved, and interlace is already managed in the current code:
//Stored height
mxf_write_local_tag(s, 4, 0x3202);
avio_wb32(pb, stored_height>>sc->interlaced);
[...]
//Display height
mxf_write_local_tag(s, 4, 0x3208);
avio_wb32(pb, display_height>>sc->interlaced);
The patch disables the rounding for some formats, it is not intended to
change the behavior for MPEG-2 Video and AVC formats as it seems fine
(FFmpeg has the same behavior as other muxers, at least for MPEG-2
Video, also for interlaced content).
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-01-15 14:24 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-14 15:48 Jerome Martinez
2023-01-14 20:04 ` Michael Niedermayer
2023-01-15 14:24 ` Jerome Martinez [this message]
2023-01-15 16:55 ` Michael Niedermayer
2023-01-16 13:50 ` Tomas Härdin
2023-01-16 14:28 ` Jerome Martinez
2023-01-18 10:10 ` Tomas Härdin
2023-01-16 14:00 ` Nicolas Gaullier
2023-01-16 15:49 ` Jerome Martinez
2023-01-16 18:15 ` Nicolas Gaullier
2023-03-06 17:09 ` Nicolas Gaullier
2023-03-10 21:10 ` Marton Balint
2023-03-13 22:30 ` Marton Balint
2023-03-13 22:39 ` Pierre-Anthony Lemieux
2023-03-14 9:41 ` Jerome Martinez
2023-03-26 19:32 ` Marton Balint
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=90886e84-2dff-5e05-6802-ec577a4307ff@mediaarea.net \
--to=jerome@mediaarea.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git