From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 390864AD84 for ; Sat, 22 Jun 2024 19:57:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 31A1668D4ED; Sat, 22 Jun 2024 22:57:35 +0300 (EEST) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id B115C68D265 for ; Sat, 22 Jun 2024 22:57:28 +0300 (EEST) Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-7067272245aso194961b3a.1 for ; Sat, 22 Jun 2024 12:57:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1719086245; x=1719691045; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=tItA7bTPW+JGRmze+Q34TCCNU2SM5LpjRU7Xk8KHAY4=; b=aSbsBG3wE2Rzbwa9DIF5/U+xV4p9kOG53rInzMhKCVtEpjTfaZvcSQjYA//AtjJdlY Y84TokeYGOvYyQ8NQnsH9UqgNrhJ3nsLaVd2YYTMP6ThOMV89Y7Bfy/G6oJPvSIAzEta VbcCDxLRII9U1tPpzM5C5gZjj6DeDzZe9RO3LQ62ARcrmKNgNLd480q/YIEYOEcKEJH6 z9+F7xPAjO/K+/I8zI6L0rMJ/FtyxXmkiL0oWj+ScueTRGeJYu2izMQ+rsmF8d2zsrlN cJ1tx8lWqUi79inJvTGzkad+ShG/7M1LRlTHlta5ghtEuOfw/EDGSzSNEGQDS5TeCir0 Zedg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1719086245; x=1719691045; h=content-transfer-encoding:in-reply-to:content-language:references :to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tItA7bTPW+JGRmze+Q34TCCNU2SM5LpjRU7Xk8KHAY4=; b=YMhI10MdJKwjxdBCzcQdnWLqdqm2zhjiQq8soMzGlkiDvGYJqfsDDBkyA0yfCm84kk +klI5aPWb3ZIUwibYx3ptUmY0MVXU29eKEWc5rVgYoV6yEz0d/LO/W3tch0FizVoGqvO h31wJnf/4C9OKlcG2uMRCO0qgqEWf6IvvP2q1r+WtBsMFcdFBvzGIJmzIud00RcqQXxE b2afckw7Prg+DVojcfNQ74m66iYa63SoaVgcia2s2GrhKO4vUChOGkqbISQHi5d4FtmC qvuRxe748SvQWd+ajItdrTsX16Maj6vCGNjqpYDpc6xqUs4U8tAb8OOR/nAe8FxbGM9v RoHw== X-Gm-Message-State: AOJu0YyT30BrOCdIcATXEajwB0R1PO/MgQE52ilvZFr+hELxbJb2Il4Y tkkkR1gbmfbnx3gJwWy/da9MdB0H45ekBTO45XCRsvMqtb3fmV8oBdnBWg== X-Google-Smtp-Source: AGHT+IGHm/Qp/BTRe1uDeQMd9aXj1fM+iWhUUHoFyUI+jxP8b24KRYnXl3GoPYk7UkQANIouszIjiQ== X-Received: by 2002:a05:6a20:4fb0:b0:1b8:4216:14b7 with SMTP id adf61e73a8af0-1bcf7fc2cdamr357901637.39.1719086245347; Sat, 22 Jun 2024 12:57:25 -0700 (PDT) Received: from [192.168.0.16] ([190.194.167.233]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2c81eaf92b2sm3556940a91.40.2024.06.22.12.57.24 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 22 Jun 2024 12:57:24 -0700 (PDT) Message-ID: <9074c5d1-eec8-4a57-b0b4-c2e28afd2f15@gmail.com> Date: Sat, 22 Jun 2024 16:57:35 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: James Almer To: ffmpeg-devel@ffmpeg.org References: <20240622153122.6220-1-jamrial@gmail.com> Content-Language: en-US In-Reply-To: <20240622153122.6220-1-jamrial@gmail.com> Subject: Re: [FFmpeg-devel] [PATCH 1/8 v3] avutil/stereo3d add a Monoscopic view enum value X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 6/22/2024 12:31 PM, James Almer wrote: > We need a way to signal the frame has a single view that doesn't map to any > particular eye, and it should be the default one. > > Signed-off-by: James Almer > --- > Now updating all the fate test... > > The 3D ones will be updated again in the following commits once ffprobe is > adapted to properly handle the view field. Ok, turns out AVStereo3DView is not by Derek from a few days ago but by Vittorio from 7 years ago, so of course this change is not ok. The new value would need to be added last and moved to the beginning after a major bump. > > libavutil/stereo3d.c | 3 ++- > libavutil/stereo3d.h | 9 +++++++-- > tests/ref/fate/matroska-spherical-mono | 2 +- > tests/ref/fate/matroska-spherical-mono-remux | 4 ++-- > tests/ref/fate/matroska-stereo_mode | 8 ++++---- > tests/ref/fate/matroska-vp8-alpha-remux | 2 +- > tests/ref/fate/mov-spherical-mono | 2 +- > 7 files changed, 18 insertions(+), 12 deletions(-) > > diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c > index 19e81e4124..0c0cad127c 100644 > --- a/libavutil/stereo3d.c > +++ b/libavutil/stereo3d.c > @@ -68,9 +68,10 @@ static const char * const stereo3d_type_names[] = { > }; > > static const char * const stereo3d_view_names[] = { > - [AV_STEREO3D_VIEW_PACKED] = "packed", > + [AV_STEREO3D_VIEW_MONO] = "monoscopic", > [AV_STEREO3D_VIEW_LEFT] = "left", > [AV_STEREO3D_VIEW_RIGHT] = "right", > + [AV_STEREO3D_VIEW_PACKED] = "packed", > }; > > static const char * const stereo3d_primary_eye_names[] = { > diff --git a/libavutil/stereo3d.h b/libavutil/stereo3d.h > index 00a5c3900e..77340f72b2 100644 > --- a/libavutil/stereo3d.h > +++ b/libavutil/stereo3d.h > @@ -143,9 +143,9 @@ enum AVStereo3DType { > */ > enum AVStereo3DView { > /** > - * Frame contains two packed views. > + * Frame is monoscopic. > */ > - AV_STEREO3D_VIEW_PACKED, > + AV_STEREO3D_VIEW_MONO, > > /** > * Frame contains only the left view. > @@ -156,6 +156,11 @@ enum AVStereo3DView { > * Frame contains only the right view. > */ > AV_STEREO3D_VIEW_RIGHT, > + > + /** > + * Frame contains two packed views. > + */ > + AV_STEREO3D_VIEW_PACKED, > }; > > /** > diff --git a/tests/ref/fate/matroska-spherical-mono b/tests/ref/fate/matroska-spherical-mono > index b108596350..aa17e9c624 100644 > --- a/tests/ref/fate/matroska-spherical-mono > +++ b/tests/ref/fate/matroska-spherical-mono > @@ -3,7 +3,7 @@ > side_data_type=Stereo 3D > type=2D > inverted=0 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > diff --git a/tests/ref/fate/matroska-spherical-mono-remux b/tests/ref/fate/matroska-spherical-mono-remux > index eec41b77f3..75a9b73a37 100644 > --- a/tests/ref/fate/matroska-spherical-mono-remux > +++ b/tests/ref/fate/matroska-spherical-mono-remux > @@ -27,7 +27,7 @@ DISPOSITION:forced=1 > side_data_type=Stereo 3D > type=2D > inverted=0 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > @@ -56,7 +56,7 @@ DISPOSITION:forced=0 > side_data_type=Stereo 3D > type=2D > inverted=0 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > diff --git a/tests/ref/fate/matroska-stereo_mode b/tests/ref/fate/matroska-stereo_mode > index 26c325b20e..e35425ae76 100644 > --- a/tests/ref/fate/matroska-stereo_mode > +++ b/tests/ref/fate/matroska-stereo_mode > @@ -132,7 +132,7 @@ TAG:DURATION=00:00:10.000000000 > side_data_type=Stereo 3D > type=side by side > inverted=0 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > @@ -152,7 +152,7 @@ TAG:DURATION=00:00:10.000000000 > side_data_type=Stereo 3D > type=top and bottom > inverted=1 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > @@ -170,7 +170,7 @@ TAG:DURATION=00:00:10.000000000 > side_data_type=Stereo 3D > type=interleaved lines > inverted=1 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > @@ -189,7 +189,7 @@ TAG:DURATION=00:00:10.000000000 > side_data_type=Stereo 3D > type=interleaved columns > inverted=1 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > diff --git a/tests/ref/fate/matroska-vp8-alpha-remux b/tests/ref/fate/matroska-vp8-alpha-remux > index 06bcc4b4ba..814463eeda 100644 > --- a/tests/ref/fate/matroska-vp8-alpha-remux > +++ b/tests/ref/fate/matroska-vp8-alpha-remux > @@ -35,7 +35,7 @@ DISPOSITION:still_image=0 > side_data_type=Stereo 3D > type=2D > inverted=0 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 > diff --git a/tests/ref/fate/mov-spherical-mono b/tests/ref/fate/mov-spherical-mono > index b108596350..aa17e9c624 100644 > --- a/tests/ref/fate/mov-spherical-mono > +++ b/tests/ref/fate/mov-spherical-mono > @@ -3,7 +3,7 @@ > side_data_type=Stereo 3D > type=2D > inverted=0 > -view=packed > +view=monoscopic > primary_eye=none > baseline=0 > horizontal_disparity_adjustment=0/1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".