From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A19BC4A209 for ; Wed, 24 Apr 2024 10:58:20 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A531C68D2B5; Wed, 24 Apr 2024 13:58:17 +0300 (EEST) Received: from mail-lf1-f41.google.com (mail-lf1-f41.google.com [209.85.167.41]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 671C468D210 for ; Wed, 24 Apr 2024 13:58:11 +0300 (EEST) Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-5171a529224so8434563e87.0 for ; Wed, 24 Apr 2024 03:58:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=martin-st.20230601.gappssmtp.com; s=20230601; t=1713956290; x=1714561090; darn=ffmpeg.org; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=8/4oEz5BG+f6+cD5q1SNUwN6jYj3GueVrYCCk6nJKoI=; b=iN0brEJzFM3nAcHnfi3aHQMWzcpkcitYHENlvk5V5Bfv7Cz9WRRLoGfwVrxG4qc1J6 B8UR6l4kwmXo78Mtx5lBm2KodbPxAi0zWGWuH1NyUZkXp9H0/MWX6y6cWNZCovEG9hmW ee+0rLAMmg0zwKONmjFu91zW66YY3ZOCQhWR/m++EtwpHQBRsN7zfKbFaPGJzWaxO44Z ExIR/x2hKI1SgmzqbP2UpLeez3+umt5rFCv8Gq32fT/oZnvuJrk5XWBsnCh6SXLm2T/Q qITP/yHUcd83074MoPsRgxUcIOVNdaVim/tu5aml8HCjWKDKgvsSX8X0lxdxl3PrzoLK Oi4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713956290; x=1714561090; h=mime-version:references:message-id:in-reply-to:subject:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8/4oEz5BG+f6+cD5q1SNUwN6jYj3GueVrYCCk6nJKoI=; b=my60GG9TcgxjAsSUoNWaZYl4Afv+XI6mS0JsxxxMQJAFL61F7QYNhYcclL2xkGrQFn tnP5g+gaoZJHXdcvsdFYA2rwXNpqXyBX2n3ddvwEzgLCwGl0HkWkDcHiEpFTF2asZJvQ DBiOecb27Ol9zc0uHDXWdxB8KtvNIBE8C2fe6xGqukZh53kHuXAEmPrPX2K4nhe39P4i gtuSW4/QrWN6AcoBPA8crpdqDXR+QSSi1xeoSPp5TDxl3hshw41xygof4KK+9jFY5YS2 zLQtql6eVPL+wHat1A25kpexpnu6JKhhPJGC32Dv8qtkEkwDo9/mNX9owMZG98YZ2ZGu 9ukA== X-Gm-Message-State: AOJu0Yw92P9aVzdzKxBTXV0pZpoSnwYbPuBz5f4A7N1tW7gl8j/Hgx+r UaQdVlCcN22gqakEzKbqckapihTeUwnSkfDWSY7pB3snBQU2pcEa7UI6Rq9YUm5ptoBpytol5Er c3g== X-Google-Smtp-Source: AGHT+IFKqZIConDc12r5YEyjACKBevgDp5VdAhP1w7qOiSlOn4sgGLWaCHNPUiGfiH3LfUltoOJR2w== X-Received: by 2002:ac2:5f55:0:b0:518:c902:f992 with SMTP id 21-20020ac25f55000000b00518c902f992mr1219981lfz.9.1713956290406; Wed, 24 Apr 2024 03:58:10 -0700 (PDT) Received: from tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net (tunnel335574-pt.tunnel.tserv24.sto1.ipv6.he.net. [2001:470:27:11::2]) by smtp.gmail.com with ESMTPSA id v4-20020ac258e4000000b00516cba5b4cesm2362301lfo.46.2024.04.24.03.58.09 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Apr 2024 03:58:10 -0700 (PDT) Date: Wed, 24 Apr 2024 13:58:08 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20240422142547.281064-3-derek.buitenhuis@gmail.com> Message-ID: <90304d9b-d2cd-bf6-88c2-1fb95982e75f@martin.st> References: <20240422142547.281064-1-derek.buitenhuis@gmail.com> <20240422142547.281064-3-derek.buitenhuis@gmail.com> MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 2/9] avformat/http: Use AVERROR_HTTP_TOO_MANY_REQUESTS X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 22 Apr 2024, Derek Buitenhuis wrote: > Added in thep previous commit. > > Signed-off-by: Derek Buitenhuis > --- > libavformat/http.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/http.c b/libavformat/http.c > index ed20359552..bbace2694f 100644 > --- a/libavformat/http.c > +++ b/libavformat/http.c > @@ -286,6 +286,7 @@ static int http_should_reconnect(HTTPContext *s, int err) > case AVERROR_HTTP_UNAUTHORIZED: > case AVERROR_HTTP_FORBIDDEN: > case AVERROR_HTTP_NOT_FOUND: > + case AVERROR_HTTP_TOO_MANY_REQUESTS: > case AVERROR_HTTP_OTHER_4XX: > status_group = "4xx"; > break; > @@ -522,6 +523,7 @@ int ff_http_averror(int status_code, int default_averror) > case 401: return AVERROR_HTTP_UNAUTHORIZED; > case 403: return AVERROR_HTTP_FORBIDDEN; > case 404: return AVERROR_HTTP_NOT_FOUND; > + case 429: return AVERROR_HTTP_TOO_MANY_REQUESTS; > default: break; > } > if (status_code >= 400 && status_code <= 499) > @@ -558,6 +560,10 @@ static int http_write_reply(URLContext* h, int status_code) > reply_code = 404; > reply_text = "Not Found"; > break; > + case 429: > + reply_code = 429; > + reply_text = "Too Many Requests"; > + break; > case 200: This function seems to handle both the literal status codes, like 429, and also AVERROR style error codes, as when called from handle_http_errors, so perhaps it would be good for consistency to add the AVERROR here too. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".