From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 3F00640CDE for ; Thu, 10 Mar 2022 13:09:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 8C7C268B13C; Thu, 10 Mar 2022 15:09:27 +0200 (EET) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4050468AC80 for ; Thu, 10 Mar 2022 15:09:21 +0200 (EET) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 22AD9JNM008985-22AD9JNN008985 for ; Thu, 10 Mar 2022 15:09:19 +0200 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 5BCC0A142A for ; Thu, 10 Mar 2022 15:09:19 +0200 (EET) Date: Thu, 10 Mar 2022 15:09:18 +0200 (EET) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220214130007.2781962-1-adrian.ratiu@collabora.com> Message-ID: <8fd2c1d-125d-c1e9-8c9e-97469da57bc9@martin.st> References: <20220214130007.2781962-1-adrian.ratiu@collabora.com> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] configure: move ranlib -D test after setting defaults X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Mon, 14 Feb 2022, Adrian Ratiu wrote: > In Gentoo and ChromeOS we want to allow pure LLVM builds without > using GNU tools, so we block any unwanted mixed GNU/LLVM usages > (GNU tools are still kept around in our chroots for projects > like glibc which cannot yet be built otherwise). > > The default ${cross_prefix}${ranlib_default} points to GNU and > fails, so move the test a bit later - after the defaults are > set and the proper values get overriden - such that ffmpeg > configure calls the llvm-ranlib we desire. [1] > > [1] https://gitweb.gentoo.org/repo/gentoo.git/tree/media-video/ffmpeg/ffmpeg-4.4.1-r1.ebuild?id=7a34377e3277a6a0e2eedd40e90452a44c55f1e6#n477 > > Signed-off-by: Adrian Ratiu > --- > configure | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/configure b/configure > index a251e27723..61c150959e 100755 > --- a/configure > +++ b/configure > @@ -4416,11 +4416,7 @@ cc_default="${cross_prefix}${cc_default}" > cxx_default="${cross_prefix}${cxx_default}" > nm_default="${cross_prefix}${nm_default}" > pkg_config_default="${cross_prefix}${pkg_config_default}" > -if ${cross_prefix}${ranlib_default} 2>&1 | grep -q "\-D "; then > - ranlib_default="${cross_prefix}${ranlib_default} -D" > -else > - ranlib_default="${cross_prefix}${ranlib_default}" > -fi > +ranlib_default="${cross_prefix}${ranlib_default}" > strip_default="${cross_prefix}${strip_default}" > windres_default="${cross_prefix}${windres_default}" > > @@ -4453,6 +4449,10 @@ set_default arch cc cxx doxygen pkg_config ranlib strip sysinclude \ > enabled cross_compile || host_cc_default=$cc > set_default host_cc > > +if ${ranlib} 2>&1 | grep -q "\-D "; then > + ranlib="${ranlib} -D" > +fi > + > pkg_config_fail_message="" > if ! $pkg_config --version >/dev/null 2>&1; then > warn "$pkg_config not found, library detection may fail." > -- > 2.35.0 I noticed this patch which doesn't seem to have gotten any feedback. This patch seems sensible to me; I'll try to go ahead and test it and will push it if I don't see any issue with it. // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".