From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 60D8A4D6B7 for ; Sat, 22 Feb 2025 13:17:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7853768C5AB; Sat, 22 Feb 2025 15:17:25 +0200 (EET) Received: from btbn.de (btbn.de [144.76.60.213]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 66EE6680927 for ; Sat, 22 Feb 2025 15:17:19 +0200 (EET) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id DCFC72819FDE6 for ; Sat, 22 Feb 2025 14:17:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1740230238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dashevMUs6jvWzpKvH4bDjFyyJFluIVEfL2rX9tnieQ=; b=o3QNejlJ5pqv6rRxIGZaC3dYwkY+Hpz3u6+P0/qVYTWgtcWjh7ZL31rF6iv2Lr9MklHY9m CP1Xx/mcdFcYYHJBKBeEzTUM4bQVUL6M8R5eMK1pcvI783/xynzYs32wRUa3OLH+j2TH61 e2Gi/CtgKWD2yscoYV0k003fzxSMuqcY99Mo6baIKoTncxUW7PnkFnv20LD62raClLjbEe hLdnNCMjJGsDldLTwZYUrMSZt6fWNfJOu50JfQqG25x3+2RTt+zfghfvlqsUGRkWBc20my NKqM/kQ0kDG+G7yDY3qdl1vilNG7s7LKzs57tN2qxr0JGvqBI9rWfMqU14PgLw== Message-ID: <8fafeb3b-d2c7-44cc-81bb-f7dbfa88c8d9@rothenpieler.org> Date: Sat, 22 Feb 2025 14:17:19 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: ffmpeg-devel@ffmpeg.org References: <20250222051423.411-1-ffmpeg@gyani.pro> Content-Language: en-US From: Timo Rothenpieler In-Reply-To: <20250222051423.411-1-ffmpeg@gyani.pro> Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: unbreak build with latest svtav1 X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 22.02.2025 06:14, Gyan Doshi wrote: > SVT-AV1 made a change in their public API in 988e930c but without a > version bump or any other accessible marker, thus breaking ffmpeg build > with current versions of SVT-AV1. > > They have finally bumped versions a month later, so check added. > --- > libavcodec/libsvtav1.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c > index 79b28eb4df..43fe531fde 100644 > --- a/libavcodec/libsvtav1.c > +++ b/libavcodec/libsvtav1.c > @@ -435,7 +435,11 @@ static av_cold int eb_enc_init(AVCodecContext *avctx) > > svt_enc->eos_flag = EOS_NOT_REACHED; > > +#if SVT_AV1_CHECK_VERSION(3, 0, 0) > + svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, &svt_enc->enc_params); > +#else > svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, svt_enc, &svt_enc->enc_params); > +#endif > if (svt_ret != EB_ErrorNone) { > return svt_print_error(avctx, svt_ret, "Error initializing encoder handle"); > } LGTM _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".