Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: unbreak build with latest svtav1

From: Timo Rothenpieler <timo@rothenpieler.org>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libsvtav1: unbreak build with latest svtav1
Date: Sat, 22 Feb 2025 14:17:19 +0100
Message-ID: <8fafeb3b-d2c7-44cc-81bb-f7dbfa88c8d9@rothenpieler.org> (raw)
In-Reply-To: <20250222051423.411-1-ffmpeg@gyani.pro>

On 22.02.2025 06:14, Gyan Doshi wrote:
> SVT-AV1 made a change in their public API in 988e930c but without a
> version bump or any other accessible marker, thus breaking ffmpeg build
> with current versions of SVT-AV1.
> 
> They have finally bumped versions a month later, so check added.
> ---
>   libavcodec/libsvtav1.c | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/libavcodec/libsvtav1.c b/libavcodec/libsvtav1.c
> index 79b28eb4df..43fe531fde 100644
> --- a/libavcodec/libsvtav1.c
> +++ b/libavcodec/libsvtav1.c
> @@ -435,7 +435,11 @@ static av_cold int eb_enc_init(AVCodecContext *avctx)
>   
>       svt_enc->eos_flag = EOS_NOT_REACHED;
>   
> +#if SVT_AV1_CHECK_VERSION(3, 0, 0)
> +    svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, &svt_enc->enc_params);
> +#else
>       svt_ret = svt_av1_enc_init_handle(&svt_enc->svt_handle, svt_enc, &svt_enc->enc_params);
> +#endif
>       if (svt_ret != EB_ErrorNone) {
>           return svt_print_error(avctx, svt_ret, "Error initializing encoder handle");
>       }

LGTM
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".