Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Tomas Härdin" <git@haerdin.se>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH] lavf/mxfenc: Bump EDIT_UNITS_PER_BODY
Date: Mon, 13 Feb 2023 10:58:48 +0100
Message-ID: <8f54f0fa3e1877fbc74fd5b52b39f73a97be8858.camel@haerdin.se> (raw)

[-- Attachment #1: Type: text/plain, Size: 141 bytes --]

Passes FATE because we don't have any tests that mux files with a
whopping 250 frames. Tested with a jpeg2000 Tears of Steel sample.

/Tomas

[-- Attachment #2: 0001-lavf-mxfenc-Bump-EDIT_UNITS_PER_BODY.patch --]
[-- Type: text/x-patch, Size: 931 bytes --]

From ad87019bf1ec7540a43e9a56acaf7adb32c917ee Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <git@haerdin.se>
Date: Mon, 13 Feb 2023 10:55:06 +0100
Subject: [PATCH] lavf/mxfenc: Bump EDIT_UNITS_PER_BODY

250 is ridiculously low and leads to excessive partitions and allocations.
This change also makes muxed files smaller, and makes demuxing them faster.
---
 libavformat/mxfenc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
index a29d678098..124b5a6b41 100644
--- a/libavformat/mxfenc.c
+++ b/libavformat/mxfenc.c
@@ -67,7 +67,7 @@ extern const FFOutputFormat ff_mxf_opatom_muxer;
 #define IS_D10(s)    ((s)->oformat == &ff_mxf_d10_muxer.p)
 #define IS_OPATOM(s) ((s)->oformat == &ff_mxf_opatom_muxer.p)
 
-#define EDIT_UNITS_PER_BODY 250
+#define EDIT_UNITS_PER_BODY (1 << 20)
 #define KAG_SIZE 512
 
 typedef struct MXFIndexEntry {
-- 
2.30.2


[-- Attachment #3: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

             reply	other threads:[~2023-02-13  9:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-13  9:58 Tomas Härdin [this message]
2023-02-13 19:33 ` Marton Balint
2023-02-13 20:45   ` Tomas Härdin
2023-02-13 21:05     ` Marton Balint
2023-02-14  9:19       ` Tomas Härdin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8f54f0fa3e1877fbc74fd5b52b39f73a97be8858.camel@haerdin.se \
    --to=git@haerdin.se \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git