From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 39C58439ED for ; Sat, 3 Sep 2022 19:10:58 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D46C468B9FC; Sat, 3 Sep 2022 22:10:55 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9050968B65F for ; Sat, 3 Sep 2022 22:10:49 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 283JAmI5007141-283JAmI6007141; Sat, 3 Sep 2022 22:10:48 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id EF651A1467; Sat, 3 Sep 2022 22:10:47 +0300 (EEST) Date: Sat, 3 Sep 2022 22:10:45 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: Message-ID: <8f3fcc49-5630-6553-4c42-cd9ff6fb9fa4@martin.st> References: MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH] avcodec/mathops: Set hidden visibility where advantageous X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Andreas Rheinhardt Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sat, 3 Sep 2022, Andreas Rheinhardt wrote: > It is advantageous for ff_crop_tab, as the base pointer used to > access this table is not the first element of it. But the real > base pointer is still at a constant offset from the code/the GOT > and can therefore be accessed relative to the instruction pointer > (if supported by the arch) or relative to the GOT; without this, > one has to first load address of ff_crop_tab (potentially via > the GOT) and then offset manually (which is what the earlier code > did). > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mathops.h | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mathops.h b/libavcodec/mathops.h > index f81d21f9c4..c89054d6ed 100644 > --- a/libavcodec/mathops.h > +++ b/libavcodec/mathops.h > @@ -24,6 +24,7 @@ > > #include > > +#include "libavutil/attributes_internal.h" > #include "libavutil/common.h" > #include "config.h" > > @@ -32,7 +33,7 @@ > extern const uint32_t ff_inverse[257]; > extern const uint8_t ff_log2_run[41]; > extern const uint8_t ff_sqrt_tab[256]; > -extern const uint8_t ff_crop_tab[256 + 2 * MAX_NEG_CROP]; > +extern const uint8_t attribute_visibility_hidden ff_crop_tab[256 + 2 * MAX_NEG_CROP]; > extern const uint8_t ff_zigzag_direct[64]; > extern const uint8_t ff_zigzag_scan[16+1]; > > -- > 2.34.1 LGTM // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".