Re: [FFmpeg-devel] [PATCH 2/5] avformat/iamf_writer: Remove nonsense check

[James Almer <jamrial@gmail.com>]

On 2/19/2024 6:52 PM, Andreas Rheinhardt wrote:
> Checking whether a pointer to an element of an array is NULL
> makes no sense, as the pointer addition involved in getting
> the address would be undefined behaviour already if the array
> were NULL.
> In this case the array allocation has already been checked
> a few lines before.
> Fixes Coverity issue #1559548.
> 
> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
> ---
>   libavformat/iamf_writer.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/libavformat/iamf_writer.c b/libavformat/iamf_writer.c
> index 897b06310f..e0c47b5e9d 100644
> --- a/libavformat/iamf_writer.c
> +++ b/libavformat/iamf_writer.c
> @@ -251,8 +251,6 @@ int ff_iamf_add_audio_element(IAMFContext *iamf, const AVStreamGroup *stg, void
>           int nb_channels = iamf_audio_element->layers[i]->ch_layout.nb_channels;
>   
>           IAMFLayer *layer = &audio_element->layers[i];
> -        if (!layer)
> -            return AVERROR(ENOMEM);
>           memset(layer, 0, sizeof(*layer));
>   
>           if (i)

LGTM. I noticed this while rewriting the mp4 implementation, but forgot 
to deal with it.
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".