From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B2C8443E71 for ; Tue, 16 Aug 2022 12:46:33 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2353A68B7A4; Tue, 16 Aug 2022 15:46:31 +0300 (EEST) Received: from mail8.parnet.fi (mail8.parnet.fi [77.234.108.134]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BA5A768AE59 for ; Tue, 16 Aug 2022 15:46:24 +0300 (EEST) Received: from mail9.parnet.fi (mail9.parnet.fi [77.234.108.21]) by mail8.parnet.fi with ESMTP id 27GCkN0M023248-27GCkN0N023248 for ; Tue, 16 Aug 2022 15:46:23 +0300 Received: from foo.martin.st (host-97-187.parnet.fi [77.234.97.187]) by mail9.parnet.fi (Postfix) with ESMTPS id 935E9A146D for ; Tue, 16 Aug 2022 15:46:23 +0300 (EEST) Date: Tue, 16 Aug 2022 15:46:22 +0300 (EEST) From: =?ISO-8859-15?Q?Martin_Storsj=F6?= To: FFmpeg development discussions and patches In-Reply-To: <20220816121206.18448-1-jdek@itanimul.li> Message-ID: <8e7de55-dee-48cb-032-d649f71f7a27@martin.st> References: <1d56db3e-e76b-7472-47-5b7ce1f0aac2@martin.st> <20220816121206.18448-1-jdek@itanimul.li> MIME-Version: 1.0 X-FE-Policy-ID: 3:14:2:SYSTEM Subject: Re: [FFmpeg-devel] [PATCH v3] lavc/aarch64: hevc_add_res add 12bit variants X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Tue, 16 Aug 2022, J. Dekker wrote: > hevc_add_res_4x4_12_c: 46.0 > hevc_add_res_4x4_12_neon: 18.7 > hevc_add_res_8x8_12_c: 194.7 > hevc_add_res_8x8_12_neon: 25.2 > hevc_add_res_16x16_12_c: 716.0 > hevc_add_res_16x16_12_neon: 69.7 > hevc_add_res_32x32_12_c: 3820.7 > hevc_add_res_32x32_12_neon: 261.0 > > Signed-off-by: J. Dekker > --- > > libavcodec/aarch64/hevcdsp_idct_neon.S | 156 ++++++++++++---------- > libavcodec/aarch64/hevcdsp_init_aarch64.c | 34 ++--- > 2 files changed, 105 insertions(+), 85 deletions(-) Thanks, this version seems fine to me. > diff --git a/libavcodec/aarch64/hevcdsp_init_aarch64.c b/libavcodec/aarch64/hevcdsp_init_aarch64.c > index 9cbe983870..b6d5efb77f 100644 > --- a/libavcodec/aarch64/hevcdsp_init_aarch64.c > +++ b/libavcodec/aarch64/hevcdsp_init_aarch64.c > @@ -25,22 +25,18 @@ > #include "libavutil/aarch64/cpu.h" > #include "libavcodec/hevcdsp.h" > > -void ff_hevc_add_residual_4x4_8_neon(uint8_t *_dst, const int16_t *coeffs, > - ptrdiff_t stride); > +void ff_hevc_add_residual_4x4_8_neon(uint8_t *_dst, const int16_t *coeffs, ptrdiff_t stride); The joined forms of these lines end up a bit long, while they previously did fit below the 80 column soft-limit, so IMO I'd prefer to keep them wrapped - but it's not a big deal. (I guess it made more sense to join the lines before the 'const' was added.) // Martin _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".