From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4738348FD0 for ; Tue, 30 Jan 2024 22:34:44 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3E27B68CDD8; Wed, 31 Jan 2024 00:34:42 +0200 (EET) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 0AE8E680078 for ; Wed, 31 Jan 2024 00:34:36 +0200 (EET) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-6dddf4fc85dso2454747b3a.0 for ; Tue, 30 Jan 2024 14:34:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1706654074; x=1707258874; darn=ffmpeg.org; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=QliFx3mdCVo9f9E/BjFT3UPLb4eLXPrQilT5amGfPac=; b=Ngkrei/8dj6Kwa1/FbNZSfs7uVHD27RWH+N1lckDDJx/afArBt85M3bAlpACzeSlst 1rAG3BUFdFc1aM9QOXUZ/visuCA9cFxoLKZ8gnTupDIWMDy03m72aAs2BD0x5C0qfBjv PDfVPtrkupi5BSICYNdv7XeqlMMNGvLZnavRgbK12aXsARnLJi39/a4ZHXp2+eT2FRMj XFd8YAKYqt0CJ/jxZ7W0ziO+FxpfE3d+kr3FetvLQvanwyXTHDQ7r/FDHUjVYWt7j8ug b9dh0aiD/lxZ2Z+0pqCRy6OdLWkhVl5y3jtdWNsCtb3JXJuppe8iI/2CBrt6wpQXszfq 8sjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706654074; x=1707258874; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QliFx3mdCVo9f9E/BjFT3UPLb4eLXPrQilT5amGfPac=; b=D13H/XnMeUO29EoyHjwaAnpwMbLUT+1hZsc1NFxx7F2o9BwqY3lZiXWRSI8eqTV27i vkCYwIdeMirEdnIcNRcRbeDe5KHJItKzBDrr0GpGLbZ92LQ2Tr5E5Hq15u63hZX9jXli 8aapxNVglLvIjui3s0AigLszN/+9P4yCrAtC/IbZPdCLZ/udresrfqZFVsXLUedUxQAA q9qFyQ/kL5nvmKno3RjULc0ERveXsw9b7xTg6YnTjSp02S8xR+eozKAPZoL5e4cK7MD8 XzAWBtGBUONJ38JPbvQ7qE6QrR8Z7Oxt1qfHrUTBiukh/+reJmVf+P2pKqVtdrSvsNxD 8M9Q== X-Gm-Message-State: AOJu0YzxYXC2L2iITC21K04PpfgpPEbOGyR3HY4YeLI7GsPhPUVtWa3F 1ZARys7VA2FPzw1C5fqkwiblW9iBu3b7rkoNL/s8D04i/jBNdGYvi//srFmC X-Google-Smtp-Source: AGHT+IEDwazQh+efBKv1cKbZNiJY5/e/TIDnUlso9hT2UHan/YpZmJUIAGkIXmLaYH1M9N7IA5M0VA== X-Received: by 2002:a05:6a20:4c07:b0:19c:94fb:230b with SMTP id fm7-20020a056a204c0700b0019c94fb230bmr5411329pzb.14.1706654073738; Tue, 30 Jan 2024 14:34:33 -0800 (PST) Received: from [192.168.0.18] (host197.190-225-105.telecom.net.ar. [190.225.105.197]) by smtp.gmail.com with ESMTPSA id q13-20020aa7982d000000b006ddc661a619sm8271593pfl.7.2024.01.30.14.34.32 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Jan 2024 14:34:33 -0800 (PST) Message-ID: <8e3f60bc-1740-451d-9f62-9e004c72604f@gmail.com> Date: Tue, 30 Jan 2024 19:34:56 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20240130221612.970-1-jamrial@gmail.com> From: James Almer Autocrypt: addr=jamrial@gmail.com; keydata= xsBNBFjZtqABCADLW+vdEoZaJZDsIO6geYFTOcn1unsEHefj9zn+3oTHlDFFzO47mzHsSfbK 9JE2xpOJEVnC8FAF5Sayi/pVwV+mtQUV3n5dgVeVBYF9GUQwOGFCpK8X54RRqhkgknbunOEE 0CtgAJgmpFmmmHgq02GvEspx1h/rh4apqwQR6QX4Favb+x9+i9ytVpwVcBX94vo2toyP7h/K BWfadQmb8ltgE1kshfg+SQs/H5bTV5Z1DuEASf02ZL/1qYB/sdTgWPLv9XMUHHsRFmMY8TMx wJSkP+Af3AiYQPJYz1B1D4tt98T/NoiVdin10zATakPjV8hXaobuRmxgakkUASXudydDABEB AAHNH0phbWVzIEFsbWVyIDxqYW1yaWFsQGdtYWlsLmNvbT7CwJIEEwEIADwCGwMGCwkIBwMC BhUIAgkKCwQWAgMBAh4BAheAFiEEd1EujP2UoWlX5pp6FGMBrXN2WeAFAmJoLUUCGQEACgkQ FGMBrXN2WeAFVQf9GtGhniRs1PzNUOgJktCnv6j4BbLieaIPYPEFXKDHOgjqQE2zVMYXnoXl Jam928ii902a8OY06r9ywn/R8ApD1/3NY/v64O71CY9scz5XyH2au8wIZ6HwFy3/f7sqjdGD uctY8Qs7rjT7NkoC5lmgMu2v2k03dGtM9AAf5AK5gU+H0EUw7vmKKiXzUqt5kvBuf4CEwXvH AQT1SMJ52rIlDWB7FQFyZeUbOAK2IgY/KNedfK6nsgd/eQVnlofPd2XoddE7kP6iys7jJefw DD3g3rZyDTq7in5dyk5glaNpWZpbHGBs+9SCYLnfQ8XvWqPFOD+gj0plamKANgOvavKTxM7A TQRY2bagAQgA69YtILj8kYxmqPr/M8+MXT7wVoOWVW9lvSmPquCELaDy/NIS7D06VC5EuE/6 JlJXZMTn37NLlyWhzwOgXuXw5w2tyoQQBuvqGiXJijuXwXH7HKdzrc6rpYtAqt5w05hzNrFS KrS0izG64VpWrfproy3BsL+8TBm9brLhhNPynVRqVukbbGzlATTzNQGZ14TTi2/dL6DkMQnM qn4jX9UEe4GdGQBP50bUJSSmeiIkyNLWA+znuN2PZEz930ZwNrF9GtDVw7mzcmpCZ7spldE2 tutbpy9D1bIqxyqBrYDSezyzL2adR1qgHyOTMCHg2AYNkrIQHrSyJxKTpZ1/hqOp8wARAQAB wsBfBBgBAgAJBQJY2bagAhsMAAoJEBRjAa1zdlnghekH/0Yb0iYJ74oID2f/Fj+AJKS2ekQF P2xOr8lpGzgp/+yWUvPtqbX0A33anBJdYwxaAC0NataX3tfZ+oJkzXqfmqhIHMPYHdZesJA2 Bk9hU/33mDl5s5U66/z0uelWzwKVHoQ2O6or4+qF3HJFSJLCe9uvWJ3zXf9F342Ftj73sfx+ 3xkw/IXsN1RqbYqDlzpoEQ99SIEfY/8Jjwnd3sIPfqkuyeaYfe6GJDqKawdCEP1oRRlbXEAp TJgYz8r3nPhGv9cdHNDCk44ISbsqVuxIEnLqi4fTPZaGupiQhT+srl268TTAp2TQW7+6Ce/b NPQorMquzS/LZoyALpmsYi/miMc= In-Reply-To: Subject: Re: [FFmpeg-devel] [PATCH] avcodec/get_bits: don't shift more bits than available in an unsigned with get_leb() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 1/30/2024 7:19 PM, Andreas Rheinhardt wrote: > James Almer: >> Signed-off-by: James Almer >> --- >> libavcodec/get_bits.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavcodec/get_bits.h b/libavcodec/get_bits.h >> index 9e19d2a439..c0cc7c0a7d 100644 >> --- a/libavcodec/get_bits.h >> +++ b/libavcodec/get_bits.h >> @@ -725,7 +725,7 @@ static inline unsigned get_leb(GetBitContext *s) { >> int byte = get_bits(s, 8); >> unsigned bits = byte & 0x7f; >> more = byte & 0x80; >> - if (i <= 4) >> + if (i <= 3 || (i == 4 && bits < (1 << 4))) >> leb |= bits << (i * 7); >> if (++i == 8) >> break; > > This truncates more bits than necessary, which is IMO against the > documentation of this function. Mmh, true. I'll just leave it as is then. So patch withdrawn. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".