From: James Almer <jamrial@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff
Date: Thu, 4 Jul 2024 17:45:28 -0300
Message-ID: <8e3d794f-e542-4fd6-a09d-94d62388bdd9@gmail.com> (raw)
In-Reply-To: <20240704190503.29148-1-anton@khirnov.net>
On 7/4/2024 4:04 PM, Anton Khirnov wrote:
> Filter output is not bitexact.
> ---
> Reference file at https://up.khirnov.net/7r.pcm, please put it in
> filter-reference/atempo.pcm
How did you create it? x86_32 uses x87 floats which are a lot more
precise than sse ones, for example, so it's best to create a ref file
using such a build.
> ---
> tests/fate/filter-audio.mak | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak
> index cf6065b93f..a3f7aaddbf 100644
> --- a/tests/fate/filter-audio.mak
> +++ b/tests/fate/filter-audio.mak
> @@ -414,7 +414,9 @@ fate-filter-hdcd-s32p: REF = 0c5513e83eedaa10ab6fac9ddc173cf5
>
> FATE_AFILTER_SAMPLES-$(call FILTERDEMDECENCMUX, ATEMPO, WAV, PCM_S16LE, PCM_S16LE, WAV) += fate-filter-atempo
> fate-filter-atempo: tests/data/asynth-44100-1.wav
> -fate-filter-atempo: CMD = framecrc -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0" -ar 44100
> +fate-filter-atempo: CMD = pcm -i $(TARGET_PATH)/tests/data/asynth-44100-1.wav -af "atempo=2.0"
> +fate-filter-atempo: CMP = oneoff
> +fate-filter-atempo: REF = $(SAMPLES)/filter-reference/atempo.pcm
>
> FATE_AFILTER-yes += fate-filter-formats
> fate-filter-formats: libavfilter/tests/formats$(EXESUF)
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2024-07-04 20:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240703094815.28640412658@natalya.videolan.org>
2024-07-04 9:44 ` [FFmpeg-devel] [FFmpeg-cvslog] tests/fate/filter-audio.mak: add test for atempo audio filter Martin Storsjö
2024-07-04 19:04 ` [FFmpeg-devel] [PATCH] tests/fate/filter-audio: convert atempo test to oneoff Anton Khirnov
2024-07-04 20:33 ` Martin Storsjö
2024-07-04 20:45 ` James Almer [this message]
2024-07-05 5:38 ` Anton Khirnov
2024-07-05 16:04 ` James Almer
2024-07-05 17:18 ` Martin Storsjö
2024-07-05 17:37 ` James Almer
2024-07-05 0:00 ` Andreas Rheinhardt
2024-07-05 5:40 ` Anton Khirnov
2024-07-05 18:46 ` Andreas Rheinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e3d794f-e542-4fd6-a09d-94d62388bdd9@gmail.com \
--to=jamrial@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git